From: Jisheng Zhang <jszhang@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Richard Leitner <richard.leitner@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: usb: usb251xb: make reg optional for no I2C ctrl use case
Date: Tue, 19 Aug 2025 19:31:08 +0800 [thread overview]
Message-ID: <aKRgfFpF8thM3vjr@xhacker> (raw)
In-Reply-To: <20250819-eminent-cobra-from-venus-d891b6@kuoka>
On Tue, Aug 19, 2025 at 11:22:51AM +0200, Krzysztof Kozlowski wrote:
> On Tue, Aug 19, 2025 at 08:22:15AM +0800, Jisheng Zhang wrote:
> > Make "reg" optional to allow the driver to be used to manage GPIO
> > based control of the device.
>
> I don't understand how optional reg allows or disallows anything for the
> driver. It's really not relevant to GPIO at all.
w/o this patch, then there will be DT check complains for the following
usb251xb usage:
usb-hub {
compatible = "microchip,usb2512b";
reset-gpios = <&porta 2 GPIO_ACTIVE_LOW>;
};
>
> Also feels wrong, but maybe you just lack proper, reasonable
> justification. Just explain carefully the hardware, not drivers.
It's simple, the hub allows usage w/o connecting to any i2c, see above
example for reference. But current dt-binding make the reg required.
Regards.
next prev parent reply other threads:[~2025-08-19 11:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 0:22 [PATCH v2 0/2] usb: usb251xb: support usage case without I2C control Jisheng Zhang
2025-08-19 0:22 ` [PATCH v2 1/3] dt-bindings: usb: usb251xb: make reg optional for no I2C ctrl use case Jisheng Zhang
2025-08-19 9:22 ` Krzysztof Kozlowski
2025-08-19 11:31 ` Jisheng Zhang [this message]
2025-08-19 0:22 ` [PATCH v2 2/3] usb: usb251xb: use modern PM macros Jisheng Zhang
2025-08-19 0:22 ` [PATCH v2 3/3] usb: usb251xb: support usage case without I2C control Jisheng Zhang
2025-08-19 9:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKRgfFpF8thM3vjr@xhacker \
--to=jszhang@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=richard.leitner@linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).