linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command
@ 2025-08-14 16:30 Venkat Jayaraman
  2025-08-19  9:47 ` Neil Armstrong
  0 siblings, 1 reply; 5+ messages in thread
From: Venkat Jayaraman @ 2025-08-14 16:30 UTC (permalink / raw)
  To: linux-usb; +Cc: gregkh, heikki.krogerus, pse.type-c.linux, venkat.jayaraman

Add support for UCSI READ_POWER_LEVEL command as per
UCSI specification v2.1 and above to debugfs.

Following power related fields will be exposed as files in debugfs:-
peak_current (Peak current),
avg_current (Average current) and
vbus_voltage (VBUS voltage)

These files will be updated either when a READ_POWER_LEVEL
command is sent from OS or when a device is connected.

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Venkat Jayaraman <venkat.jayaraman@intel.com>
---
Changelog v3:
- Rebased to kernel 6.17-rc1

Changelog v2:
- Removed extra space in declaration
- Made the call to debugfs_create_file single line for clarity

 drivers/usb/typec/ucsi/debugfs.c | 31 +++++++++++++++++++++++++++++++
 drivers/usb/typec/ucsi/ucsi.c    | 16 ++++++++++++++++
 drivers/usb/typec/ucsi/ucsi.h    | 13 +++++++++++++
 3 files changed, 60 insertions(+)

diff --git a/drivers/usb/typec/ucsi/debugfs.c b/drivers/usb/typec/ucsi/debugfs.c
index 92ebf1a2defd..f73f2b54554e 100644
--- a/drivers/usb/typec/ucsi/debugfs.c
+++ b/drivers/usb/typec/ucsi/debugfs.c
@@ -35,6 +35,7 @@ static int ucsi_cmd(void *data, u64 val)
 	case UCSI_SET_SINK_PATH:
 	case UCSI_SET_NEW_CAM:
 	case UCSI_SET_USB:
+	case UCSI_READ_POWER_LEVEL:
 		ret = ucsi_send_command(ucsi, val, NULL, 0);
 		break;
 	case UCSI_GET_CAPABILITY:
@@ -80,6 +81,33 @@ static int ucsi_resp_show(struct seq_file *s, void *not_used)
 }
 DEFINE_SHOW_ATTRIBUTE(ucsi_resp);
 
+static int ucsi_peak_curr_show(struct seq_file *m, void *v)
+{
+	struct ucsi *ucsi = m->private;
+
+	seq_printf(m, "%u mA\n", ucsi->connector->peak_current);
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(ucsi_peak_curr);
+
+static int ucsi_avg_curr_show(struct seq_file *m, void *v)
+{
+	struct ucsi *ucsi = m->private;
+
+	seq_printf(m, "%u mA\n", ucsi->connector->avg_current);
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(ucsi_avg_curr);
+
+static int ucsi_vbus_volt_show(struct seq_file *m, void *v)
+{
+	struct ucsi *ucsi = m->private;
+
+	seq_printf(m, "%u mV\n", ucsi->connector->vbus_voltage);
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(ucsi_vbus_volt);
+
 void ucsi_debugfs_register(struct ucsi *ucsi)
 {
 	ucsi->debugfs = kzalloc(sizeof(*ucsi->debugfs), GFP_KERNEL);
@@ -89,6 +117,9 @@ void ucsi_debugfs_register(struct ucsi *ucsi)
 	ucsi->debugfs->dentry = debugfs_create_dir(dev_name(ucsi->dev), ucsi_debugfs_root);
 	debugfs_create_file("command", 0200, ucsi->debugfs->dentry, ucsi, &ucsi_cmd_fops);
 	debugfs_create_file("response", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_resp_fops);
+	debugfs_create_file("peak_current", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_peak_curr_fops);
+	debugfs_create_file("avg_current", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_avg_curr_fops);
+	debugfs_create_file("vbus_voltage", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_vbus_volt_fops);
 }
 
 void ucsi_debugfs_unregister(struct ucsi *ucsi)
diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
index 5739ea2abdd1..0d6b0cf5a7cd 100644
--- a/drivers/usb/typec/ucsi/ucsi.c
+++ b/drivers/usb/typec/ucsi/ucsi.c
@@ -1217,9 +1217,11 @@ static void ucsi_handle_connector_change(struct work_struct *work)
 	struct ucsi_connector *con = container_of(work, struct ucsi_connector,
 						  work);
 	struct ucsi *ucsi = con->ucsi;
+	u8 curr_scale, volt_scale;
 	enum typec_role role;
 	u16 change;
 	int ret;
+	u32 val;
 
 	mutex_lock(&con->lock);
 
@@ -1291,6 +1293,20 @@ static void ucsi_handle_connector_change(struct work_struct *work)
 	if (change & UCSI_CONSTAT_BC_CHANGE)
 		ucsi_port_psy_changed(con);
 
+	if (UCSI_CONSTAT(con, PWR_READING_READY_V2_1)) {
+		curr_scale = UCSI_CONSTAT(con, CURRENT_SCALE_V2_1);
+		volt_scale = UCSI_CONSTAT(con, VOLTAGE_SCALE_V2_1);
+
+		val = UCSI_CONSTAT(con, PEAK_CURRENT_V2_1);
+		con->peak_current = UCSI_CONSTAT_CURR_SCALE_MULT * curr_scale * val;
+
+		val = UCSI_CONSTAT(con, AVG_CURRENT_V2_1);
+		con->avg_current = UCSI_CONSTAT_CURR_SCALE_MULT * curr_scale * val;
+
+		val = UCSI_CONSTAT(con, VBUS_VOLTAGE_V2_1);
+		con->vbus_voltage = UCSI_CONSTAT_VOLT_SCALE_MULT * volt_scale * val;
+	}
+
 out_unlock:
 	mutex_unlock(&con->lock);
 }
diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
index ebd7c27c2cc7..e301d9012936 100644
--- a/drivers/usb/typec/ucsi/ucsi.h
+++ b/drivers/usb/typec/ucsi/ucsi.h
@@ -131,6 +131,7 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);
 #define UCSI_GET_PD_MESSAGE			0x15
 #define UCSI_GET_CAM_CS			0x18
 #define UCSI_SET_SINK_PATH			0x1c
+#define UCSI_READ_POWER_LEVEL			0x1e
 #define UCSI_SET_USB				0x21
 #define UCSI_GET_LPM_PPM_INFO			0x22
 
@@ -359,6 +360,14 @@ struct ucsi_cable_property {
 #define   UCSI_CONSTAT_BC_SLOW_CHARGING		2
 #define   UCSI_CONSTAT_BC_TRICKLE_CHARGING	3
 #define UCSI_CONSTAT_PD_VERSION_V1_2		UCSI_DECLARE_BITFIELD_V1_2(70, 16)
+#define UCSI_CONSTAT_PWR_READING_READY_V2_1	UCSI_DECLARE_BITFIELD_V2_1(89, 1)
+#define UCSI_CONSTAT_CURRENT_SCALE_V2_1		UCSI_DECLARE_BITFIELD_V2_1(90, 3)
+#define UCSI_CONSTAT_PEAK_CURRENT_V2_1		UCSI_DECLARE_BITFIELD_V2_1(93, 16)
+#define UCSI_CONSTAT_AVG_CURRENT_V2_1		UCSI_DECLARE_BITFIELD_V2_1(109, 16)
+#define UCSI_CONSTAT_VOLTAGE_SCALE_V2_1		UCSI_DECLARE_BITFIELD_V2_1(125, 4)
+#define UCSI_CONSTAT_VBUS_VOLTAGE_V2_1		UCSI_DECLARE_BITFIELD_V2_1(129, 16)
+#define UCSI_CONSTAT_CURR_SCALE_MULT		5
+#define UCSI_CONSTAT_VOLT_SCALE_MULT		5
 
 /* Connector Status Change Bits.  */
 #define UCSI_CONSTAT_EXT_SUPPLY_CHANGE		BIT(1)
@@ -519,6 +528,10 @@ struct ucsi_connector {
 	u32 src_pdos[PDO_MAX_OBJECTS];
 	int num_pdos;
 
+	u32 peak_current;
+	u32 avg_current;
+	u32 vbus_voltage;
+
 	/* USB PD objects */
 	struct usb_power_delivery *pd;
 	struct usb_power_delivery_capabilities *port_source_caps;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command
  2025-08-14 16:30 [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command Venkat Jayaraman
@ 2025-08-19  9:47 ` Neil Armstrong
  2025-08-21  7:21   ` Heikki Krogerus
  0 siblings, 1 reply; 5+ messages in thread
From: Neil Armstrong @ 2025-08-19  9:47 UTC (permalink / raw)
  To: Venkat Jayaraman, linux-usb
  Cc: gregkh, heikki.krogerus, pse.type-c.linux, linux-arm-msm

Hi,

On 14/08/2025 18:30, Venkat Jayaraman wrote:
> Add support for UCSI READ_POWER_LEVEL command as per
> UCSI specification v2.1 and above to debugfs.
> 
> Following power related fields will be exposed as files in debugfs:-
> peak_current (Peak current),
> avg_current (Average current) and
> vbus_voltage (VBUS voltage)
> 
> These files will be updated either when a READ_POWER_LEVEL
> command is sent from OS or when a device is connected.
> 
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Venkat Jayaraman <venkat.jayaraman@intel.com>
> ---
> Changelog v3:
> - Rebased to kernel 6.17-rc1
> 
> Changelog v2:
> - Removed extra space in declaration
> - Made the call to debugfs_create_file single line for clarity
> 
>   drivers/usb/typec/ucsi/debugfs.c | 31 +++++++++++++++++++++++++++++++
>   drivers/usb/typec/ucsi/ucsi.c    | 16 ++++++++++++++++
>   drivers/usb/typec/ucsi/ucsi.h    | 13 +++++++++++++
>   3 files changed, 60 insertions(+)
> 

This commit causes the following warning:
[    8.646179] ------------[ cut here ]------------
[    8.650986] Access to unsupported field at offset 0x59 (need version 0210)
[    8.651044] WARNING: drivers/usb/typec/ucsi/ucsi.c:1296 at ucsi_handle_connector_change+0x380/0x414 [typec_ucsi], CPU#0: kworker/0:0/9
<snip>
[    8.832491] Hardware name: Qualcomm Technologies, Inc. SM8550 HDK (DT)
[    8.839228] Workqueue: events ucsi_handle_connector_change [typec_ucsi]
[    8.846084] pstate: 63400005 (nZCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--)
[    8.853277] pc : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
[    8.860031] lr : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
<snip>
[    8.944023] Call trace:
[    8.946570]  ucsi_handle_connector_change+0x380/0x414 [typec_ucsi] (P)
[    8.953328]  process_one_work+0x148/0x28c
[    8.957502]  worker_thread+0x2c8/0x3d0
[    8.961401]  kthread+0x12c/0x204
[    8.964759]  ret_from_fork+0x10/0x20
[    8.968474] ---[ end trace 0000000000000000 ]---

on:
8550-hdk:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253312#L1418
8550-qrd:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253306#L1560
8650-hdk:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253308#L1494
8650-qrd:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253309#L1594
x1-crd:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253311#L2226
x1-qcp:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253310#L2160

I guess the version should be checked.

Neil

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command
  2025-08-19  9:47 ` Neil Armstrong
@ 2025-08-21  7:21   ` Heikki Krogerus
  2025-09-01  7:49     ` Neil Armstrong
  0 siblings, 1 reply; 5+ messages in thread
From: Heikki Krogerus @ 2025-08-21  7:21 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Venkat Jayaraman, linux-usb, gregkh, pse.type-c.linux,
	linux-arm-msm

On Tue, Aug 19, 2025 at 11:47:58AM +0200, Neil Armstrong wrote:
> Hi,
> 
> On 14/08/2025 18:30, Venkat Jayaraman wrote:
> > Add support for UCSI READ_POWER_LEVEL command as per
> > UCSI specification v2.1 and above to debugfs.
> > 
> > Following power related fields will be exposed as files in debugfs:-
> > peak_current (Peak current),
> > avg_current (Average current) and
> > vbus_voltage (VBUS voltage)
> > 
> > These files will be updated either when a READ_POWER_LEVEL
> > command is sent from OS or when a device is connected.
> > 
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Signed-off-by: Venkat Jayaraman <venkat.jayaraman@intel.com>
> > ---
> > Changelog v3:
> > - Rebased to kernel 6.17-rc1
> > 
> > Changelog v2:
> > - Removed extra space in declaration
> > - Made the call to debugfs_create_file single line for clarity
> > 
> >   drivers/usb/typec/ucsi/debugfs.c | 31 +++++++++++++++++++++++++++++++
> >   drivers/usb/typec/ucsi/ucsi.c    | 16 ++++++++++++++++
> >   drivers/usb/typec/ucsi/ucsi.h    | 13 +++++++++++++
> >   3 files changed, 60 insertions(+)
> > 
> 
> This commit causes the following warning:
> [    8.646179] ------------[ cut here ]------------
> [    8.650986] Access to unsupported field at offset 0x59 (need version 0210)
> [    8.651044] WARNING: drivers/usb/typec/ucsi/ucsi.c:1296 at ucsi_handle_connector_change+0x380/0x414 [typec_ucsi], CPU#0: kworker/0:0/9
> <snip>
> [    8.832491] Hardware name: Qualcomm Technologies, Inc. SM8550 HDK (DT)
> [    8.839228] Workqueue: events ucsi_handle_connector_change [typec_ucsi]
> [    8.846084] pstate: 63400005 (nZCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--)
> [    8.853277] pc : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
> [    8.860031] lr : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
> <snip>
> [    8.944023] Call trace:
> [    8.946570]  ucsi_handle_connector_change+0x380/0x414 [typec_ucsi] (P)
> [    8.953328]  process_one_work+0x148/0x28c
> [    8.957502]  worker_thread+0x2c8/0x3d0
> [    8.961401]  kthread+0x12c/0x204
> [    8.964759]  ret_from_fork+0x10/0x20
> [    8.968474] ---[ end trace 0000000000000000 ]---
> 
> on:
> 8550-hdk:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253312#L1418
> 8550-qrd:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253306#L1560
> 8650-hdk:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253308#L1494
> 8650-qrd:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253309#L1594
> x1-crd:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253311#L2226
> x1-qcp:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253310#L2160
> 
> I guess the version should be checked.

Venkat, can you be prepare the fix for this?

thanks,

-- 
heikki

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command
  2025-08-21  7:21   ` Heikki Krogerus
@ 2025-09-01  7:49     ` Neil Armstrong
  2025-09-02  1:59       ` Jayaraman, Venkat
  0 siblings, 1 reply; 5+ messages in thread
From: Neil Armstrong @ 2025-09-01  7:49 UTC (permalink / raw)
  To: Heikki Krogerus
  Cc: Venkat Jayaraman, linux-usb, gregkh, pse.type-c.linux,
	linux-arm-msm

Hi,

On 21/08/2025 09:21, Heikki Krogerus wrote:
> On Tue, Aug 19, 2025 at 11:47:58AM +0200, Neil Armstrong wrote:
>> Hi,
>>
>> On 14/08/2025 18:30, Venkat Jayaraman wrote:
>>> Add support for UCSI READ_POWER_LEVEL command as per
>>> UCSI specification v2.1 and above to debugfs.
>>>
>>> Following power related fields will be exposed as files in debugfs:-
>>> peak_current (Peak current),
>>> avg_current (Average current) and
>>> vbus_voltage (VBUS voltage)
>>>
>>> These files will be updated either when a READ_POWER_LEVEL
>>> command is sent from OS or when a device is connected.
>>>
>>> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>>> Signed-off-by: Venkat Jayaraman <venkat.jayaraman@intel.com>
>>> ---
>>> Changelog v3:
>>> - Rebased to kernel 6.17-rc1
>>>
>>> Changelog v2:
>>> - Removed extra space in declaration
>>> - Made the call to debugfs_create_file single line for clarity
>>>
>>>    drivers/usb/typec/ucsi/debugfs.c | 31 +++++++++++++++++++++++++++++++
>>>    drivers/usb/typec/ucsi/ucsi.c    | 16 ++++++++++++++++
>>>    drivers/usb/typec/ucsi/ucsi.h    | 13 +++++++++++++
>>>    3 files changed, 60 insertions(+)
>>>
>>
>> This commit causes the following warning:
>> [    8.646179] ------------[ cut here ]------------
>> [    8.650986] Access to unsupported field at offset 0x59 (need version 0210)
>> [    8.651044] WARNING: drivers/usb/typec/ucsi/ucsi.c:1296 at ucsi_handle_connector_change+0x380/0x414 [typec_ucsi], CPU#0: kworker/0:0/9
>> <snip>
>> [    8.832491] Hardware name: Qualcomm Technologies, Inc. SM8550 HDK (DT)
>> [    8.839228] Workqueue: events ucsi_handle_connector_change [typec_ucsi]
>> [    8.846084] pstate: 63400005 (nZCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--)
>> [    8.853277] pc : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
>> [    8.860031] lr : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
>> <snip>
>> [    8.944023] Call trace:
>> [    8.946570]  ucsi_handle_connector_change+0x380/0x414 [typec_ucsi] (P)
>> [    8.953328]  process_one_work+0x148/0x28c
>> [    8.957502]  worker_thread+0x2c8/0x3d0
>> [    8.961401]  kthread+0x12c/0x204
>> [    8.964759]  ret_from_fork+0x10/0x20
>> [    8.968474] ---[ end trace 0000000000000000 ]---
>>
>> on:
>> 8550-hdk:
>> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253312#L1418
>> 8550-qrd:
>> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253306#L1560
>> 8650-hdk:
>> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253308#L1494
>> 8650-qrd:
>> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253309#L1594
>> x1-crd:
>> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253311#L2226
>> x1-qcp:
>> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253310#L2160
>>
>> I guess the version should be checked.
> 
> Venkat, can you be prepare the fix for this?
> 
> thanks,
> 

Gentle ping, can this be fixed ? Should I send a revert patch ?

Neil


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command
  2025-09-01  7:49     ` Neil Armstrong
@ 2025-09-02  1:59       ` Jayaraman, Venkat
  0 siblings, 0 replies; 5+ messages in thread
From: Jayaraman, Venkat @ 2025-09-02  1:59 UTC (permalink / raw)
  To: Neil Armstrong, Heikki Krogerus
  Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
	PSE Type-C Linux, linux-arm-msm

Yes, the fix patch is coming in the next day or two. Thanks.

> -----Original Message-----
> From: Neil Armstrong <neil.armstrong@linaro.org>
> Sent: Monday, September 1, 2025 12:50 AM
> To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Jayaraman, Venkat <venkat.jayaraman@intel.com>; linux-usb@vger.kernel.org; gregkh@linuxfoundation.org; PSE Type-C Linux
> <pse.type-c.linux@intel.com>; linux-arm-msm <linux-arm-msm@vger.kernel.org>
> Subject: Re: [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command
> 
> Hi,
> 
> On 21/08/2025 09:21, Heikki Krogerus wrote:
> > On Tue, Aug 19, 2025 at 11:47:58AM +0200, Neil Armstrong wrote:
> >> Hi,
> >>
> >> On 14/08/2025 18:30, Venkat Jayaraman wrote:
> >>> Add support for UCSI READ_POWER_LEVEL command as per
> >>> UCSI specification v2.1 and above to debugfs.
> >>>
> >>> Following power related fields will be exposed as files in debugfs:-
> >>> peak_current (Peak current),
> >>> avg_current (Average current) and
> >>> vbus_voltage (VBUS voltage)
> >>>
> >>> These files will be updated either when a READ_POWER_LEVEL
> >>> command is sent from OS or when a device is connected.
> >>>
> >>> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >>> Signed-off-by: Venkat Jayaraman <venkat.jayaraman@intel.com>
> >>> ---
> >>> Changelog v3:
> >>> - Rebased to kernel 6.17-rc1
> >>>
> >>> Changelog v2:
> >>> - Removed extra space in declaration
> >>> - Made the call to debugfs_create_file single line for clarity
> >>>
> >>>    drivers/usb/typec/ucsi/debugfs.c | 31 +++++++++++++++++++++++++++++++
> >>>    drivers/usb/typec/ucsi/ucsi.c    | 16 ++++++++++++++++
> >>>    drivers/usb/typec/ucsi/ucsi.h    | 13 +++++++++++++
> >>>    3 files changed, 60 insertions(+)
> >>>
> >>
> >> This commit causes the following warning:
> >> [    8.646179] ------------[ cut here ]------------
> >> [    8.650986] Access to unsupported field at offset 0x59 (need version 0210)
> >> [    8.651044] WARNING: drivers/usb/typec/ucsi/ucsi.c:1296 at ucsi_handle_connector_change+0x380/0x414 [typec_ucsi], CPU#0:
> kworker/0:0/9
> >> <snip>
> >> [    8.832491] Hardware name: Qualcomm Technologies, Inc. SM8550 HDK (DT)
> >> [    8.839228] Workqueue: events ucsi_handle_connector_change [typec_ucsi]
> >> [    8.846084] pstate: 63400005 (nZCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--)
> >> [    8.853277] pc : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
> >> [    8.860031] lr : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
> >> <snip>
> >> [    8.944023] Call trace:
> >> [    8.946570]  ucsi_handle_connector_change+0x380/0x414 [typec_ucsi] (P)
> >> [    8.953328]  process_one_work+0x148/0x28c
> >> [    8.957502]  worker_thread+0x2c8/0x3d0
> >> [    8.961401]  kthread+0x12c/0x204
> >> [    8.964759]  ret_from_fork+0x10/0x20
> >> [    8.968474] ---[ end trace 0000000000000000 ]---
> >>
> >> on:
> >> 8550-hdk:
> >> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253312#L1418
> >> 8550-qrd:
> >> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253306#L1560
> >> 8650-hdk:
> >> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253308#L1494
> >> 8650-qrd:
> >> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253309#L1594
> >> x1-crd:
> >> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253311#L2226
> >> x1-qcp:
> >> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253310#L2160
> >>
> >> I guess the version should be checked.
> >
> > Venkat, can you be prepare the fix for this?
> >
> > thanks,
> >
> 
> Gentle ping, can this be fixed ? Should I send a revert patch ?
> 
> Neil


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-02  1:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-14 16:30 [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command Venkat Jayaraman
2025-08-19  9:47 ` Neil Armstrong
2025-08-21  7:21   ` Heikki Krogerus
2025-09-01  7:49     ` Neil Armstrong
2025-09-02  1:59       ` Jayaraman, Venkat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).