Re: [PATCH v4 4/4] usb: typec: ucsi: Add support for SET_PDOS command

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Tue, Sep 09, 2025 at 06:52:07PM -0700, Pooja Katiyar wrote:
> Add support for UCSI SET_PDOS command as per UCSI specification
> v2.1 and above to debugfs.
> 
> Signed-off-by: Pooja Katiyar <pooja.katiyar@intel.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> Changelog v4:
> - Fixed build errors reported by kernel test robot.
> - Added changelogs.
> 
> Changelog v3:
> - No changes.
> 
> Changelog v2:
> - Send message_out data as part of ucsi_send_command.
> 
>  drivers/usb/typec/ucsi/debugfs.c | 1 +
>  drivers/usb/typec/ucsi/ucsi.h    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/debugfs.c b/drivers/usb/typec/ucsi/debugfs.c
> index 0693acf04c37..63a5fe791a82 100644
> --- a/drivers/usb/typec/ucsi/debugfs.c
> +++ b/drivers/usb/typec/ucsi/debugfs.c
> @@ -36,6 +36,7 @@ static int ucsi_cmd(void *data, u64 val)
>  	case UCSI_SET_NEW_CAM:
>  	case UCSI_SET_USB:
>  	case UCSI_READ_POWER_LEVEL:
> +	case UCSI_SET_PDOS:
>  		ucsi->message_in_size = 0;
>  		ret = ucsi_send_command(ucsi, val);
>  		break;
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index e6ca70f7fa1f..bdbaaeb1d925 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -136,6 +136,7 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);
>  #define UCSI_GET_PD_MESSAGE			0x15
>  #define UCSI_GET_CAM_CS			0x18
>  #define UCSI_SET_SINK_PATH			0x1c
> +#define UCSI_SET_PDOS				0x1d
>  #define UCSI_READ_POWER_LEVEL			0x1e
>  #define UCSI_SET_USB				0x21
>  #define UCSI_GET_LPM_PPM_INFO			0x22
> -- 
> 2.43.0

-- 
heikki