From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011001.outbound.protection.outlook.com [40.107.130.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D1151FBEA2; Tue, 16 Sep 2025 15:46:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.1 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758037581; cv=fail; b=t8uo/XnHzD51sXnMQiZ6OZ4cPfu1GPuerJZXbD7krJZirWoT82l2yCn4HZBdM8Z+ESU5ndZLBHMbYq2BJMQvogJlH1p2VJcfa2NlB9/g6MnlBmWiDIrqzSi2dOFqwhF82BXVrubUrfPO4uuT3+zDuDhgjVYZSTT2IhcgI1OBTq4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758037581; c=relaxed/simple; bh=erBCDtsaW2PaBNI8zufX7HTbn3Urap0UgEc1NN2/uKs=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=cCR9Ban1T+p9RIqMlMeh3gLCxJkrz/tChClSqYp1Adx/bfOc3eRrpt8TK2lyyFMlLEDpw+CifDSGrmHpPXw9FOiYGazshVPyZzspps0ynm363z3+NePnAIpXPLSEwuG0Wlj06JMBpvaPBkEFqw/nV1rVfjzyjHCLAuQqVUGzM6Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Kp0cfW5l; arc=fail smtp.client-ip=40.107.130.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Kp0cfW5l" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U1nPChOOPj44CcvdwjTQWLlNTYJpTVIt+CTQZ3GZJNDwz2RQe3VYLyhxCtssipJg86lX7StIYFR6RLUka+NUDF96x5mVSxxXYcFjFuqUKqwmhU+3XgazfKEhxmILPATaysjyrzR4M0vIsfCKn7+udEFlZ0EVvnboxI/yr35nfjlToNkF3lqUFw0kvS4/bWBaxwVEqXFpPIZwaFnS8VISNgzylFXmAUenal31r+P8E2BtQkSP1g9OvoYNwMVOij0Ps/+LAsvNFwnxT+t/LJeL5xWTVaodKeLCGaDSfLX3oqkeaCDmgF6bFV470+kzeYsJxPcPhG2U5xZ2hghp39Cx2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yaALLyC1ugR/Foi5tdl5wZjJ1XN9H8cQh83oSTPsSjo=; b=hoSz4QueCZHCyLf3ui5+x64fnqI/5r18GTdfpUKXY10kmvD7p20fB6iZRwdRRcdJ1srrV2KeZckZeOZnV0jczRL0ZxIJhI3y2iV8GO62ryfumw/HzDyw5GueJeu2o+dB0/xVdGDFHOKHny5rP0J94q3M3us/PERYHl9iFNnLB7DdUDSziMimCnBAAi3F9fOVAsHcqbchFzO44XfbWbs75AkSsoWmXyUtsWzvJH82zFe8k8CMQ75+m81QzEjfi88zvkmyUfA29Q1rMNGQyBKYIPZYHeMuFCyU8VvN8dkeNdm4HEvMo3Fj1hT6XiFLVtKFQyCPVmo4k1IoEc3VDwrjVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yaALLyC1ugR/Foi5tdl5wZjJ1XN9H8cQh83oSTPsSjo=; b=Kp0cfW5lq8P5U9mZ4nG63FYOn/RAhGeHmLUxpiptru19wE0s3lbGiBw/Dn/Lp/tlqjk7oSUpfBvG0tmMLwo7foPRAnY9Z2hOMFBEW1mlTvK0GC/qVXv+M9ajqoEouNojnu5DUXdkPYogMOLnvHQbHuRGccuMSZDKnd/OIeQ00nk7OguqpnLy+ybxDtjd1kyUhc3d/gtI20uV4PEqqpy2ornjXveDeLJXGCFM5cUHjZvkOVry5W7AYfogYlYUWg9F49dk9tXAXuoBqo7cbQgOucTt+Pmv9Tmd2wHou52SUUDT8YD5PbWLOseWridbV8NxpiQM2NMDmfHL7JhAXWpXCg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS4PR04MB9621.eurprd04.prod.outlook.com (2603:10a6:20b:4ff::22) by AS8PR04MB8578.eurprd04.prod.outlook.com (2603:10a6:20b:425::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.12; Tue, 16 Sep 2025 15:46:14 +0000 Received: from AS4PR04MB9621.eurprd04.prod.outlook.com ([fe80::a84d:82bf:a9ff:171e]) by AS4PR04MB9621.eurprd04.prod.outlook.com ([fe80::a84d:82bf:a9ff:171e%4]) with mapi id 15.20.9137.010; Tue, 16 Sep 2025 15:46:14 +0000 Date: Tue, 16 Sep 2025 11:46:06 -0400 From: Frank Li To: Xu Yang Cc: gregkh@linuxfoundation.org, tglx@linutronix.de, mingo@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, jun.li@nxp.com Subject: Re: [PATCH v2] usb: gadget: zero: add function wakeup support Message-ID: References: <20250916020544.1301866-1-xu.yang_2@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250916020544.1301866-1-xu.yang_2@nxp.com> X-ClientProxiedBy: BY5PR17CA0026.namprd17.prod.outlook.com (2603:10b6:a03:1b8::39) To AS4PR04MB9621.eurprd04.prod.outlook.com (2603:10a6:20b:4ff::22) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR04MB9621:EE_|AS8PR04MB8578:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bc6bca6-d4f9-4fb1-8e9e-08ddf5382a7a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|366016|376014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nFp8CxNs+dolGraKX9BVl7SjP+d/2zvaNof7eTefbxMSrKq0gNtUVcAZlrVg?= =?us-ascii?Q?Ae9QoS9BweUYNul8L+NcaUAcxUbXkEaJBcXz6i82xOEugDzWgHOHYkHPKONO?= =?us-ascii?Q?5aXhj2qy1lmeKtv46Eaa40ltL2wTXHLI0Mc9A6uMMLEXzmHuLJXiScjpRDVk?= =?us-ascii?Q?uE3RjI3zqavCkC3s23j+oYPyF8J/iSUQxl5jr75Iu/rbO2riYGv+wH9x5g04?= =?us-ascii?Q?L3yMXso6U1IizYC8XoZ2snqVz+hOtyK/o1DLF4aDfZPm3h3MFD5WBdA4O4Qq?= =?us-ascii?Q?vCtP9toZ1tkpPIaZX8owsWi2tzYKQ0Rtz+wqK0qsFRtvUnE3HVKS7lOrdTFe?= =?us-ascii?Q?z+JGp60XwKxlv+WoNmpz7jEZZ1Z1ZFtzCW/CUccsU+PQTg2Uig1/fzcGxQno?= =?us-ascii?Q?MTzvo9KdTzJk4eFFdNMRVIEjfxSB7NNpCwiW1+za1UK30BqBDLjFHT1rBKnf?= =?us-ascii?Q?BLo/w8vRl0yZdb2zQMnVhltXiWBEq5kB7xyWwDjXJljhNs23PiGLyNKiMKbT?= =?us-ascii?Q?Bb56yfcqQj/sVptfHGcJAnDeb8xlMfiRmoLeYUFGs0EYuVC9qkhnevFYiKFC?= =?us-ascii?Q?590/MF0dsV53+W2Dkf9tw8MYAVjKpsz/6u/OIW/2njRLDrKjt8zbpDGg6Rf+?= =?us-ascii?Q?aDlNx5UeSVritkzYPDX5Cho/i+hzGieT3mByFYjk7pICHp+mpq/kVcAM+GIO?= =?us-ascii?Q?zXz92o9yLBru1jk5lE9Ctyk34LM/r/9o+1eGZasUVlC+fQvXWVkTl7zeSXr5?= =?us-ascii?Q?Gpuv+gEan+cALPcr0FtZEUMDd6RosPhPFq7tNrAdxPigAC7TC5ebARTzyzUj?= =?us-ascii?Q?k6j7XBkg9fOde36QuGr1cg8X6q4pZ40Qt5hrM1gfWrgEJUvYfCTj7F5dx4/d?= =?us-ascii?Q?VDLeotzX8cLaUA322AzxBc69Tm0EyinNLbseuAk8Q/wNS2JbocZYOVSniILm?= =?us-ascii?Q?a/P5PeirxZeIW5mgpk0bUizDSIXowpaomOlcU5XNgstMvlzSPsJCWhbLXhOV?= =?us-ascii?Q?LAzO8j/FvDi0AdsMhm4+fQjC9FbvQ80D2IRSyR3Nx4RluWGaSjs9xCDxjSec?= =?us-ascii?Q?Vfu/uOfu60zVUWwkuoZNvv+OO1sVme+jZ2Lm3uE8a06DjqMK5dh54bK5A7M9?= =?us-ascii?Q?KbLguCZ9mhS0HImC7UXzvrBD1NiXALGV7eW04TLYayCZVSQq6n6V6d4z9Gbe?= =?us-ascii?Q?u39qOl4lpFU8jELGpB5N3tY02OlpKxtbb7bXu5JWx7uJFWKwMp3a2gE6B1c1?= =?us-ascii?Q?hk8ymP0EoWNoM107XeQ/PGiT6viv3lBzzpDhT9QjOFWDUpxYoe+nLq4P4PTr?= =?us-ascii?Q?H0bAMzCdhVOWKSk1mMji2duMyyer3zYSfMNyU8ywC04QAfYuQ+tGJSqVW2EK?= =?us-ascii?Q?KbRykl3cLYWbWq5Z6nbFujwrg0A6VYUymc+tJ49vY9QAGtvacTq/VfcARKd8?= =?us-ascii?Q?5WdwujwghAG2vMLqAtznpuT86J11MuDRt0wHpS4/0YURw/Mp5iu6CDC6bQoo?= =?us-ascii?Q?fuP4eQCWsvuXVTY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR04MB9621.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(366016)(376014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6ohftw9rpKsCG6krb80FJXb5A2Giyid7tTUPD7jbL2y/83nVyhceNt9mjsq+?= =?us-ascii?Q?g+f3yKjEla1EBi+hPDsx2WPX3zdMdx5uD/vF36uCAlZquaxkEX6T9o8Ngq3F?= =?us-ascii?Q?vohoIOpjECzFwTirH9pvbOyqaZZdGw0b1QX86y6GKQ1lllfIV3VnA6amhcAx?= =?us-ascii?Q?nxsANzw7FlLYoTWiBUIU7TWnBZ+yfkqUstTaSko/KF0zaNk2K4DuxVlW8jou?= =?us-ascii?Q?D2fRa9oyLlIxOK+qXDiSNv8/RuH3x1pKnyuNdRrof5mJsXlmyLLoEwJg9H2p?= =?us-ascii?Q?zzJmkESUzYwgtCNA7Ssqmg48JVLizvoaRaieIt//ySDjO+ej8iPrB+jjutvU?= =?us-ascii?Q?pnevVHC7TfGUQWqQq/IZ8ke5dYp23hLcg+TRD7xrvCOqHQ0xLzwucfCN9QDM?= =?us-ascii?Q?ycIqgzPFzNdincdTjMZlp0EiW4xsI9TrsxRil81Bd7VCv3yGLLHJ8Zzawlkl?= =?us-ascii?Q?3n5SNrM+f5Q17rcK9qlKNNRpjGWkfqQbnTu4OOUfFNktpJHPcTuxonp7Ol0Q?= =?us-ascii?Q?exzoN1ezwmN8Yrvq3aAm+gPatNDiZzdLjoh82IbWsQca/yMx34Dsu8Qg1Sjl?= =?us-ascii?Q?jMd/SWMP+EZFAXByAlk+2S1d6WuwJj5W/9iCc8rWsUOhX5fGJQnI750UmS9E?= =?us-ascii?Q?ZOgdxz7WHJKt+42XSKf5gu0ddD4c+eJ1rvThIqsnpE5OHAOE5JjtrOQKexiI?= =?us-ascii?Q?LrGapsc6ZjL9xYw4QMKs+UL7AInvQ9jpjdESBVwzgQHqHfkBKcViwTkabcYA?= =?us-ascii?Q?jrEecMw4Ol1tTSgUCXNDuXsPQlRpd3/IR0C4m/bEnh+OrvZ1fZ3ZGZCJYGqV?= =?us-ascii?Q?E0AgOo3zMopf5RLIevyLYw5r9eTK3OW8ZgpNFmO5pPXqOWZO2w1HWEG5ELMx?= =?us-ascii?Q?GYozQP2OZ8j1P1yYuaGked2Vi/CEDYdZVBomJS3+yeM4mgnfZL3HqQGtAPFP?= =?us-ascii?Q?TRqqR7JB3wV783/yFzWs1yg7h9nqDYyTMsYk8BPMXdZdvabIZUkHC1RyK0pX?= =?us-ascii?Q?niTtFbVH1DjK1VIqxp2gSVfDvsDc1BFiwRBdLVk8gmGRrNc0CtP59CLwv1l2?= =?us-ascii?Q?UbhUoeQJu3hDp7RmoTm1xi2jzo+PlHWw+EhWZdlyg+/5h1AtvO/jQYv6MNO7?= =?us-ascii?Q?CdoZ5Sxye1BkoIohQrpgBMvKZVGoAO33iAqg56CUZxy7T9BF9MzGEHEWaye8?= =?us-ascii?Q?+JNYJAtFXBdExWh5jfgCmbDIhJ2WnPrwOZ1B0ePdJLn0h3rfDPfTRnimp0Vn?= =?us-ascii?Q?Ns3zzhkFghSKWJ37NVN4w6+CCazPWhGV+OgHhikIIG/6RppLQPR6w59pa5Z3?= =?us-ascii?Q?C5yL/n6LLQ6BkSd2c8nNf2ad3dfw4Merfg/RTBRzGgr++42ZJEmq0nr4QrtT?= =?us-ascii?Q?zJ7CNFxlgYSW8eT7rvrwQe9ehHWo7JofpwtdQjmATV1CVDChtXuV/cQEwQbM?= =?us-ascii?Q?aKy5oKFkGcYI47r+V7V4aLPJpg/lG1Sfr7VDHiBbo1UHJI3cDvLZWQdaMMLn?= =?us-ascii?Q?V5pLUdvLuoydmTY5xPAqVspyLV7o73U1yaBzsmn5gkdCCxQht4wDtPvGgFSy?= =?us-ascii?Q?uzMnvZo6ve068cnnR9tzm6Ba6M6WbTS5avs/Ecg/?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bc6bca6-d4f9-4fb1-8e9e-08ddf5382a7a X-MS-Exchange-CrossTenant-AuthSource: AS4PR04MB9621.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2025 15:46:14.5130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NUXES0SaR+WJoA67X/SFA1Gi0x4ndIET4UOk9U9W3AWsiqkSgNvCDj/UgRH4PVxRzg80SwVx/dc0rfE7hMk0PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8578 On Tue, Sep 16, 2025 at 10:05:44AM +0800, Xu Yang wrote: > When the device working at enhanced superspeed, it needs to send function > remote wakeup signal to the host instead of device remote wakeup. Add > function wakeup support for the purpose. > > Signed-off-by: Xu Yang Reviewed-by: Frank Li > > --- > Changes in v2: > - fix alignment > --- > drivers/usb/gadget/legacy/zero.c | 27 ++++++++++++++++++--------- > 1 file changed, 18 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/gadget/legacy/zero.c b/drivers/usb/gadget/legacy/zero.c > index a05785bdeb30..08a21bd0c2ba 100644 > --- a/drivers/usb/gadget/legacy/zero.c > +++ b/drivers/usb/gadget/legacy/zero.c > @@ -147,6 +147,12 @@ static struct usb_gadget_strings *dev_strings[] = { > NULL, > }; > > +static struct usb_function *func_lb; > +static struct usb_function_instance *func_inst_lb; > + > +static struct usb_function *func_ss; > +static struct usb_function_instance *func_inst_ss; > + > /*-------------------------------------------------------------------------*/ > > static struct timer_list autoresume_timer; > @@ -156,6 +162,7 @@ static void zero_autoresume(struct timer_list *unused) > { > struct usb_composite_dev *cdev = autoresume_cdev; > struct usb_gadget *g = cdev->gadget; > + int status; > > /* unconfigured devices can't issue wakeups */ > if (!cdev->config) > @@ -165,10 +172,18 @@ static void zero_autoresume(struct timer_list *unused) > * more significant than just a timer firing; likely > * because of some direct user request. > */ > - if (g->speed != USB_SPEED_UNKNOWN) { > - int status = usb_gadget_wakeup(g); > - INFO(cdev, "%s --> %d\n", __func__, status); > + if (g->speed == USB_SPEED_UNKNOWN) > + return; > + > + if (g->speed >= USB_SPEED_SUPER) { > + if (loopdefault) > + status = usb_func_wakeup(func_lb); > + else > + status = usb_func_wakeup(func_ss); > + } else { > + status = usb_gadget_wakeup(g); > } > + INFO(cdev, "%s --> %d\n", __func__, status); > } > > static void zero_suspend(struct usb_composite_dev *cdev) > @@ -206,9 +221,6 @@ static struct usb_configuration loopback_driver = { > /* .iConfiguration = DYNAMIC */ > }; > > -static struct usb_function *func_ss; > -static struct usb_function_instance *func_inst_ss; > - > static int ss_config_setup(struct usb_configuration *c, > const struct usb_ctrlrequest *ctrl) > { > @@ -248,9 +260,6 @@ module_param_named(isoc_maxburst, gzero_options.isoc_maxburst, uint, > S_IRUGO|S_IWUSR); > MODULE_PARM_DESC(isoc_maxburst, "0 - 15 (ss only)"); > > -static struct usb_function *func_lb; > -static struct usb_function_instance *func_inst_lb; > - > module_param_named(qlen, gzero_options.qlen, uint, S_IRUGO|S_IWUSR); > MODULE_PARM_DESC(qlen, "depth of loopback queue"); > > -- > 2.34.1 >