From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846BE2765E2 for ; Tue, 7 Oct 2025 23:52:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759881160; cv=none; b=DbCj7uThokYgekgeXAjXzqracs2GiS1DHw5PVb5hMkQy4W1p/Q1QWTJkLrxAx8m8bcyGNudSKrVpUvPSxz9/wLajvkJuB7rcu20H1thUUqNaBzl86nmCDe3jIUMA8fSVVKa2FhefFiezKEc5JbwyYID+A/E7fJ5AG2IIFJj91Zc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759881160; c=relaxed/simple; bh=ROKWiGHnPPZZuzWKSI1uklaF8ixeRvtjKDd9kS9OjSM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NJFIDrKqkxL+CZnkA9uksfmVylpH5n7NRVkKm+BjNnrXlAwATd3fBe1wauTQDk9Y3kmtyE/fBEFFcXbdpCAB6d/f2gLdbfKB8N28cXjwIzTw7yYGgoQ4/J0fIEKOhZxkSHuiBJRvKCgr/j3KpuznruGzXUG9OWLjCmcy+K2BOxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eud1QblD; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eud1QblD" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-b4755f37c3eso5962040a12.3 for ; Tue, 07 Oct 2025 16:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759881158; x=1760485958; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EV0jNBd+78rpPCRxrDmQHJY6Y0YsbxaPHZL4vUaqMjk=; b=eud1QblD5KXefKNmiueAcNVunpDqgNzFpQ+yRtfHVAWUl8Z50NkmygNch1DJR77L/1 4fdLi7xcpp/M5f+D5ikZahtS+B636lqgFno59jtYt1h8vSPiX5kw/3MUfXh9qeClp5LN vJMzdt2fkGGkI2edo1IALip+5j/Q4kbIq/vCl8f/C4BmtmkdM1EwR1Cc0WyCw8RsPUIe otGHx/WXUSKX3qQFIR/hWk47yosZBUkaOxvWa5msQoWv3MRV8YnSNNgnuRdGq2YtZxko LWWwBMVZO4zkRmEW4MBm1x8JLdcsK6UQ1FWK1puS87a/tGmBJ6UOJk+dYlg0NzwZKsav Yesg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759881158; x=1760485958; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EV0jNBd+78rpPCRxrDmQHJY6Y0YsbxaPHZL4vUaqMjk=; b=pwe3Y+Q0UQ5uWVLdiHaXnbElwJXBvBKPOlyriccCiQgceHBeBDynrVSKOHBc1RPib5 lgNddNIe4AMIYX6LTQf+JtChLH3bWId2rasv19idPZD7lsz5CaT2BhscmZ4JNmZUnqyc Rm0KN3Xrt3TVBM73Uo/1wSsrX8fShWmO96Ih/6T1XWp7fv8c0LGI7fjm1GEfxHo8nzw0 /IFgFI2Q5tD/ALoYHewCopBWkvLgpJVBJ/jPanqgr4C/Kus7flxqFdWZOOPUFX1gKXnb aJwW2Pm0KBc6QXN584KLpDqL3n47F7SbGf6MngETMKAzyulUtJERina4B4A7EG313Pqp 78YA== X-Forwarded-Encrypted: i=1; AJvYcCV4xdgdri6fDvNsFXJPhykbkO97qu4qLsRIzYmuIazVTGPqwCu91cryoEHq1Dmh5FoEvPJV20d3xhc=@vger.kernel.org X-Gm-Message-State: AOJu0YzDg+R8kFwPhb4/Ru+F8NT9w9mDoHd5Ynano4ohDrfm2Lh+BfL4 Qnf5xTimGdc/grQyuJ6QDt9Ap1Cp9BE2xBc5buQmpsIyG5mZVmKfjS+I/beLW51stA== X-Gm-Gg: ASbGnctzw/Rp67zq4PZXubg/OiPHbv0kLJF7CEhBusaAGYXzY+YL9GSbhx3RKsHG9w8 R97uN6RESLyNIFtvvqzFg5mU8rS/X6Zn8xlr7npxlotW23yX18JbKw5h3l4bq3GtTlstZ8cha6c yCLrNCI8BsuhiGSu8LHrPwtnd1hI9P7mQvCt98w9S79IZcvhjHl2qdXf3FblVROZ2aqFYicJrbz VR5oxJdC6l5jbyLi3fLdxnPsx7CFs8uct1a8wz/nqMBfMpAnnDDK4Lqd77w5AwOPWmi+Zw1rWwp Gf3nuCq8zE/Pdcfp5TYfQOV1MtVqmzvUJQLuMLPQuKk+wTTojBQN2is7pX9QTd/fmRQjmCUfeCO IyZkz2xfXHm665+YuAL0IvFFMMeroIwHp/a5yL0FLHrtlJT89gPfflmGpyzEnFiCxA7hCOAXfih +3D+wsjfisJFyNzkb20T6O X-Google-Smtp-Source: AGHT+IHGqfMRANz7qdKFPY1GP0G7VEmvv0tnHHdAojhTEJuBXFf5EupmTiYmDs83Yy0+ILJ3POIhcA== X-Received: by 2002:a17:903:247:b0:24c:ea17:e322 with SMTP id d9443c01a7336-29027356511mr19002275ad.3.1759881157519; Tue, 07 Oct 2025 16:52:37 -0700 (PDT) Received: from google.com (232.92.83.34.bc.googleusercontent.com. [34.83.92.232]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-28e8d1d24aesm178372845ad.118.2025.10.07.16.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 16:52:36 -0700 (PDT) Date: Tue, 7 Oct 2025 23:52:33 +0000 From: Benson Leung To: Jameson Thies Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dmitry.baryshkov@oss.qualcomm.com, bleung@chromium.org, gregkh@linuxfoundation.org, akuchynski@chromium.org, abhishekpandit@chromium.org, sebastian.reichel@collabora.com, linux-pm@vger.kernel.org Subject: Re: [PATCH 4/6] usb: typec: ucsi: Report power supply change on sink path change Message-ID: References: <20251007000007.3724229-1-jthies@google.com> <20251007000007.3724229-5-jthies@google.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Sxbt9OfvGJLK6C2i" Content-Disposition: inline In-Reply-To: <20251007000007.3724229-5-jthies@google.com> --Sxbt9OfvGJLK6C2i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 07, 2025 at 12:00:05AM +0000, Jameson Thies wrote: > Update the UCSI interface driver to report a power supply change when > the PPM sets the Sink Path Change bit. >=20 > Signed-off-by: Jameson Thies Reviewed-by: Benson Leung > --- > drivers/usb/typec/ucsi/ucsi.c | 2 +- > drivers/usb/typec/ucsi/ucsi.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c > index 7b718049d0d1..1a7d850b11ea 100644 > --- a/drivers/usb/typec/ucsi/ucsi.c > +++ b/drivers/usb/typec/ucsi/ucsi.c > @@ -1293,7 +1293,7 @@ static void ucsi_handle_connector_change(struct wor= k_struct *work) > if (change & UCSI_CONSTAT_CAM_CHANGE) > ucsi_partner_task(con, ucsi_check_altmodes, 1, HZ); > =20 > - if (change & UCSI_CONSTAT_BC_CHANGE) > + if (change & UCSI_CONSTAT_BC_CHANGE || change & UCSI_CONSTAT_SINK_PATH_= CHANGE) > ucsi_port_psy_changed(con); > =20 > if (con->ucsi->version >=3D UCSI_VERSION_2_1 && > diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h > index cce93af7461b..35993bc34d4d 100644 > --- a/drivers/usb/typec/ucsi/ucsi.h > +++ b/drivers/usb/typec/ucsi/ucsi.h > @@ -382,6 +382,7 @@ struct ucsi_cable_property { > #define UCSI_CONSTAT_BC_CHANGE BIT(9) > #define UCSI_CONSTAT_PARTNER_CHANGE BIT(11) > #define UCSI_CONSTAT_POWER_DIR_CHANGE BIT(12) > +#define UCSI_CONSTAT_SINK_PATH_CHANGE BIT(13) > #define UCSI_CONSTAT_CONNECT_CHANGE BIT(14) > #define UCSI_CONSTAT_ERROR BIT(15) > =20 > --=20 > 2.51.0.618.g983fd99d29-goog >=20 --Sxbt9OfvGJLK6C2i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCaOWnwAAKCRBzbaomhzOw wl1ZAQCuEVVyxljuR3qDCWaEQfsjePsmSuW7gR277le5YuGU/wD+LvAaG5c7C5EY YQkMRPfdTja02BZOOVpX3H+kaBwH3wU= =62iI -----END PGP SIGNATURE----- --Sxbt9OfvGJLK6C2i--