From: Benson Leung <bleung@google.com>
To: Jameson Thies <jthies@google.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, dmitry.baryshkov@oss.qualcomm.com,
bleung@chromium.org, gregkh@linuxfoundation.org,
akuchynski@chromium.org, abhishekpandit@chromium.org,
sebastian.reichel@collabora.com, kenny@panix.com,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 3/3] usb: typec: ucsi: Report power supply change on sink path change
Date: Fri, 17 Oct 2025 00:11:26 +0000 [thread overview]
Message-ID: <aPGJrjG6nsRQune_@google.com> (raw)
In-Reply-To: <20251016235909.2092917-4-jthies@google.com>
[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]
On Thu, Oct 16, 2025 at 11:59:09PM +0000, Jameson Thies wrote:
> Update the UCSI interface driver to report a power supply change when
> the PPM sets the Sink Path Change bit.
>
> Signed-off-by: Jameson Thies <jthies@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/usb/typec/ucsi/ucsi.c | 2 +-
> drivers/usb/typec/ucsi/ucsi.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 7b718049d0d1..cad3913bd7f9 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1293,7 +1293,7 @@ static void ucsi_handle_connector_change(struct work_struct *work)
> if (change & UCSI_CONSTAT_CAM_CHANGE)
> ucsi_partner_task(con, ucsi_check_altmodes, 1, HZ);
>
> - if (change & UCSI_CONSTAT_BC_CHANGE)
> + if (change & (UCSI_CONSTAT_BC_CHANGE | UCSI_CONSTAT_SINK_PATH_CHANGE))
> ucsi_port_psy_changed(con);
>
> if (con->ucsi->version >= UCSI_VERSION_2_1 &&
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index cce93af7461b..35993bc34d4d 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -382,6 +382,7 @@ struct ucsi_cable_property {
> #define UCSI_CONSTAT_BC_CHANGE BIT(9)
> #define UCSI_CONSTAT_PARTNER_CHANGE BIT(11)
> #define UCSI_CONSTAT_POWER_DIR_CHANGE BIT(12)
> +#define UCSI_CONSTAT_SINK_PATH_CHANGE BIT(13)
> #define UCSI_CONSTAT_CONNECT_CHANGE BIT(14)
> #define UCSI_CONSTAT_ERROR BIT(15)
>
> --
> 2.51.0.858.gf9c4a03a3a-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-10-17 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 23:59 [PATCH v2 0/3] UCSI Power Supply Updates Jameson Thies
2025-10-16 23:59 ` [PATCH v2 1/3] usb: typec: ucsi: psy: Add power supply status Jameson Thies
2025-10-17 0:09 ` Benson Leung
2025-10-16 23:59 ` [PATCH v2 2/3] usb: typec: ucsi: Report power supply changes on power opmode changes Jameson Thies
2025-10-16 23:59 ` [PATCH v2 3/3] usb: typec: ucsi: Report power supply change on sink path change Jameson Thies
2025-10-17 0:11 ` Benson Leung [this message]
2025-10-17 0:16 ` [PATCH v2 0/3] UCSI Power Supply Updates Kenneth Crudup
2025-10-17 0:25 ` Kenneth Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPGJrjG6nsRQune_@google.com \
--to=bleung@google.com \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=kenny@panix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).