From: Benson Leung <bleung@google.com>
To: Andrei Kuchynski <akuchynski@chromium.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Benson Leung <bleung@chromium.org>,
Jameson Thies <jthies@google.com>,
Tzung-Bi Shih <tzungbi@kernel.org>,
linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev,
Guenter Roeck <groeck@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
"Christian A. Ehrhardt" <lk@c--e.de>,
Abel Vesa <abel.vesa@linaro.org>,
Pooja Katiyar <pooja.katiyar@intel.com>,
Venkat Jayaraman <venkat.jayaraman@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] usb: typec: ucsi: Set no_mode_control flag
Date: Tue, 25 Nov 2025 00:16:03 +0000 [thread overview]
Message-ID: <aST1Q4P6noMUNH3u@google.com> (raw)
In-Reply-To: <20251124124639.1101335-4-akuchynski@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
On Mon, Nov 24, 2025 at 12:46:38PM +0000, Andrei Kuchynski wrote:
> This flag indicates that the PPM allows the OPM to change the currently
> negotiated alternate mode using the SET_NEW_CAM command.
>
> Signed-off-by: Andrei Kuchynski <akuchynski@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/usb/typec/ucsi/ucsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 9b3df776137a..82c3efd72639 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1700,6 +1700,7 @@ static int ucsi_register_port(struct ucsi *ucsi, struct ucsi_connector *con)
>
> cap->driver_data = con;
> cap->ops = &ucsi_ops;
> + cap->no_mode_control = !(con->ucsi->cap.features & UCSI_CAP_ALT_MODE_OVERRIDE);
>
> if (ucsi->version >= UCSI_VERSION_2_0)
> con->typec_cap.orientation_aware = true;
> --
> 2.52.0.rc2.455.g230fcf2819-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-11-25 0:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 12:46 [PATCH v5 0/4] USB Type-C alternate mode priorities Andrei Kuchynski
2025-11-24 12:46 ` [PATCH v5 1/4] usb: typec: Add mode_control field to port property Andrei Kuchynski
2025-11-25 0:13 ` Benson Leung
2025-11-24 12:46 ` [PATCH v5 2/4] platform/chrome: cros_ec_typec: Set no_mode_control flag Andrei Kuchynski
2025-11-25 0:15 ` Benson Leung
2025-11-24 12:46 ` [PATCH v5 3/4] usb: typec: ucsi: " Andrei Kuchynski
2025-11-25 0:16 ` Benson Leung [this message]
2025-11-24 12:46 ` [PATCH v5 4/4] usb: typec: Expose alternate mode priority via sysfs Andrei Kuchynski
2025-11-24 14:25 ` Abel Vesa
2025-11-25 0:20 ` Benson Leung
2025-11-26 9:23 ` [PATCH v5 0/4] USB Type-C alternate mode priorities Heikki Krogerus
2025-12-01 8:22 ` Andrei Kuchynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aST1Q4P6noMUNH3u@google.com \
--to=bleung@google.com \
--cc=abel.vesa@linaro.org \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lk@c--e.de \
--cc=pooja.katiyar@intel.com \
--cc=tzungbi@kernel.org \
--cc=venkat.jayaraman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).