linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andrei Kuchynski <akuchynski@chromium.org>
Cc: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
	Benson Leung <bleung@chromium.org>,
	Jameson Thies <jthies@google.com>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev,
	Guenter Roeck <groeck@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	"Christian A. Ehrhardt" <lk@c--e.de>,
	Abel Vesa <abel.vesa@linaro.org>,
	Pooja Katiyar <pooja.katiyar@intel.com>,
	Venkat Jayaraman <venkat.jayaraman@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] USB Type-C alternate mode priorities
Date: Wed, 26 Nov 2025 11:23:41 +0200	[thread overview]
Message-ID: <aSbHHXIFYAqLzxzY@kuha> (raw)
In-Reply-To: <20251124124639.1101335-1-akuchynski@chromium.org>

Hi Andrei, guys,

Mon, Nov 24, 2025 at 12:46:35PM +0000, Andrei Kuchynski kirjoitti:
> This patch series introduces a mechanism for setting USB Type-C alternate
> mode priorities. It allows the user to specify their preferred order for
> mode selection, such as USB4, Thunderbolt, or DisplayPort.
> 
> A new sysfs attribute named 'priority' is exposed to provide user-space
> control over the mode selection process.
> 
> This series was tested on a Android OS device running kernel 6.18.0-rc6.
> 
> Changes in v5:
> - Patches 3 and 4 (v4) have been consolidated into a singular patch,
> keeping the mode priority implementation within drivers/usb/typec/class.c.
> 
> Andrei Kuchynski (4):
>   usb: typec: Add mode_control field to port property
>   platform/chrome: cros_ec_typec: Set no_mode_control flag
>   usb: typec: ucsi: Set no_mode_control flag
>   usb: typec: Expose alternate mode priority via sysfs
> 
>  Documentation/ABI/testing/sysfs-class-typec | 11 +++
>  drivers/platform/chrome/cros_ec_typec.c     |  1 +
>  drivers/usb/typec/class.c                   | 99 ++++++++++++++++++++-
>  drivers/usb/typec/class.h                   |  1 +
>  drivers/usb/typec/ucsi/ucsi.c               |  1 +
>  include/linux/usb/typec.h                   |  2 +
>  include/linux/usb/typec_altmode.h           |  1 +
>  7 files changed, 112 insertions(+), 4 deletions(-)

These are okay by me. I think we can move to the next step. But I'm
not sure we apply these before that, because the file has no effect
at the moment.

Br,

-- 
heikki

  parent reply	other threads:[~2025-11-26  9:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 12:46 [PATCH v5 0/4] USB Type-C alternate mode priorities Andrei Kuchynski
2025-11-24 12:46 ` [PATCH v5 1/4] usb: typec: Add mode_control field to port property Andrei Kuchynski
2025-11-25  0:13   ` Benson Leung
2025-11-24 12:46 ` [PATCH v5 2/4] platform/chrome: cros_ec_typec: Set no_mode_control flag Andrei Kuchynski
2025-11-25  0:15   ` Benson Leung
2025-11-24 12:46 ` [PATCH v5 3/4] usb: typec: ucsi: " Andrei Kuchynski
2025-11-25  0:16   ` Benson Leung
2025-11-24 12:46 ` [PATCH v5 4/4] usb: typec: Expose alternate mode priority via sysfs Andrei Kuchynski
2025-11-24 14:25   ` Abel Vesa
2025-11-25  0:20   ` Benson Leung
2025-11-26  9:23 ` Heikki Krogerus [this message]
2025-12-01  8:22   ` [PATCH v5 0/4] USB Type-C alternate mode priorities Andrei Kuchynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSbHHXIFYAqLzxzY@kuha \
    --to=heikki.krogerus@linux.intel.com \
    --cc=abel.vesa@linaro.org \
    --cc=abhishekpandit@chromium.org \
    --cc=akuchynski@chromium.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@chromium.org \
    --cc=jthies@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lk@c--e.de \
    --cc=pooja.katiyar@intel.com \
    --cc=tzungbi@kernel.org \
    --cc=venkat.jayaraman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).