Re: [PATCH] usb: typec: hd3ss3220: Enable VBUS based on role state

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

Thu, Jan 15, 2026 at 02:11:21PM +0100, Jan Remmet kirjoitti:
> For systems where the ID pin isn't available as gpio use the ATTACHED_STATE
> register instead to control vbus.
> 
> >From the datasheet:
> "This is an additional method to communicate attach other
> than the ID pin. These bits can be read by the application to
> determine what was attached."
> 
> Use this method if id-gpios property is not set, but the connector node
> has vbus-supply defined.
> 
> Signed-off-by: Jan Remmet <j.remmet@phytec.de>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/hd3ss3220.c | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
> index 3876f4faead679e6c04062ab2bcf2ae928913a0a..a7c54aa8635f70d6979d98c95f80d4dac277fef2 100644
> --- a/drivers/usb/typec/hd3ss3220.c
> +++ b/drivers/usb/typec/hd3ss3220.c
> @@ -204,6 +204,20 @@ static const struct typec_operations hd3ss3220_ops = {
>  	.port_type_set = hd3ss3220_port_type_set,
>  };
>  
> +static void hd3ss3220_regulator_control(struct hd3ss3220 *hd3ss3220, bool on)
> +{
> +	int ret;
> +
> +	if (on)
> +		ret = regulator_enable(hd3ss3220->vbus);
> +	else
> +		ret = regulator_disable(hd3ss3220->vbus);
> +
> +	if (ret)
> +		dev_err(hd3ss3220->dev,
> +			"vbus regulator %s failed: %d\n", on ? "disable" : "enable", ret);
> +}
> +
>  static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3220)
>  {
>  	enum usb_role role_state = hd3ss3220_get_attached_state(hd3ss3220);
> @@ -221,6 +235,9 @@ static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3220)
>  		break;
>  	}
>  
> +	if (hd3ss3220->vbus && !hd3ss3220->id_gpiod)
> +		hd3ss3220_regulator_control(hd3ss3220, role_state == USB_ROLE_HOST);
> +
>  	hd3ss3220->role_state = role_state;
>  }
>  
> @@ -330,18 +347,10 @@ static const struct regmap_config config = {
>  static irqreturn_t hd3ss3220_id_isr(int irq, void *dev_id)
>  {
>  	struct hd3ss3220 *hd3ss3220 = dev_id;
> -	int ret;
>  	int id;
>  
>  	id = gpiod_get_value_cansleep(hd3ss3220->id_gpiod);
> -	if (!id)
> -		ret = regulator_enable(hd3ss3220->vbus);
> -	else
> -		ret = regulator_disable(hd3ss3220->vbus);
> -
> -	if (ret)
> -		dev_err(hd3ss3220->dev,
> -			"vbus regulator %s failed: %d\n", id ? "disable" : "enable", ret);
> +	hd3ss3220_regulator_control(hd3ss3220, !id);
>  
>  	return IRQ_HANDLED;
>  }
> 
> ---
> base-commit: 944aacb68baf7624ab8d277d0ebf07f025ca137c
> change-id: 20260115-wip-jremmet-hd3ss3220_vbus-732f74894acc
> 
> Best regards,
> -- 
> Jan Remmet <j.remmet@phytec.de>

-- 
heikki