From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77FEC48123F; Wed, 21 Jan 2026 13:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003731; cv=none; b=DEYRh0QV5k+artfs39b63epDvodoXa2pplCrRK8IQe0gwM5Bs0dtcQgZh8yWpbUopzEqSgrRl9UuPxDKhBw28zPiS7CUWBZW551sCan0ddROEEv+L6w8PQNstIaCW1mOsWLcl+GzjpLspxDVyAxQMjWbDsH9I12QfdF5xIXoCyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003731; c=relaxed/simple; bh=zQ788XQEfllG3nQ/GgyLRlAAXrNCGe6TAOHctPZutlg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ON+xcbbZtCP6c01C/3Ft1q0oBYZTrhyBQGl4EiLGKbF3eDN3SYNx7ZRW1/pGr+q6/Kb4eoczrP49sA7z8YUOMdQB6pHkDlkMLBVMX2PgWQFVxam9chqed3/M+4JIEsk95iMFQoodlCjGxgqVSLiIXnron8HkHi2x2aAepCCvY+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from duge-virtual-machine (unknown [183.192.221.134]) by APP-03 (Coremail) with SMTP id rQCowAAXOuG+2nBp3sIgBg--.24067S2; Wed, 21 Jan 2026 21:55:12 +0800 (CST) Date: Wed, 21 Jan 2026 21:55:10 +0800 From: Jiayu Du To: Vinod Koul Cc: gregkh@linuxfoundation.org, conor@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] phy: usb: Add driver for Canaan K230 USB 2.0 PHY Message-ID: References: <20260120143243.71937-1-jiayu.riscv@isrc.iscas.ac.cn> <20260120143243.71937-4-jiayu.riscv@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CM-TRANSID:rQCowAAXOuG+2nBp3sIgBg--.24067S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY67k0a2IF6w1UM7kC6x804xWl14x267AK xVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGw A2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26r1j 6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Gr 0_Cr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4j6r4UJwAS0I0E0xvYzxvE52x082IY62kv 0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z2 80aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF 7I0E8cxan2IY04v7MxAIw28IcxkI7VAKI48JMxAqzxv26xkF7I0En4kS14v26r1q6r43Mx C20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAF wI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20x vE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v2 0xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxV W8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8489tUUUUU== X-CM-SenderInfo: 5mld534oul2uny6l223fol2u1dvotugofq/ On Wed, Jan 21, 2026 at 12:37:06PM +0530, Vinod Koul wrote: > On 20-01-26, 22:32, Jiayu Du wrote: > > + * Copyright (C) 2025 Jiayu Du > > 2026 now! > ... > > + void __iomem *base = global->base; > > + u32 val; > > blank line here please > ... > > + /* Configure test register (pull-ups/pull-downs) */ > > wrong alignment above, pls fix it Thanks for pointing out these issues. I will fix them in v5.