From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andrei Kuchynski <akuchynski@chromium.org>
Cc: Jameson Thies <jthies@google.com>,
Benson Leung <bleung@chromium.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Pooja Katiyar <pooja.katiyar@intel.com>,
Johan Hovold <johan@kernel.org>,
Hsin-Te Yuan <yuanhsinte@chromium.org>,
Madhu M <madhu.m@intel.com>,
Venkat Jayaraman <venkat.jayaraman@intel.com>,
Pengyu Luo <mitltlatltl@gmail.com>,
Fedor Pchelkin <boddah8794@gmail.com>
Subject: Re: [PATCH] usb: typec: ucsi: Add Thunderbolt alternate mode support
Date: Fri, 6 Feb 2026 10:57:23 +0200 [thread overview]
Message-ID: <aYWs815nqAGCdIa-@kuha> (raw)
In-Reply-To: <20260126090616.2224907-1-akuchynski@chromium.org>
Hi Andrei,
On Mon, Jan 26, 2026 at 09:06:16AM +0000, Andrei Kuchynski wrote:
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * UCSI Thunderbolt Alternate Mode Support
> + *
> + * Copyright 2025 Google LLC
2026
> + */
> +
> +#include <linux/usb/typec_tbt.h>
> +#include <linux/usb/pd_vdo.h>
We now need to include everything instead of relying other
headers to do that for us (although, I don't think this rule is
documented anywhere yet). Include at least these:
linux/err.h
linux/dev_printk.h
linux/device/devres.h
linux/gfp_types.h
linux/types.h
linux/usb/typec_altmode.h
linux/workqueue.h
Otherwise this looks good to me.
thanks,
--
heikki
next prev parent reply other threads:[~2026-02-06 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 9:06 [PATCH] usb: typec: ucsi: Add Thunderbolt alternate mode support Andrei Kuchynski
2026-02-06 8:57 ` Heikki Krogerus [this message]
2026-02-06 11:08 ` Andrei Kuchynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYWs815nqAGCdIa-@kuha \
--to=heikki.krogerus@linux.intel.com \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=boddah8794@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=madhu.m@intel.com \
--cc=mitltlatltl@gmail.com \
--cc=pooja.katiyar@intel.com \
--cc=venkat.jayaraman@intel.com \
--cc=yuanhsinte@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox