From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AAC336D501; Tue, 24 Feb 2026 09:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771926730; cv=none; b=EQxN7gl7QC65tN0Ji9eM4ZFNsGHNcTpPFGzpmWToKK7b14YlYdVCHiL1QSoT21W8+dYirnX3qRcyhIBOB4QczoG64UkY7x5yuBQYZWmDSSNNwzbnW0Ju4jFi9lkfbW/olqEwknUKXlD1niNjdVgs4qb25jzdJ52tNJAZ2+x7wQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771926730; c=relaxed/simple; bh=6pRu6zq62WMN+WyuOARkXhLVVqohePZFybaoMP30tgE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ii4xKhWqaisUvTlNYj9e2/7VaYmhjW8FmJ3B9440gNmPBLYauoNlPDX18EyOjnZxTS6uGCAcX80GuPft7+9MFrptmyD9SE5CRNu+m+UDlJlWxIkv0toLkWEpAyNglFEcMzw3deW0vJ1F9e2xb2c5sSdHlcwnG5PRlBAI24KDfvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V6P7jZjX; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V6P7jZjX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771926730; x=1803462730; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6pRu6zq62WMN+WyuOARkXhLVVqohePZFybaoMP30tgE=; b=V6P7jZjXOp7dGq2bPPUvn76MJrS+PBiWRfeb4K0oFENkKYRLFwFzszzF L6uSyCqTvkbO+mkiboBbv2Lt5DlRtmuShbuG54EIbVrJyl1xN63+0bKtb V4HhROTvWqkBS2ivVqL88F3dqg2SlMYijZuY8TpIRooIjHakBE0NvLPMd CnMyopWR+FU8rq/MF4e0RnsiZoUDSSeCuekO6Y7KSVD0dzLJCLSC4O55j sDMF42r/kjh9N0YafRpyqDsAhhEzEuZ8ReHo+rwWPj48xH6vLFCrxGHDH zub6S1e31PnO+q/WYyeCxMnQFvMnpkVlQzTa/rPSL+/qGoA0x6j6oz+Wr g==; X-CSE-ConnectionGUID: 6rHCy/8eSmux7uuCOJJ8yA== X-CSE-MsgGUID: To1dQcefR3mZbYiunuTPwQ== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="72839844" X-IronPort-AV: E=Sophos;i="6.21,308,1763452800"; d="scan'208";a="72839844" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2026 01:52:09 -0800 X-CSE-ConnectionGUID: gAL2aXsLSUO2SshtxEY5qA== X-CSE-MsgGUID: N2EPebGQTo+YHb65fFnqkw== X-ExtLoop1: 1 Received: from aschofie-mobl2.amr.corp.intel.com (HELO kuha) ([10.124.222.187]) by fmviesa003.fm.intel.com with SMTP; 24 Feb 2026 01:52:06 -0800 Received: by kuha (sSMTP sendmail emulation); Tue, 24 Feb 2026 11:51:31 +0200 Date: Tue, 24 Feb 2026 11:51:31 +0200 From: Heikki Krogerus To: Sebastian Reichel Cc: Greg Kroah-Hartman , linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v2 2/2] usb: typec: mux: avoid duplicated mux switches Message-ID: References: <20260223-typec-mux-duplication-fix-v2-0-0402fefc222e@collabora.com> <20260223-typec-mux-duplication-fix-v2-2-0402fefc222e@collabora.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223-typec-mux-duplication-fix-v2-2-0402fefc222e@collabora.com> Mon, Feb 23, 2026 at 07:27:39PM +0100, Sebastian Reichel wrote: > Some devices use combo PHYs (i.e. USB3 + DisplayPort), which also > handle the lane muxing. These PHYs are referenced twice from > the USB-C connector (USB super-speed lines and SBU/AUX lines) > resulting in the mux being configured twice. Avoid this by > dropping duplicates. > > Signed-off-by: Sebastian Reichel Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/mux.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c > index 9b908c46bd7d..db5e4a4c0a99 100644 > --- a/drivers/usb/typec/mux.c > +++ b/drivers/usb/typec/mux.c > @@ -275,7 +275,9 @@ static int mux_fwnode_match(struct device *dev, const void *fwnode) > static void *typec_mux_match(const struct fwnode_handle *fwnode, > const char *id, void *data) > { > + struct typec_mux_dev **mux_devs = data; > struct device *dev; > + int i; > > /* > * Device graph (OF graph) does not give any means to identify the > @@ -291,6 +293,14 @@ static void *typec_mux_match(const struct fwnode_handle *fwnode, > dev = class_find_device(&typec_mux_class, NULL, fwnode, > mux_fwnode_match); > > + /* Skip duplicates */ > + for (i = 0; i < TYPEC_MUX_MAX_DEVS; i++) > + if (to_typec_mux_dev(dev) == mux_devs[i]) { > + put_device(dev); > + return NULL; > + } > + > + > return dev ? to_typec_mux_dev(dev) : ERR_PTR(-EPROBE_DEFER); > } > > @@ -316,7 +326,8 @@ struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode) > return ERR_PTR(-ENOMEM); > > count = fwnode_connection_find_matches(fwnode, "mode-switch", > - NULL, typec_mux_match, > + (void **)mux_devs, > + typec_mux_match, > (void **)mux_devs, > ARRAY_SIZE(mux_devs)); > if (count <= 0) { > > -- > 2.51.0 -- heikki