* [PATCH] usb: ucsi: huawei_gaokun: make gaokun_ucsi_ops static
@ 2026-03-05 14:40 Pengyu Luo
2026-03-09 11:33 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Pengyu Luo @ 2026-03-05 14:40 UTC (permalink / raw)
To: Pengyu Luo, Heikki Krogerus, Greg Kroah-Hartman
Cc: kernel test robot, linux-usb, linux-kernel
The gaokun_ucsi_ops structure is only used within its translation unit
and is not referenced from any other file. Add the 'static' qualifier
to avoid unnecessary symbol export.
Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603050203.KD4RWA00-lkp@intel.com
Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
---
drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c b/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
index c5965656b..ca749fde4 100644
--- a/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
+++ b/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
@@ -193,7 +193,7 @@ static void gaokun_ucsi_connector_status(struct ucsi_connector *con)
gaokun_set_orientation(con, &uec->ports[idx]);
}
-const struct ucsi_operations gaokun_ucsi_ops = {
+static const struct ucsi_operations gaokun_ucsi_ops = {
.read_version = gaokun_ucsi_read_version,
.read_cci = gaokun_ucsi_read_cci,
.poll_cci = gaokun_ucsi_read_cci,
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: ucsi: huawei_gaokun: make gaokun_ucsi_ops static
2026-03-05 14:40 [PATCH] usb: ucsi: huawei_gaokun: make gaokun_ucsi_ops static Pengyu Luo
@ 2026-03-09 11:33 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2026-03-09 11:33 UTC (permalink / raw)
To: Pengyu Luo; +Cc: Greg Kroah-Hartman, kernel test robot, linux-usb, linux-kernel
Thu, Mar 05, 2026 at 10:40:36PM +0800, Pengyu Luo kirjoitti:
> The gaokun_ucsi_ops structure is only used within its translation unit
> and is not referenced from any other file. Add the 'static' qualifier
> to avoid unnecessary symbol export.
>
> Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202603050203.KD4RWA00-lkp@intel.com
> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c b/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
> index c5965656b..ca749fde4 100644
> --- a/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
> +++ b/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
> @@ -193,7 +193,7 @@ static void gaokun_ucsi_connector_status(struct ucsi_connector *con)
> gaokun_set_orientation(con, &uec->ports[idx]);
> }
>
> -const struct ucsi_operations gaokun_ucsi_ops = {
> +static const struct ucsi_operations gaokun_ucsi_ops = {
> .read_version = gaokun_ucsi_read_version,
> .read_cci = gaokun_ucsi_read_cci,
> .poll_cci = gaokun_ucsi_read_cci,
> --
> 2.53.0
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-09 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-05 14:40 [PATCH] usb: ucsi: huawei_gaokun: make gaokun_ucsi_ops static Pengyu Luo
2026-03-09 11:33 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox