From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46783C77B73 for ; Tue, 2 May 2023 08:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233565AbjEBIwe (ORCPT ); Tue, 2 May 2023 04:52:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233276AbjEBIwc (ORCPT ); Tue, 2 May 2023 04:52:32 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28F3D19A1; Tue, 2 May 2023 01:52:30 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3428Fgqj011343; Tue, 2 May 2023 08:52:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=+VddXSyOfzpEchGICpblvBPOtseNU5edsFWE9wjsOXU=; b=pdah1vVTu4Qeo+UdoCAvSmB9elJUcwJm+BG2OJGTpuFTZDXGubG+FqREbYmnf86q1ip7 tyAE8yjGt3UBZEpbwFFsxsqMsKJX7iT6uMI80an/MwNbi3ETqUAWgePHzBEzknc5RkII 0yFhQ/q5aFDbUAL94QsqIzD3/f79BwBB97K8ji+4P5XzqWkeHlsUPOdDq1M/VwtbykRo fbjNkCoJX06j6gFJmGd40P8NqS8wo6DLj887fHgZIzsds6mapadvuZaQeHc4KVEq02wA j3W4UBTPOdxe8/nIJNs5/KhAtqGHRujJBo1rvG4CTix1d/t/ibqAIZELj3A2IMJC9Ajn eQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qahhk9k9h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 May 2023 08:52:21 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3428qIsG005272 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 2 May 2023 08:52:18 GMT Received: from [10.216.63.8] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 2 May 2023 01:52:11 -0700 Message-ID: Date: Tue, 2 May 2023 14:22:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v7 1/9] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport Content-Language: en-US To: Krzysztof Kozlowski , Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , Andy Gross , "Bjorn Andersson" , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Felipe Balbi , "Wesley Cheng" CC: , , , , , , , , , References: <20230501143445.3851-1-quic_kriskura@quicinc.com> <20230501143445.3851-2-quic_kriskura@quicinc.com> <0f2dea5a-b6f7-b659-f41e-55d1777b4dd1@linaro.org> From: Krishna Kurapati PSSNV In-Reply-To: <0f2dea5a-b6f7-b659-f41e-55d1777b4dd1@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: X6YDtrz8Xh7K-Ls_oMKGkWir62yNRGjU X-Proofpoint-GUID: X6YDtrz8Xh7K-Ls_oMKGkWir62yNRGjU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-02_05,2023-04-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 mlxlogscore=882 phishscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305020077 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 5/2/2023 2:17 PM, Krzysztof Kozlowski wrote: > On 02/05/2023 10:35, Krishna Kurapati PSSNV wrote: >> >> >> On 5/2/2023 1:18 PM, Krzysztof Kozlowski wrote: >>> On 01/05/2023 16:34, Krishna Kurapati wrote: >>>> Add the compatible string for SC8280 Multiport USB controller from >>>> Qualcomm. >>>> >>>> There are 4 power event irq interrupts supported by this controller >>>> (one for each port of multiport). Added all the 4 as non-optional >>>> interrupts for SC8280XP-MP >>>> >>>> Signed-off-by: Krishna Kurapati >>>> --- >>>> .../devicetree/bindings/usb/qcom,dwc3.yaml | 21 +++++++++++++++++++ >>>> 1 file changed, 21 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >>>> index d84281926f10..2c96da1ce5b8 100644 >>>> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >>>> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >>>> @@ -26,6 +26,7 @@ properties: >>>> - qcom,sc7180-dwc3 >>>> - qcom,sc7280-dwc3 >>>> - qcom,sc8280xp-dwc3 >>>> + - qcom,sc8280xp-dwc3-mp >>> >>> SC8280xp comes with two USB controllers: one single-port and one multi-port? >> >> Hi Krzysztof, >> >> SC8280XP comes with 3 controllers. The first two are single port >> controller and the third one is a multiport controller. In DTSI: >> usb_0 / usb1: have compatible set to : "qcom,sc8280xp-dwc3" >> >> And multiport controller has it set to "qcom,sc8280xp-dwc3-mp" > > OK, then this looks fine. > > Please add the compatible to existing allOf:if:then to constrain clocks > and other pieces. If none of existing if:then: matches your case, add > new one. > > Best regards, > Krzysztof > Thanks Krzysztof. One query: Clocks are same for both single/multiport controllers. Would the following be fine ? diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml index 2c96da1ce5b8..c0f4745febf0 100644 --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml @@ -263,6 +263,7 @@ allOf: contains: enum: - qcom,sc8280xp-dwc3 + - qcom,sc8280xp-dwc3-mp then: properties: clocks: Regards, Krishna,