Linux USB
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Lixu Zhang <lixu.zhang@intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] USB: ljca: drop redundant interface reference
Date: Thu, 5 Mar 2026 15:18:35 +0200	[thread overview]
Message-ID: <aamCq4wEprHMX56a@kekkonen.localdomain> (raw)
In-Reply-To: <20260305111511.18386-4-johan@kernel.org>

Hi Johan,

Thanks for the patch.

On Thu, Mar 05, 2026 at 12:15:09PM +0100, Johan Hovold wrote:
> Driver core holds a reference to the USB interface while it is bound to
> a driver and there is no need to take another reference unless the
> interface is needed after disconnect.
> 
> Drop the redundant interface reference to reduce cargo culting, make it
> easier to spot drivers where an extra reference is needed, and reduce
> the risk of memory leaks when drivers fail to release it.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Kind regards,

Sakari Ailus

  reply	other threads:[~2026-03-05 13:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 11:15 [PATCH 0/5] USB: drop redundant references Johan Hovold
2026-03-05 11:15 ` [PATCH 1/5] USB: cypress_cy7c63: drop redundant device reference Johan Hovold
2026-03-05 11:15 ` [PATCH 2/5] USB: cytherm: " Johan Hovold
2026-03-05 11:15 ` [PATCH 3/5] USB: ljca: drop redundant interface reference Johan Hovold
2026-03-05 13:18   ` Sakari Ailus [this message]
2026-03-05 11:15 ` [PATCH 4/5] USB: trancevibrator: drop redundant device reference Johan Hovold
2026-03-05 11:15 ` [PATCH 5/5] USB: usbsevseg: " Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aamCq4wEprHMX56a@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lixu.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox