From: Joshua Crofts <crofts@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Bin Liu" <b-liu@ti.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Felipe Balbi" <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: musb: fix use-after-free in musb_remove()
Date: Fri, 20 Nov 2026 15:56:19 +0100 [thread overview]
Message-ID: <ab82b578-8630-4ee6-abc4-50c0c6aab7b0@kernel.org> (raw)
In-Reply-To: <awBebBuAg2w6ZitD@hovoldconsulting.com>
On 20-Nov-26 15:51, Johan Hovold wrote:
> On Fri, Nov 20, 2026 at 03:23:14PM +0100, Joshua Crofts wrote:
>> Currently in musb_remove(), musb_platform_exit() drops the PHY refcount
>> before usb_phy_shutdown() is called, causing a use-after-free bug.
>
> This is too strongly worded. There is a potential for a use-after-free
> here but it's extremely unlikely to ever be an issue in practice as the
> phy driver would need to be unloaded by root while they are already
> unbinding the host controller.
>
> Why would root want to do that to themselves?
Okay, if I add the word potentially then it's not too strong.
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-11-20 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 14:23 [PATCH v2] usb: musb: fix use-after-free in musb_remove() Joshua Crofts
2026-11-20 14:37 ` sashiko-bot
2026-11-20 14:51 ` Johan Hovold
2026-11-20 14:56 ` Joshua Crofts [this message]
2026-11-20 14:58 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab82b578-8630-4ee6-abc4-50c0c6aab7b0@kernel.org \
--to=crofts@kernel.org \
--cc=b-liu@ti.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox