public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	AceLan Kao <acelan.kao@canonical.com>,
	Pooja Katiyar <pooja.katiyar@intel.com>,
	Abel Vesa <abel.vesa@linaro.org>,
	Andrei Kuchynski <akuchynski@chromium.org>,
	Venkat Jayaraman <venkat.jayaraman@intel.com>,
	"Christian A. Ehrhardt" <lk@c--e.de>,
	Pei Xiao <xiaopei01@kylinos.cn>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] usb: typec: ucsi: Detect and skip duplicate altmodes from buggy firmware
Date: Wed, 11 Mar 2026 15:57:39 +0200	[thread overview]
Message-ID: <abF00-Squp-tEOKS@kuha> (raw)
In-Reply-To: <ffzdbsfxugeoca3csa56t3ieh5laxdyra3kx6mh646eokezhkr@v6xqqbjtn42m>

Thu, Mar 05, 2026 at 04:58:02PM +0200, Dmitry Baryshkov kirjoitti:
> On Wed, Feb 11, 2026 at 06:37:41AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Feb 11, 2026 at 11:32:37AM +0800, AceLan Kao wrote:
> > > A gentle ping.
> > > Please help to review these patches, thanks.
> > 
> > Wait, no, we rejected this series and said "fix the firmware".
> > 
> > What happened to doing that?
> 
> Having a similar problem with other platforms. It's not always possible
> to fix the firmware. I have one platform with a similar issue, but that
> laptop is EOLed long ago (Lenovo Yoga C630, the issue has been worked
> around in the EC driver, but I'd be really happy to switch to the
> generic fixup). At this point it really feels that there might
> be more UCSI implemetations having this issue. 

I would still like to get an answer from Dell for this (if this was
the Dell case). It looks like they are using the GET_ALTMODES_COMMAND
in some custom way. It's almost like they are first returning all the
SVIDs without the modes, followed by something else.

So even if these products are EOL, and we will never get the firmware
fixed, we still need to understand what exactly is being returned to
the command, and is it returned like that intentionally or not.

Br,

-- 
heikki

      reply	other threads:[~2026-03-11 13:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-24  7:00 [PATCH v3 1/3] usb: typec: ucsi: Detect and skip duplicate altmodes from buggy firmware Chia-Lin Kao (AceLan)
2025-12-24  7:00 ` [PATCH v3 2/3] usb: typec: ucsi: Add duplicate detection to nvidia registration path Chia-Lin Kao (AceLan)
2025-12-24  7:00 ` [PATCH v3 3/3] usb: typec: ucsi: yoga_c630: Remove redundant duplicate altmode handling Chia-Lin Kao (AceLan)
2026-02-11  3:32 ` [PATCH v3 1/3] usb: typec: ucsi: Detect and skip duplicate altmodes from buggy firmware AceLan Kao
2026-02-11  5:36   ` Greg Kroah-Hartman
2026-02-11  8:43     ` Heikki Krogerus
2026-02-11  5:37   ` Greg Kroah-Hartman
2026-03-05 14:58     ` Dmitry Baryshkov
2026-03-11 13:57       ` Heikki Krogerus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abF00-Squp-tEOKS@kuha \
    --to=heikki.krogerus@linux.intel.com \
    --cc=abel.vesa@linaro.org \
    --cc=acelan.kao@canonical.com \
    --cc=akuchynski@chromium.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lk@c--e.de \
    --cc=pooja.katiyar@intel.com \
    --cc=venkat.jayaraman@intel.com \
    --cc=xiaopei01@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox