[PATCH v2] usb: typec: add kernel-doc for priority and mode_selection members

[PATCH v2] usb: typec: add kernel-doc for priority and mode_selection members

[Kit Dallege]

Document the priority and mode_selection members of struct
typec_altmode that were added without kernel-doc descriptions.

This fixes the following warnings when building with W=1:

  include/linux/usb/typec_altmode.h: struct member 'priority' not
described in 'typec_altmode'
  include/linux/usb/typec_altmode.h: struct member 'mode_selection'
not described in 'typec_altmode'

Signed-off-by: Kit Dallege <xaum.io@gmail.com>
---
v2: resend so From matches Signed-off-by (Greg KH)

 include/linux/usb/typec_altmode.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/usb/typec_altmode.h
b/include/linux/usb/typec_altmode.h
index 0513d333b797..c7cfc4629484 100644
--- a/include/linux/usb/typec_altmode.h
+++ b/include/linux/usb/typec_altmode.h
@@ -26,6 +26,8 @@ struct typec_altmode_ops;
  * @mode: Index of the Mode
  * @vdo: VDO returned by Discover Modes USB PD command
  * @active: Tells has the mode been entered or not
+ * @priority: Numeric priority for alternate mode selection ordering
+ * @mode_selection: Indicates support for the mode selection feature
  * @desc: Optional human readable description of the mode
  * @ops: Operations vector from the driver
  * @cable_ops: Cable operations vector from the driver.
--
2.53.0

Re: [PATCH v2] usb: typec: add kernel-doc for priority and mode_selection members

[Heikki Krogerus]

Fri, Mar 13, 2026 at 12:29:56PM +0100, Kit Dallege kirjoitti:
> Document the priority and mode_selection members of struct
> typec_altmode that were added without kernel-doc descriptions.
> 
> This fixes the following warnings when building with W=1:
> 
>   include/linux/usb/typec_altmode.h: struct member 'priority' not
> described in 'typec_altmode'
>   include/linux/usb/typec_altmode.h: struct member 'mode_selection'
> not described in 'typec_altmode'
> 
> Signed-off-by: Kit Dallege <xaum.io@gmail.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> v2: resend so From matches Signed-off-by (Greg KH)
> 
>  include/linux/usb/typec_altmode.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/usb/typec_altmode.h
> b/include/linux/usb/typec_altmode.h
> index 0513d333b797..c7cfc4629484 100644
> --- a/include/linux/usb/typec_altmode.h
> +++ b/include/linux/usb/typec_altmode.h
> @@ -26,6 +26,8 @@ struct typec_altmode_ops;
>   * @mode: Index of the Mode
>   * @vdo: VDO returned by Discover Modes USB PD command
>   * @active: Tells has the mode been entered or not
> + * @priority: Numeric priority for alternate mode selection ordering
> + * @mode_selection: Indicates support for the mode selection feature
>   * @desc: Optional human readable description of the mode
>   * @ops: Operations vector from the driver
>   * @cable_ops: Cable operations vector from the driver.
> --
> 2.53.0

-- 
heikki

Re: [PATCH v2] usb: typec: add kernel-doc for priority and mode_selection members

[Greg KH]

On Fri, Mar 13, 2026 at 12:29:56PM +0100, Kit Dallege wrote:
> Document the priority and mode_selection members of struct
> typec_altmode that were added without kernel-doc descriptions.
> 
> This fixes the following warnings when building with W=1:
> 
>   include/linux/usb/typec_altmode.h: struct member 'priority' not
> described in 'typec_altmode'
>   include/linux/usb/typec_altmode.h: struct member 'mode_selection'
> not described in 'typec_altmode'
> 
> Signed-off-by: Kit Dallege <xaum.io@gmail.com>
> ---
> v2: resend so From matches Signed-off-by (Greg KH)
> 
>  include/linux/usb/typec_altmode.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/usb/typec_altmode.h
> b/include/linux/usb/typec_altmode.h
> index 0513d333b797..c7cfc4629484 100644
> --- a/include/linux/usb/typec_altmode.h
> +++ b/include/linux/usb/typec_altmode.h
> @@ -26,6 +26,8 @@ struct typec_altmode_ops;
>   * @mode: Index of the Mode
>   * @vdo: VDO returned by Discover Modes USB PD command
>   * @active: Tells has the mode been entered or not
> + * @priority: Numeric priority for alternate mode selection ordering
> + * @mode_selection: Indicates support for the mode selection feature
>   * @desc: Optional human readable description of the mode
>   * @ops: Operations vector from the driver
>   * @cable_ops: Cable operations vector from the driver.
> --
> 2.53.0

Sent by someone else before you:
	https://lore.kernel.org/r/20260311163320.61534-1-aldocontelk@gmail.com