From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A64983822BA; Mon, 30 Mar 2026 09:21:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774862494; cv=none; b=Buqi4pQXimu3LOpgpwH74iuL/lbIdKzMTHPv5x80aidDieBbB25ZB7Bv8O1a1MpXJ4otKoYZtT8HbCJ6kpEHZ9sOEvh2D2WteJQht7zeRA40DJ9BdguM/avylEzbvBuyGAvnj+0vTdVj+0jfs2yvmFfuDHP1o4Fu4YkCYAcayIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774862494; c=relaxed/simple; bh=MDcAM5kNFiE3XA6EjFqxdKlUy0aG+BBG7s9+QCWfw4g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UqpjqBaf6hn3qraVsXLuMFPL2DPirddHCI4ji128SLb8WccB9RjqdvZonMDqvSNTG9bJZKQ4hxm77bBPUn91Hd6knsjq0c5ttraWZODVNiCCXDnvbHhN/+hHsbFocUwKAEaa2W65zsUz7aNhCrksO+Vm1bcL69kjrYijBO+tNJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=blAGT2Q/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="blAGT2Q/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CADDC4CEF7; Mon, 30 Mar 2026 09:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774862494; bh=MDcAM5kNFiE3XA6EjFqxdKlUy0aG+BBG7s9+QCWfw4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=blAGT2Q/p0WgylEkrH+yz+upcH1JqT6nlyC0eiw1/Ny4Z2WCN2OZzp/iJ8t+oYxir h4vZ21yAS7ZjAIj+DqUf9ecH62NmNOfb7AZBKqh2oE4Uug1J/Bpefjgv6/sJBnGdmY cL2qtovgnOMLChiwcoX1Pvse/wFa5gY++BlvTMCac8ciPxw4/sET0st8b7QVqT94nk qEfWGfWvKrtyZdeIKklJ517eYdVRo5/IC8S061HEIwJduN2jSruESOsAtCjjn3W/iW cCPBOZujuX07zBJWX5saiVhQKOLJ+a8A++WyllCOG9O6PFM6MvPMKmfrPWcOmoZ1Ai 0wwwDk78SH+hw== Date: Mon, 30 Mar 2026 17:21:30 +0800 From: "Peter Chen (CIX)" To: Yongchao Wu Cc: Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: cdns3: gadget: fix NULL pointer dereference in ep_queue Message-ID: References: <20260328143842.57315-1-yongchao.wu@autochips.com> <20260329013404.116481-1-yongchao.wu@autochips.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260329013404.116481-1-yongchao.wu@autochips.com> On 26-03-29 09:34:04, Yongchao Wu wrote: > When the gadget endpoint is disabled or not yet configured, the ep->desc > pointer can be NULL. This leads to a NULL pointer dereference when > __cdns3_gadget_ep_queue() is called, causing a kernel crash. > > Add a check to return -ESHUTDOWN if ep->desc is NULL, which is the > standard return code for unconfigured endpoints. > > This prevents potential crashes when ep_queue is called on endpoints > that are not ready. > > Signed-off-by: Yongchao Wu Add Fixed-by tag and Cc to stable tree please, others: Acked-by: Peter Chen Peter > --- > drivers/usb/cdns3/cdns3-gadget.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c > index d59a60a16..96d2a4c38 100644 > --- a/drivers/usb/cdns3/cdns3-gadget.c > +++ b/drivers/usb/cdns3/cdns3-gadget.c > @@ -2589,6 +2589,9 @@ static int __cdns3_gadget_ep_queue(struct usb_ep *ep, > struct cdns3_request *priv_req; > int ret = 0; > > + if (!ep->desc) > + return -ESHUTDOWN; > + > request->actual = 0; > request->status = -EINPROGRESS; > priv_req = to_cdns3_request(request); > -- > 2.43.0 > > -- Best regards, Peter