From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: zwisler@google.com
Cc: Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: xhci problem -> general protection fault
Date: Tue, 13 Oct 2020 10:49:29 +0300 [thread overview]
Message-ID: <ad976018-31ec-3b1e-464c-363a08538ef5@linux.intel.com> (raw)
In-Reply-To: <20201012215348.GA3324220@google.com>
On 13.10.2020 0.53, zwisler@google.com wrote:
> On Mon, Oct 12, 2020 at 10:20:31PM +0300, Mathias Nyman wrote:
>> On 1.10.2020 19.43, zwisler@google.com wrote:
>>> On Tue, Sep 29, 2020 at 01:35:31AM +0300, Mathias Nyman wrote:
>
>> I'm rewriting how xhci driver handles halted and canceled transfers.
>> While looking into it I found an older case where hardware gives bad data
>> in the output context. This was 10 years ago and on some specic hardware,
>> see commit:
>>
>> ac9d8fe7c6a8 USB: xhci: Add quirk for Fresco Logic xHCI hardware.
>>
>>>
>>> I'm happy to gather logs with more debug or run other experiments, if that
>>> would be helpful. As it is I don't really know how to debug the internal
>>> state of the HC further, but hopefully the knowledge that the patch below
>>> makes a difference will help us move forward.
>>
>> Great thanks, it will take some time before rewrite is ready.
>
> Should we/I invest time in trying to create a quirk similar to
>
>> ac9d8fe7c6a8 USB: xhci: Add quirk for Fresco Logic xHCI hardware.
>
> in the mean time, or should we just wait for your rewrite?
>
I've been focusing on this part so rewrite shouldn't take long.
If hardware is still giving incorrect values after this we might
also need a quirk on top of it.
-Mathias
next prev parent reply other threads:[~2020-10-13 7:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 15:30 xhci problem -> general protection fault Andrzej Pietrasiewicz
2020-09-18 10:50 ` Mathias Nyman
2020-09-18 14:20 ` Andrzej Pietrasiewicz
2020-09-25 13:40 ` Mathias Nyman
2020-09-25 21:05 ` Ross Zwisler
2020-09-28 13:32 ` Andrzej Pietrasiewicz
2020-09-29 7:13 ` Mathias Nyman
2020-10-01 14:13 ` Andrzej Pietrasiewicz
2020-09-28 22:35 ` Mathias Nyman
2020-10-01 16:43 ` zwisler
2020-10-12 19:20 ` Mathias Nyman
2020-10-12 21:53 ` zwisler
2020-10-13 7:49 ` Mathias Nyman [this message]
2020-10-13 8:29 ` Andrzej Pietrasiewicz
2020-10-13 16:44 ` zwisler
2020-11-19 16:52 ` Ross Zwisler
2020-11-23 15:06 ` Mathias Nyman
2020-12-02 22:59 ` Ross Zwisler
2020-12-04 18:07 ` Mathias Nyman
2020-12-08 17:24 ` Ross Zwisler
2020-12-09 13:11 ` Mathias Nyman
2020-12-09 18:54 ` Ross Zwisler
2020-12-30 12:33 ` Mathias Nyman
2021-01-06 18:52 ` Ross Zwisler
2021-01-07 8:57 ` Mathias Nyman
2021-01-07 16:07 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad976018-31ec-3b1e-464c-363a08538ef5@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=andrzej.p@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-usb@vger.kernel.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).