Re: [PATCH 02/47] arm64: dts: qcom: qcs9100: Introduce QCS9100 SoC dtsi

Tengfei Fan
2024-07-03T09:25:27Z

On 7/3/2024 12:40 PM, Krzysztof Kozlowski wrote:
> On 03/07/2024 04:58, Tengfei Fan wrote:
>> Introduce QCS9100 SoC dtsi, QCS9100 is mainly used in IoT products.
>> QCS9100 is drived from SA8775p.
>> The current QCS9100 SoC dtsi is directly renamed from the SA8775p SoC
>> dtsi.
>> The QCS9100 platform is currently in the early design stage. Currently,
>> Both the QCS9100 platform and SA8775p platform use non-SCMI resources,
>> In the future, the SA8775p platform will transition to using SCMI
>> resources and it will have new sa8775p-related device tree.
>> This QCS9100 SoC dtsi remains consistent with the current SA8775p SoC
>> dtsi, except for updating the following sa8775p-related compatible names
>> to the qcs9100-related compatible name:
>> - qcom,sa8775p-clk-virt
>> - qcom,sa8775p-mc-virt
>> - qcom,sa8775p-adsp-pas
>> - qcom,sa8775p-cdsp-pas
>> - qcom,sa8775p-cdsp1-pas
>> - qcom,sa8775p-gpdsp0-pas
>> - qcom,sa8775p-gpdsp1-pas
>> - qcom,sa8775p-gcc
>> - qcom,sa8775p-ipcc
>> - qcom,sa8775p-config-noc
>> - qcom,sa8775p-system-noc
>> - qcom,sa8775p-aggre1-noc
>> - qcom,sa8775p-aggre2-noc
>> - qcom,sa8775p-pcie-anoc
>> - qcom,sa8775p-gpdsp-anoc
>> - qcom,sa8775p-mmss-noc
>> - qcom,sa8775p-trng
>> - qcom,sa8775p-ufshc
>> - qcom,sa8775p-qmp-ufs-phy
>> - qcom,sa8775p-qce
>> - qcom,sa8775p-lpass-ag-noc
>> - qcom,sa8775p-usb-hs-phy
>> - qcom,sa8775p-dc-noc
>> - qcom,sa8775p-gem-noc
>> - qcom,sa8775p-dwc3
>> - qcom,sa8775p-qmp-usb3-uni-phy
>> - qcom,sa8775p-gpucc
>> - qcom,sa8775p-smmu-500
>> - qcom,sa8775p-dwmac-sgmii-phy
>> - qcom,sa8775p-llcc-bwmon
>> - qcom,sa8775p-cpu-bwmon
>> - qcom,sa8775p-llcc
>> - qcom,sa8775p-videocc
>> - qcom,sa8775p-camcc
>> - qcom,sa8775p-dispcc0
>> - qcom,sa8775p-pdc
>> - qcom,sa8775p-aoss-qmp
>> - qcom,sa8775p-tlmm
>> - qcom,sa8775p-imem
>> - qcom,sa8775p-smmu-500
>> - qcom,sa8775p-rpmh-clk
>> - qcom,sa8775p-rpmhpd
>> - qcom,sa8775p-cpufreq-epss
>> - qcom,sa8775p-dispcc1
>> - qcom,sa8775p-ethqos
>> - qcom,sa8775p-nspa-noc
>> - qcom,sa8775p-nspb-noc
>> - qcom,sa8775p-qmp-gen4x2-pcie-phy
>> - qcom,sa8775p-qmp-gen4x4-pcie-phy
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>> .../dts/qcom/{sa8775p.dtsi => qcs9100.dtsi} | 112 +++++++++---------
>> 1 file changed, 56 insertions(+), 56 deletions(-)
>> rename arch/arm64/boot/dts/qcom/{sa8775p.dtsi => qcs9100.dtsi} (97%)
>>
>
> How do any things compile at this point? Please squash the patches. Your
> patchset must be bisectable at build level (dtschema validation does not
> have to).
>
> Best regards,
> Krzysztof
>

The compilation issue indeed arises when applying only this single
patch. In the new version patch series, I plan to consolidate the three
patches that rename sa8775p.dtsi to qcs9100.dtsi, sa8775p-pmics.dtsi to
qcs9100-pmics.dtsi, and sa87750-ride.dts to qcs9100-ride.dts into a
single patch.

--
Thx and BRs,
Tengfei Fan