From: Randy Dunlap <rdunlap@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>,
pawell@cadence.com, peter.chen@nxp.com, rogerq@ti.com,
a-govindraju@ti.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: cdns3: Fixed kernel test robot warning
Date: Wed, 9 Dec 2020 13:12:19 -0800 [thread overview]
Message-ID: <ae8cd88c-ea5d-a045-c6cd-2579a55f88d2@infradead.org> (raw)
In-Reply-To: <1607544952-4891-1-git-send-email-jrdr.linux@gmail.com>
On 12/9/20 12:15 PM, Souptick Joarder wrote:
> Kernel test robot throws below warning ->
>
> In file included from drivers/usb/cdns3/core.c:23:
>>> drivers/usb/cdns3/host-export.h:27:51: warning: 'struct usb_hcd'
>>> declared inside parameter list will not be visible outside of this
>>> definition or declaration
> 27 | static inline int xhci_cdns3_suspend_quirk(struct usb_hcd
> *hcd)
> | ^~~~~~~
>
> This patch will silence it.
Really? Didn't silence it for me when I tested this patch.
Also, please see
https://lore.kernel.org/linux-usb/DBBPR04MB7979502194410BB1AE96DF038BCC0@DBBPR04MB7979.eurprd04.prod.outlook.com/T/#m7f73fdd57c0f1577fb610dcaf28646b53fa7dc26
(what a strange URL)
I now get these 2 warnings:
In file included from ../drivers/usb/cdns3/core.c:23:0:
../drivers/usb/cdns3/host-export.h:27:44: warning: ‘struct usb_hcd’ declared inside parameter list will not be visible outside of this definition or declaration
static int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
^~~~~~~
CC [M] drivers/usb/gadget/function/uvc_queue.o
../drivers/usb/cdns3/host-export.h:27:12: warning: ‘xhci_cdns3_suspend_quirk’ defined but not used [-Wunused-function]
static int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
^~~~~~~~~~~~~~~~~~~~~~~~
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/usb/cdns3/host-export.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/host-export.h b/drivers/usb/cdns3/host-export.h
> index fb8541b..c1259af 100644
> --- a/drivers/usb/cdns3/host-export.h
> +++ b/drivers/usb/cdns3/host-export.h
> @@ -24,7 +24,7 @@ static inline int cdns_host_init(struct cdns *cdns)
> }
>
> static inline void cdns_host_exit(struct cdns *cdns) { }
> -static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
> +static int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
> {
> return 0;
> }
>
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
next prev parent reply other threads:[~2020-12-09 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 20:15 [PATCH] usb: cdns3: Fixed kernel test robot warning Souptick Joarder
2020-12-09 21:12 ` Randy Dunlap [this message]
2020-12-10 5:30 ` Pawel Laszczak
2020-12-10 6:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae8cd88c-ea5d-a045-c6cd-2579a55f88d2@infradead.org \
--to=rdunlap@infradead.org \
--cc=a-govindraju@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).