Re: [PATCH] usb: cdns3: attempt to fix Kconfig dependencies

Arnd Bergmann
2026-04-03T08:40:01Z

On Fri, Apr 3, 2026, at 09:50, Peter Chen (CIX) wrote:
> On 26-04-02 16:09:55, Arnd Bergmann wrote:
>> ---
>> TBH, I would be more comfortable with reverting 6076388ca1ed altogether
>> and asking for a new version with the proper fixups included along
>> with more testing for the next merge window.
>
> It depends on Greg, I am okay for both ways. If Greg reverts the patch,
> I will do below improvements and adapts for most of your changes for v3
> patch.
>
> cdns-usb-common.ko is a libary, and no USB/GADGET dependency, could builds in.
> ├── core.o
> └── drd.o
>
> cdns3-host.ko -> depends on USB/XHCI（it is m when USB = m
> cdns3.ko (gadget) -> depends on USB_GADGET
> cdnsp.ko (gadget) -> depends on USB_GADGET
> cdns3-plat.ko -> assign host_init/gadget_init function pointer

This all sounds good. Ideally cdns3-plat.ko would also lose the
dependency on cdns3.ko/cdnsp.ko

>> @@ -10,12 +11,24 @@ config USB_CDNS_SUPPORT
>>
>> config USB_CDNS_HOST
>> bool
>> + depends on USB=y || USB=USB_CDNS_SUPPORT
>> +
>> +config CONFIG_USB_CDNS_PLATFORM
>
> %s/CONFIG_USB_CDNS_PLATFORM/USB_CDNS_PLATFORM

Oh, this means my patch did not actually work at all, and my testing
was pointless. I've fixed that now in my randconfig tree to see
if anything else comes up.

Arnd