Re: [PATCH] usb: typec: mux: ps883x: Power the retimer off when not in use

[Anthony Ruhier <aruhier@mailbox.org>]

On Mon, Apr 20, 2026 at 01:40:28PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> When there's nothing going through the retimer, there's no reason to
> keep it online. Put it in reset when possible to save power.
>
> Also, remove the register cache-compare optimization as it makes little
> sense now that the chip resets during almost all transitions and
> tracking the validity of that cache becomes a headache.
>
> Suggested-by: Jack Pham <jack.pham@oss.qualcomm.com>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> --
> Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>

Tested-by: Anthony Ruhier <aruhier@mailbox.org>

Thanks a lot for this patch, on a Yoga Slim 7x (x1e80100) the power saving is
huge. The laptop would rarely idle below 6.9W, now it reaches 4.6W (same 7.0.1
kernel, the only difference is this patch). Screen off, the laptop was idling
at 3.5W, now it reaches 2W.

I tested that DP-alt and USB-C devices continued to work well with this patch,
and it works as expected.

--
Anthony Ruhier