From: Andrew Lunn <andrew@lunn.ch>
To: Birger Koblitz <mail@birger-koblitz.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jianhui Xu <neuromoments@gmail.com>
Subject: Re: [PATCH net-next v8 06/15] ax88179_178a: Add HW support for AX179A-based chips
Date: Mon, 31 Aug 2026 16:30:26 +0200 [thread overview]
Message-ID: <af3f05e6-f5dc-459f-ac2a-5e7aedbf8ba3@lunn.ch> (raw)
In-Reply-To: <20260831-ax88179a-v8-6-de905f2ee426@birger-koblitz.de>
> +static void ax88179a_status(struct usbnet *dev, struct urb *urb)
> +{
> + struct ax88179_data *data = dev->driver_priv;
> + struct ax88179_int_data *event;
> + u32 link;
> +
> + if (urb->actual_length < 8)
> + return;
> +
> + event = urb->transfer_buffer;
> + le32_to_cpus((void *)&event->intdata1);
> +
> + link = (((__force u32)event->intdata1) & AX_INT_PPLS_LINK) >> 16;
> +
> + if (netif_carrier_ok(dev->net) != link) {
phylink will not like this. It is supposed to be in control of the
carrier.
> + usbnet_link_change(dev, link, 1);
This also seems to change the carrier under some conditions.
> + phylink_mac_interrupt(data->phylink);
Is this not sufficient to make phylink change the carrier once the
status has been read from the PHY?
Andrew
next prev parent reply other threads:[~2026-08-31 14:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 9:58 [PATCH net-next v8 00/15] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 01/15] phylink: Add phylink_mac_interrupt Birger Koblitz
2026-08-31 14:15 ` Andrew Lunn
2026-08-31 9:58 ` [PATCH net-next v8 02/15] phylib: Add support for PHYs with broken forced mode Birger Koblitz
2026-08-31 14:21 ` Andrew Lunn
2026-08-31 9:58 ` [PATCH net-next v8 03/15] ax88179_178a: Fix endianness of pause watermark register Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 04/15] ax88179_178a: Split driver into library and device specific code Birger Koblitz
2026-08-31 14:22 ` Andrew Lunn
2026-08-31 9:58 ` [PATCH net-next v8 05/15] ax88179_178a: Add netdev2data() convenience function Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 06/15] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
2026-08-31 14:30 ` Andrew Lunn [this message]
2026-08-31 16:03 ` Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 07/15] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 08/15] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 09/15] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
2026-08-31 9:58 ` [PATCH net-next v8 10/15] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
2026-08-31 9:59 ` [PATCH net-next v8 11/15] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
2026-08-31 14:32 ` Andrew Lunn
2026-08-31 9:59 ` [PATCH net-next v8 12/15] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
2026-08-31 9:59 ` [PATCH net-next v8 13/15] ax88179_178a: Update driver name and information Birger Koblitz
2026-08-31 9:59 ` [PATCH net-next v8 14/15] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
2026-08-31 9:59 ` [PATCH net-next v8 15/15] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz
2026-08-31 14:38 ` Andrew Lunn
2026-08-31 17:28 ` Birger Koblitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af3f05e6-f5dc-459f-ac2a-5e7aedbf8ba3@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mail@birger-koblitz.de \
--cc=netdev@vger.kernel.org \
--cc=neuromoments@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox