From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 312E21E98EF; Wed, 20 May 2026 14:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779285685; cv=none; b=i9+E2eT+r7U6IgZ/bMaBasdO+O+fJxNoIJ3YIfKdgRdkYBw31AiG+d9LXoO9t2CViC1m+pHeKT0WkCS1MgQanIkTcsCYNullsfXlipQJfW+au0w14HNqUsqrUMBYrfVpvL/LJoMbMSGmqAFm6yi+EJGJwAxt8D3n72JfscTxLrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779285685; c=relaxed/simple; bh=wKK0Wrbgy4JXaxSTsV126sf0+qlWK17VZao9y951WYE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eKQvVv85HySPrF4LidZXLSMikM0MuCHLScoh8Ir5Ni0e3DylhhLROXpM/rs1KfIYAhF2kRSpm8Wk2hjUVIaHTlcttudgBkmvT+VFEbRGzlYBlbBtxM0HKQmbWGSwFDJPoL9EAJtC/Hu/3nVbBsq9BQ4TyXUnU3IAeP7Qdp9XfrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZcOfMHO/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZcOfMHO/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA30B1F000E9; Wed, 20 May 2026 14:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779285682; bh=260mtSoIvf3fImaRDam0Pe5yLIS8ERuEV3CX2QQ6MGY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ZcOfMHO/0TCan5B9Rr2Chgu4mkBpIOiYteEIn9MPHwcVjQYJfzdPbCrcVXih3yGgu xKwkPb6zNmTGIe8gGMA4hVHZ8ruORDzfdWt8RsS2JsHpy5v+geXHbC6+YMZccpoKhK zstc/QQP1KkFoUN/O+0B0QbdPspKwaeep9Jzw0mKrs58hj9DskBxSIwUeA7iSxHSbV BEGqm7VXJh5KABWuYcCuJsuIYnmrdnlhL8dHv2WHsdnjod1xB2/rtxwAL8je5maKab ij7b3gcC1aIRftptjWY97xzXOxyrKsScBpMwBInzTFWaLSy22HImgY0aIg1be+5bDc dy1kkYcgnGOrQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wPhU8-00000002pbn-1gtj; Wed, 20 May 2026 16:01:20 +0200 Date: Wed, 20 May 2026 16:01:20 +0200 From: Johan Hovold To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] USB: serial: keyspan: fix missing indat transfer sanity check Message-ID: References: <20260520101230.657426-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520101230.657426-1-johan@kernel.org> On Wed, May 20, 2026 at 12:12:30PM +0200, Johan Hovold wrote: > Add the missing sanity check on the size of usa49wg indat transfers to > avoid parsing stale or uninitialised slab data. > > Fixes: 0ca1268e109a ("USB Serial Keyspan: add support for USA-49WG & USA-28XG") > Cc: stable@vger.kernel.org # 2.6.23 > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/keyspan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c > index 46448843541a..a267bc51afc1 100644 > --- a/drivers/usb/serial/keyspan.c > +++ b/drivers/usb/serial/keyspan.c > @@ -1187,6 +1187,10 @@ static void usa49wg_indat_callback(struct urb *urb) > len = 0; > > while (i < urb->actual_length) { > + if (urb->actual_length - i < 3) { > + dev_warn_ratelimited(&serial->dev, "malformed indat packet\n"); This dev_printk was a last minute addition before submitting which I apparently failed to compile test. This should have been &serial->interface->dev (or &urb->dev->dev). Will fix up when applying. > + break; > + } > > /* Check port number from message */ > if (data[i] >= serial->num_ports) { Johan