Linux USB
 help / color / mirror / Atom feed
From: Bjorn Andersson <andersson@kernel.org>
To: Akash Kumar <akash.kumar@oss.qualcomm.com>
Cc: Elson Serrao <elson.serrao@oss.qualcomm.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-usb@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: lemans: Enable eud support
Date: Wed, 13 May 2026 14:12:46 -0500	[thread overview]
Message-ID: <agTMzwEX1Nw-dZht@baldur> (raw)
In-Reply-To: <20260512091422.1395490-1-akash.kumar@oss.qualcomm.com>

On Tue, May 12, 2026 at 02:39:26PM +0530, Akash Kumar wrote:
> Add the EUD controller node in lemans.dtsi and update the USB HS
> endpoint routing on lemans-evk to pass through EUD instead of linking
> the connector directly to usb_0_dwc3_hs.
> 
> Wire the OF graph endpoints between the connector, EUD and DWC3 HS
> controller to enable the EUD path on lemans EVK.
> 
> This change is part of series "Improve Qualcomm EUD driver and
> platform support" and has been validated on the Qualcomm Dragonwing platform
> (RB8 board), confirming successful OpenOCD connectivity to the EUD
> interface. For detailed usage instructions, refer to Qualcomm’s Linux
> kernel debugging guide:
> https://docs.qualcomm.com/bundle/publicresource/topics/80-70020-12/debugging_linux_kernel.html#debug-using-openocd
> 
> Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>

Is this based on the work by Elson at
https://lore.kernel.org/all/20260501170635.2641748-1-elson.serrao@oss.qualcomm.com/#t
?

Help Elson to conclude (get merged) his efforts by code reviewing and
adopting the improved bindings before reposting this.

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/lemans-evk.dts | 12 ++++++++++--
>  arch/arm64/boot/dts/qcom/lemans.dtsi    | 26 +++++++++++++++++++++++++
>  2 files changed, 36 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> index c665db6a4595..96d316867c0e 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> @@ -55,7 +55,7 @@ port@0 {
>  				reg = <0>;
>  
>  				usb0_con_hs_ep: endpoint {
> -					remote-endpoint = <&usb_0_dwc3_hs>;
> +					remote-endpoint = <&eud_con>;
>  				};
>  			};
>  
> @@ -510,6 +510,14 @@ queue3 {
>  	};
>  };
>  
> +&eud_ep {
> +	remote-endpoint = <&usb_0_dwc3_hs>;
> +};
> +
> +&eud_con {
> +	remote-endpoint = <&usb0_con_hs_ep>;
> +};
> +
>  &gpi_dma0 {
>  	status = "okay";
>  };
> @@ -985,7 +993,7 @@ &usb_0 {
>  };
>  
>  &usb_0_dwc3_hs {
> -	remote-endpoint = <&usb0_con_hs_ep>;
> +	remote-endpoint = <&eud_ep>;
>  };
>  
>  &usb_0_dwc3_ss {
> diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
> index fe6e76351823..a8ab11681476 100644
> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
> @@ -4003,6 +4003,32 @@ opp-384000000 {
>  			};
>  		};
>  
> +		eud: eud@88e1000 {
> +			compatible = "qcom,sc7280-eud", "qcom,eud";
> +			reg = <0 0x88e1000 0 0x2000>,
> +				<0 0x88e3000 0 0x1000>;
> +			interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +			port@0 {
> +					reg = <0>;
> +
> +					eud_ep: endpoint {
> +					};
> +			};
> +
> +				port@1 {
> +					reg = <1>;
> +
> +					eud_con: endpoint {
> +					};
> +				};
> +			};
> +		};
> +
>  		usb_0_hsphy: phy@88e4000 {
>  			compatible = "qcom,sa8775p-usb-hs-phy",
>  				     "qcom,usb-snps-hs-5nm-phy";
> -- 
> 2.43.0
> 
> base-commit: https://lore.kernel.org/all/20260501170635.2641748-1-elson.serrao@oss.qualcomm.com/
> change-id: Improve Qualcomm EUD driver and platform support

      parent reply	other threads:[~2026-05-13 19:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  9:09 [PATCH] arm64: dts: qcom: lemans: Enable eud support Akash Kumar
2026-05-13 14:31 ` Dmitry Baryshkov
2026-05-13 19:12 ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agTMzwEX1Nw-dZht@baldur \
    --to=andersson@kernel.org \
    --cc=akash.kumar@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=elson.serrao@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox