Re: [PATCH 3/3] usb: typec: tcpci_rt1711h: add low power mode support

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

Hi,

I'm sorry to keep you waiting.

On Mon, May 18, 2026 at 05:15:14PM +0800, cy_huang@richtek.com wrote:
> From: Lucas Tsai <lucas_tsai@richtek.com>
> 
> Add low power mode support,
> add the op to enter and exit low power mode,
> this mode reduce RT1711H/RT1715 VDD Iq to 1 of 10,

What is VDD Iq?

> while disabling VBUS detection and PD BMC
> but keeping CC detection and not affecting DRP toggling.
> 
> Signed-off-by: Lucas Tsai <lucas_tsai@richtek.com>
> ---
>  drivers/usb/typec/tcpm/tcpci_rt1711h.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> index 4b3e4e22a82e..48d6a6823ab9 100644
> --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> @@ -20,6 +20,7 @@
>  
>  #define RT1711H_PHYCTRL1	0x80
>  #define RT1711H_PHYCTRL2	0x81
> +#define RT1711H_BMCCTRL		0x90
>  
>  #define RT1711H_RTCTRL4		0x93
>  /* rx threshold of rd/rp: 1b0 for level 0.4V/0.7V, 1b1 for 0.35V/0.75V */
> @@ -254,6 +255,18 @@ static int rt1711h_start_drp_toggling(struct tcpci *tcpci,
>  	return 0;
>  }
>  
> +static void rt1711h_set_low_power_mode(struct tcpci *tcpci,
> +				       struct tcpci_data *tdata, bool enable)
> +{
> +	int ret;
> +	struct rt1711h_chip *chip = tdata_to_rt1711h(tdata);
> +
> +	ret = rt1711h_write8(chip, RT1711H_BMCCTRL, enable ? 0x08 : 0x07);
> +	if (ret < 0)
> +		dev_err(chip->dev, "%s lpm fail(%d)\n",
> +			enable ? "enter" : "exit", ret);
> +}

Why couldn't this just be done in the PM suspend and resume
callbacks for this driver?

Br,

-- 
heikki