Re: [PATCH] Revert "usb: typec: mux: avoid duplicated mux switches"

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Sat, May 30, 2026 at 10:20:22AM +0200, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> 
> This reverts commit b145c3f29d62f71cc9d2d714e2d4ae4c8d3f863d.
> 
> The deduplication logic appears to cause issues with separate
> SBU muxes. The mode-switch call on these (like gpio-sbu-mux)
> never appeared, so no successful mode-switch happened. The more
> high-end Parade PS883X redrivers are not affected due to being
> retimer-switch. The revert fixes dp altmode mode-switch for both.
> 
> Tested on:
>   Lenovo Thinkbook 16 G7 QOY
>   Lenovo Ideapad 5 2in1 14Q8X9
>   Microsoft Windows Dev Kit 2023 (Blackrock)
>   Lenovo Thinkpad T14s G6
> 
> Fixes: b145c3f29d62 ("usb: typec: mux: avoid duplicated mux switches")
> 
> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/mux.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c
> index db5e4a4c0a996..9b908c46bd7df 100644
> --- a/drivers/usb/typec/mux.c
> +++ b/drivers/usb/typec/mux.c
> @@ -275,9 +275,7 @@ static int mux_fwnode_match(struct device *dev, const void *fwnode)
>  static void *typec_mux_match(const struct fwnode_handle *fwnode,
>  			     const char *id, void *data)
>  {
> -	struct typec_mux_dev **mux_devs = data;
>  	struct device *dev;
> -	int i;
>  
>  	/*
>  	 * Device graph (OF graph) does not give any means to identify the
> @@ -293,14 +291,6 @@ static void *typec_mux_match(const struct fwnode_handle *fwnode,
>  	dev = class_find_device(&typec_mux_class, NULL, fwnode,
>  				mux_fwnode_match);
>  
> -	/* Skip duplicates */
> -	for (i = 0; i < TYPEC_MUX_MAX_DEVS; i++)
> -		if (to_typec_mux_dev(dev) == mux_devs[i]) {
> -			put_device(dev);
> -			return NULL;
> -		}
> -
> -
>  	return dev ? to_typec_mux_dev(dev) : ERR_PTR(-EPROBE_DEFER);
>  }
>  
> @@ -326,8 +316,7 @@ struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
>  		return ERR_PTR(-ENOMEM);
>  
>  	count = fwnode_connection_find_matches(fwnode, "mode-switch",
> -					       (void **)mux_devs,
> -					       typec_mux_match,
> +					       NULL, typec_mux_match,
>  					       (void **)mux_devs,
>  					       ARRAY_SIZE(mux_devs));
>  	if (count <= 0) {
> 
> ---
> base-commit: 7da7f07112610a520567421dd2ffcb51beaefbcc
> change-id: 20260530-typc-mux-modeset-e5f8a38a100c
> 
> Best regards,
> -- 
> Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> 

-- 
heikki