From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BD4C3F412C; Fri, 5 Jun 2026 12:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780663903; cv=none; b=ulzetWvl6qQo2TP4YbBAayRP7keDY04cdlPJoWsD0bNmttTnmvjocy3ynZOEsgCosdLmg9ZLOAA9LDWl/vCO88Vmm+BaKoI0FMHqe2fkUO/PnEvOIO6/KRtbwBV6XGJNbbgCG5OhC++OLPK+wsUBONKuEJcDI6dMO9CE6z/Lay4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780663903; c=relaxed/simple; bh=+Z7fkGLCJoGEOW8BWuJGCF5uNojahF7laTSAwAS/N3w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BidDEi7W5QGq6xmGU/F8Q0l0h52qclwlADZzza/IjH5DEbJmVXXTIBflmUyvTEpyKY3fA3N5kZX5kcEgg/KC0qpeQ3iBnZ4IiI7pwLjOoXkgI6MbzITsc+5Zs3JMjCY0hiGSe+xYTZWmvONn7a/u+pxaZ0yd4AwN2dlo343HyyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KYOmgJ+Q; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KYOmgJ+Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780663900; x=1812199900; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+Z7fkGLCJoGEOW8BWuJGCF5uNojahF7laTSAwAS/N3w=; b=KYOmgJ+QfQi5tpzkTHW2y82qWaMbC8Fmhwgi5EMPDS7302oYP3mXkpOe w7Ac6yMffrm8XS7Gq8TfP3GW5vurhf+XFYOavG8gq6yIW785a/trfZWNT 1w7Obtd+zlQTKC0xGu6r149Tfpv3YQExa/87BV3DoW9JkUV4ALKuBgNUr LyP/s66e/mznB11KrUlJwDbDp0xLS+4KjQn3YeaUrI2gCT+C+EA9DL4N2 SPAaeUBUbPDj2EADWlheagmtnYOwF4PefkoUqfTPP3wlU4ZG2Wb//TWk2 qyilNL5DY3QabWlKyHUzQnrvwj5lzYZB0DhotUvrz4hlxAskPveptk09x A==; X-CSE-ConnectionGUID: 6/cggjV8RUGbTAHIT79G2A== X-CSE-MsgGUID: icUCUiHjQkyxDVrELcAVpA== X-IronPort-AV: E=McAfee;i="6800,10657,11807"; a="81403407" X-IronPort-AV: E=Sophos;i="6.24,188,1774335600"; d="scan'208";a="81403407" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 05:51:38 -0700 X-CSE-ConnectionGUID: 8UYQKWyNSLSmZbmHhYMM2Q== X-CSE-MsgGUID: FID66aKKRv25llgzYSd8vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,188,1774335600"; d="scan'208";a="282917623" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa001.jf.intel.com with ESMTP; 05 Jun 2026 05:51:28 -0700 Received: by black.igk.intel.com (Postfix, from userid 1008) id C960095; Fri, 05 Jun 2026 14:51:26 +0200 (CEST) Date: Fri, 5 Jun 2026 15:51:22 +0300 From: Heikki Krogerus To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Greg Kroah-Hartman , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Adrien Grassein , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Tomi Valkeinen , Bjorn Andersson , Konrad Dybcio , Pengyu Luo , Nikita Travkin , Yongxing Mou , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH RESEND v3 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Message-ID: References: <20260513-hpd-irq-events-v3-0-086857017f16@oss.qualcomm.com> <20260513-hpd-irq-events-v3-1-086857017f16@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513-hpd-irq-events-v3-1-086857017f16@oss.qualcomm.com> On Wed, May 13, 2026 at 09:23:21PM +0300, Dmitry Baryshkov wrote: > The DisplayPort standard defines a special kind of events called IRQ. > These events are used to notify DP Source about the events on the Sink > side. It is extremely important for DP MST handling, where the MST > events are reported through this IRQ. > > In case of the USB-C DP AltMode there is no actual HPD pulse, but the > events are ported through the bits in the AltMode VDOs. > > Extend the drm_connector_oob_hotplug_event() interface and report IRQ > events to the DisplayPort Sink drivers. > > Signed-off-by: Dmitry Baryshkov The displayport altmode looks okay to me. FWIW: Acked-by: Heikki Krogerus > --- > drivers/gpu/drm/drm_connector.c | 5 ++++- > drivers/usb/typec/altmodes/displayport.c | 15 +++++++++++---- > include/drm/drm_connector.h | 19 ++++++++++++++++++- > 3 files changed, 33 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 47dc53c4a738..edee9daccd51 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -3510,6 +3510,8 @@ struct drm_connector *drm_connector_find_by_fwnode(struct fwnode_handle *fwnode) > * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to connector > * @connector_fwnode: fwnode_handle to report the event on > * @status: hot plug detect logical state > + * @extra_status: additional information provided by the sink without changing > + * the HPD state (or in addition to such a change). > * > * On some hardware a hotplug event notification may come from outside the display > * driver / device. An example of this is some USB Type-C setups where the hardware > @@ -3520,7 +3522,8 @@ struct drm_connector *drm_connector_find_by_fwnode(struct fwnode_handle *fwnode) > * a drm_connector reference through calling drm_connector_find_by_fwnode(). > */ > void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode, > - enum drm_connector_status status) > + enum drm_connector_status status, > + enum drm_connector_status_extra extra_status) > { > struct drm_connector *connector; > > diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c > index 35d9c3086990..7182a8e2e710 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -189,7 +189,9 @@ static int dp_altmode_status_update(struct dp_altmode *dp) > } else { > drm_connector_oob_hotplug_event(dp->connector_fwnode, > hpd ? connector_status_connected : > - connector_status_disconnected); > + connector_status_disconnected, > + (hpd && irq_hpd) ? DRM_CONNECTOR_DP_IRQ_HPD : > + DRM_CONNECTOR_NO_EXTRA_STATUS); > dp->hpd = hpd; > sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd"); > if (hpd && irq_hpd) { > @@ -212,7 +214,10 @@ static int dp_altmode_configured(struct dp_altmode *dp) > */ > if (dp->pending_hpd) { > drm_connector_oob_hotplug_event(dp->connector_fwnode, > - connector_status_connected); > + connector_status_connected, > + dp->pending_irq_hpd ? > + DRM_CONNECTOR_DP_IRQ_HPD : > + DRM_CONNECTOR_NO_EXTRA_STATUS); > sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd"); > dp->pending_hpd = false; > if (dp->pending_irq_hpd) { > @@ -397,7 +402,8 @@ static int dp_altmode_vdm(struct typec_altmode *alt, > dp->data.conf = 0; > if (dp->hpd) { > drm_connector_oob_hotplug_event(dp->connector_fwnode, > - connector_status_disconnected); > + connector_status_disconnected, > + DRM_CONNECTOR_NO_EXTRA_STATUS); > dp->hpd = false; > sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd"); > } > @@ -827,7 +833,8 @@ void dp_altmode_remove(struct typec_altmode *alt) > > if (dp->connector_fwnode) { > drm_connector_oob_hotplug_event(dp->connector_fwnode, > - connector_status_disconnected); > + connector_status_disconnected, > + DRM_CONNECTOR_NO_EXTRA_STATUS); > > fwnode_handle_put(dp->connector_fwnode); > } > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index f83f28cae207..e05197e970d3 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -91,6 +91,22 @@ enum drm_connector_status { > connector_status_unknown = 3, > }; > > +/** > + * enum drm_connector_status_extra - additional events sent by the sink / > + * display together or in replacement of the HPD status changes. > + */ > +enum drm_connector_status_extra { > + /** > + * @DRM_CONNECTOR_NO_EXTRA_STATUS: No additional status reported. > + */ > + DRM_CONNECTOR_NO_EXTRA_STATUS, > + /** > + * @DRM_CONNECTOR_DP_IRQ_HPD: DisplayPort Sink has sent the > + * IRQ_HPD (either by the HPD short pulse or via the AltMode event). > + */ > + DRM_CONNECTOR_DP_IRQ_HPD, > +}; > + > /** > * enum drm_connector_registration_state - userspace registration status for > * a &drm_connector > @@ -2521,7 +2537,8 @@ drm_connector_is_unregistered(struct drm_connector *connector) > } > > void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode, > - enum drm_connector_status status); > + enum drm_connector_status status, > + enum drm_connector_status_extra extra_status); > const char *drm_get_connector_type_name(unsigned int connector_type); > const char *drm_get_connector_status_name(enum drm_connector_status status); > const char *drm_get_subpixel_order_name(enum subpixel_order order); > > -- > 2.47.3 -- heikki