From: Frank Li <Frank.li@oss.nxp.com>
To: Subasri S <subasris1210@gmail.com>
Cc: Peter Chen <peter.chen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Duncan Sands <duncan.sands@free.fr>,
Chas Williams <3chas3@gmail.com>,
Minas Harutyunyan <hminas@synopsys.com>,
Hans de Goede <hansg@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Badhri Jagan Sridharan <badhri@google.com>,
linux-usb@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: chipidea: Use %pe to print error pointers
Date: Mon, 20 Jul 2026 09:39:16 -0500 [thread overview]
Message-ID: <al4zFG3zCD5FJ7eB@SMW015318> (raw)
In-Reply-To: <20260719-usb-ptr_err_patchset-v1-1-85f7f2e4fefb@gmail.com>
On Sun, Jul 19, 2026 at 06:25:46PM +0530, Subasri S wrote:
>
> Use the %pe format specifier instead of %ld with PTR_ERR() for printing
> error pointers in imx_get_clks(), ci_hdrc_imx_probe(), and
> ci_get_platdata(). This prints symbolic error names (e.g. -ENOMEM)
> instead of errno numbers (e.g. -12), making error logs more readable.
>
> This patch fixes coccinelle reported warnings:
Avoid use words "This patch", just
Fix coccinelle reported warnings:
> ./chipidea/ci_hdrc_imx.c:452:5-12: WARNING: Consider using %pe to print PTR_ERR()
> ./chipidea/ci_hdrc_imx.c:468:5-12: WARNING: Consider using %pe to print PTR_ERR()
> ./chipidea/ci_hdrc_imx.c:222:4-11: WARNING: Consider using %pe to print PTR_ERR()
> ./chipidea/ci_hdrc_imx.c:222:24-31: WARNING: Consider using %pe to print PTR_ERR()
keep one is enough
> ./chipidea/core.c:684:4-11: WARNING: Consider using %pe to print PTR_ERR()
>
> Compile-tested only.
>
> Signed-off-by: Subasri S <subasris1210@gmail.com>
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 12 ++++++------
> drivers/usb/chipidea/core.c | 4 ++--
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 56d2ba824a0b..7bfe37ed68ae 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -218,8 +218,8 @@ static int imx_get_clks(struct device *dev)
> if (IS_ERR(data->clk)) {
> ret = PTR_ERR(data->clk);
> dev_err(dev,
> - "Failed to get clks, err=%ld,%ld\n",
> - PTR_ERR(data->clk), PTR_ERR(data->clk_ipg));
> + "Failed to get clks, err=%pe,%pe\n",
> + data->clk, data->clk_ipg);
> return ret;
> }
> /* Get wakeup clock. Not all of the platforms need to
> @@ -448,8 +448,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> pinctrl_hsic_idle = pinctrl_lookup_state(data->pinctrl, "idle");
> if (IS_ERR(pinctrl_hsic_idle)) {
> dev_err(dev,
> - "pinctrl_hsic_idle lookup failed, err=%ld\n",
> - PTR_ERR(pinctrl_hsic_idle));
> + "pinctrl_hsic_idle lookup failed, err=%pe\n",
> + pinctrl_hsic_idle);
> ret = PTR_ERR(pinctrl_hsic_idle);
> goto err_put;
> }
> @@ -464,8 +464,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> "active");
> if (IS_ERR(data->pinctrl_hsic_active)) {
> dev_err(dev,
> - "pinctrl_hsic_active lookup failed, err=%ld\n",
> - PTR_ERR(data->pinctrl_hsic_active));
> + "pinctrl_hsic_active lookup failed, err=%pe\n",
> + data->pinctrl_hsic_active);
> ret = PTR_ERR(data->pinctrl_hsic_active);
> goto err_put;
> }
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 07563be0013f..09db8a4eace2 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -680,8 +680,8 @@ static int ci_get_platdata(struct device *dev,
> /* no vbus regulator is needed */
> platdata->reg_vbus = NULL;
> } else if (IS_ERR(platdata->reg_vbus)) {
> - dev_err(dev, "Getting regulator error: %ld\n",
> - PTR_ERR(platdata->reg_vbus));
> + dev_err(dev, "Getting regulator error: %pe\n",
> + platdata->reg_vbus);
> return PTR_ERR(platdata->reg_vbus);
> }
> /* Get TPL support */
>
> --
> 2.43.0
>
>
next prev parent reply other threads:[~2026-07-20 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 12:55 [PATCH 0/3] usb: Use %pe to print error pointers Subasri S
2026-07-19 12:55 ` [PATCH 1/3] usb: chipidea: " Subasri S
2026-07-20 14:39 ` Frank Li [this message]
2026-07-19 12:55 ` [PATCH 2/3] usb: misc: " Subasri S
2026-07-19 12:55 ` [PATCH 3/3] usb: typec: " Subasri S
2026-07-20 11:38 ` Badhri Jagan Sridharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al4zFG3zCD5FJ7eB@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=3chas3@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=badhri@google.com \
--cc=duncan.sands@free.fr \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hminas@synopsys.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=subasris1210@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox