From: Johan Hovold <johan@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Jiale Yao <yaojiale02@163.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: serial: fix slab out-of-bounds read in interrupt URB callback
Date: Mon, 13 Jul 2026 15:55:10 +0200 [thread overview]
Message-ID: <alTuPh7hs1X-9lcA@hovoldconsulting.com> (raw)
In-Reply-To: <b775e3e1-af60-4291-a875-7185dc29769d@suse.com>
On Mon, Jul 13, 2026 at 12:44:17PM +0200, Oliver Neukum wrote:
> On 13.07.26 12:02, Johan Hovold wrote:
>
> > But looking at this again, the check should be split in two: one for the
> > struct usb_ctrlrequest header and one for the modem signal state (inside
> > the conditional).
>
> Not just should be. It must be.
Yeah, I meant "should" in the natural language sense of the word (not
"SHOULD" as in rfc2119).
> Doing the same check for both cases means that any of the, presumably
> allowed, messages the driver does not care about will terminate communication.
Indeed.
Johan
next prev parent reply other threads:[~2026-07-13 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 17:00 [PATCH] usb: serial: fix slab out-of-bounds read in interrupt URB callback Jiale Yao
2026-07-13 6:30 ` Greg KH
2026-07-13 10:02 ` Johan Hovold
2026-07-13 10:44 ` Oliver Neukum
2026-07-13 13:55 ` Johan Hovold [this message]
2026-07-13 9:56 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alTuPh7hs1X-9lcA@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=yaojiale02@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox