From: Julia Lawall <julia.lawall@inria.fr>
To: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
Cc: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/3] [Outreachy kernel] staging: qlge: qlge.h: add spaces around operators
Date: Mon, 9 Mar 2020 14:24:52 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2003091424150.4721@hadrien> (raw)
In-Reply-To: <3a471ee901679659280d420549610b12e9efcdf6.1583759118.git.payalskshirsagar1234@gmail.com>
On Mon, 9 Mar 2020, Payal Kshirsagar wrote:
> Add spaces around operators cleanup reported by checkpatch.
This is too much for one sentence.
Add spaces around operators. Cleanup suggested by checkpatch.
julia
>
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> drivers/staging/qlge/qlge.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
> index 66641edff6b5..4ef8dae3d7a0 100644
> --- a/drivers/staging/qlge/qlge.h
> +++ b/drivers/staging/qlge/qlge.h
> @@ -59,7 +59,7 @@
> #define MAX_CQ 128
> #define DFLT_COALESCE_WAIT 100 /* 100 usec wait for coalescing */
> #define MAX_INTER_FRAME_WAIT 10 /* 10 usec max interframe-wait for coalescing */
> -#define DFLT_INTER_FRAME_WAIT (MAX_INTER_FRAME_WAIT/2)
> +#define DFLT_INTER_FRAME_WAIT (MAX_INTER_FRAME_WAIT / 2)
> #define UDELAY_COUNT 3
> #define UDELAY_DELAY 100
>
> @@ -1367,7 +1367,7 @@ struct tx_ring_desc {
> struct tx_ring_desc *next;
> };
>
> -#define QL_TXQ_IDX(qdev, skb) (smp_processor_id()%(qdev->tx_ring_count))
> +#define QL_TXQ_IDX(qdev, skb) (smp_processor_id() % (qdev->tx_ring_count))
>
> struct tx_ring {
> /*
> @@ -1792,7 +1792,7 @@ struct ql_reg_dump {
>
> /* segment 34 */
> struct mpi_coredump_segment_header ets_seg_hdr;
> - u32 ets[8+2];
> + u32 ets[8 + 2];
> };
>
> struct ql_mpi_coredump {
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/3a471ee901679659280d420549610b12e9efcdf6.1583759118.git.payalskshirsagar1234%40gmail.com.
>
next prev parent reply other threads:[~2020-03-09 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 13:13 [PATCH 0/3] [Outreachy kernel] staging: qlge: qlge.h: cleanup suggested by checkpatch Payal Kshirsagar
2020-03-09 13:13 ` [PATCH 1/3] [Outreachy kernel] staging: qlge: remove spaces before tabs and align code Payal Kshirsagar
2020-03-09 13:13 ` [PATCH 2/3] [Outreachy kernel] staging: qlge: qlge.h: add spaces around operators Payal Kshirsagar
2020-03-09 13:24 ` Julia Lawall [this message]
2020-03-09 13:13 ` [PATCH 3/3] [Outreachy kernel] staging: qlge: qlge.h: remove excess newlines Payal Kshirsagar
2020-03-09 13:18 ` [PATCH 0/3] [Outreachy kernel] staging: qlge: qlge.h: cleanup suggested by checkpatch Julia Lawall
[not found] ` <CAJyzNhno1e9enuSdAstwa_i03Xb5Sz4sQiadUukaADruQ2dGxw@mail.gmail.com>
2020-03-09 14:46 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2003091424150.4721@hadrien \
--to=julia.lawall@inria.fr \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=payalskshirsagar1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox