From: Johan Hovold <johan@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: serial: digi_accelport: fix crash on SPARC
Date: Tue, 4 Aug 2026 16:46:37 +0200 [thread overview]
Message-ID: <anH7TXZF_C7xa6q_@hovoldconsulting.com> (raw)
In-Reply-To: <20260804105150.576159-1-oneukum@suse.com>
On Tue, Aug 04, 2026 at 12:51:50PM +0200, Oliver Neukum wrote:
> The helper function cond_wait_interruptible_timeout_irqrestore()
> reenables interrupts. It does so by means of the flags saved
> by spin_lock_irqsave() in the caller.
> On SPARC these flags can be used only inside the same stack
> frame. Details can be found in
>
> https://www.kernel.org/pub/linux/kernel/people/rusty/kernel-locking/x467.html
>
> If the compiler decides to not inline the helper function,
> the kernel will crash on SPARC if the helper is executed.
I too had seen that comment about the messed up SPARC, but some years
back I looked into it and concluded that this hasn't been the case for a
very long time.
Specifically, the comment you refer to was removed from the in-tree
version of that document in 2004 after SPARC was fixed.
Johan
prev parent reply other threads:[~2026-08-04 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 10:51 [PATCH] usb: serial: digi_accelport: fix crash on SPARC Oliver Neukum
2026-08-04 14:46 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anH7TXZF_C7xa6q_@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox