Linux USB
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: gadget: stop propagating controller OF nodes
Date: Wed, 12 Aug 2026 16:10:53 +0200	[thread overview]
Message-ID: <anx-7aOxjC2Hinxu@hovoldconsulting.com> (raw)
In-Reply-To: <20260702145350.109509-1-johan@kernel.org>

On Thu, Jul 02, 2026 at 04:53:50PM +0200, Johan Hovold wrote:
> Some UDC drivers propagate the controller OF node to the gadget device
> but there are no (and has never been any) users of this as the
> devicetree binding and composite driver support was never merged. [1]
> 
> Drop the unused and incomplete support for OF node propagation which if
> ever needed should be handled by UDC core.
> 
> Note that this also avoids probe failures when reusing an OF node that
> describe resources like pinctrl that are managed by driver core (cf.
> commit 48ed32482c41 ("usb: gadget: aspeed: Fix probe regression")).
> 
> Link: https://lore.kernel.org/all/1340720833-781-1-git-send-email-aletes.xgr@gmail.com/ [1]
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> 
> This was something I stumbled over when fixing a couple of gadget device
> name leaks. This one applies on top of those fixes:
> 
> 	https://lore.kernel.org/all/20260702141536.90887-1-johan@kernel.org/

These fixes are now in 7.2-rc5 (and usb-next) so can this one be picked
up for 7.3?

Let me know if you prefer a resend.

>  drivers/usb/gadget/udc/aspeed-vhub/dev.c | 2 --
>  drivers/usb/gadget/udc/aspeed_udc.c      | 1 -
>  drivers/usb/gadget/udc/at91_udc.c        | 1 -
>  drivers/usb/gadget/udc/bcm63xx_udc.c     | 1 -
>  drivers/usb/gadget/udc/fsl_udc_core.c    | 3 ---
>  drivers/usb/gadget/udc/lpc32xx_udc.c     | 1 -
>  6 files changed, 9 deletions(-)

Johan

      reply	other threads:[~2026-08-12 14:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 14:53 [PATCH] USB: gadget: stop propagating controller OF nodes Johan Hovold
2026-08-12 14:10 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anx-7aOxjC2Hinxu@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox