Linux USB
 help / color / mirror / Atom feed
From: Lovekesh Solanki <lovekeshsolanki00@gmail.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Mathieu Fluhr <mathieu.fluhr@gmail.com>,
	 Michal Pecio <michal.pecio@gmail.com>,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	 linux-usb@vger.kernel.org, regressions@lists.linux.dev,
	stable@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Mario Limonciello <mario.limonciello@amd.com>,
	 Forest <forestix@gaga.casa>,
	Slavik Dev <developer.slavik@gmail.com>
Subject: Re: [REGRESSION] 6.12.36+: usb: hub: post-resume delayed work triggers > uncorrected MCE / data fabric sync flood on Threadripper 7970X > (bisected to aec11e5f9c45)
Date: Wed, 26 Aug 2026 23:41:09 +0530	[thread overview]
Message-ID: <ao8bM2SrASNh2u84@eggarch> (raw)
In-Reply-To: <d5a395f7-06ad-401a-b026-e975f620f017@linux.intel.com>

On Wed, Aug 26, 2026 at 04:40:14PM +0300, Mathias Nyman wrote:
> Roothub needs some time to settle as well, but 200ms might be excessive.
> 
> xHC can triggers wake (PME) when a connected USB3 device starts signalling wake,
> but port registers changes are not always visible to driver before link training
> between roothub and device is successful.
> 
> My educated guess is that 120ms should always be enough for the roothub.
> This is also the lecagy msleep() still apparently left in xhci resume
> to detect port changes in xhci runtime resume if there are USB3 devices.
> That msleep was supposed to be removed now that we got the hub changes.
> 
> This 120ms can probably be further tuned for roothub in some cases,
> especially if resume is due to userspace action instead of xHC wake signal (PME).
So the patch I sent above unintentionally brought the total hold from hub
and xhci side down to 120ms, which worked.

And the correct fix would be to bring USB_SS_PORT_U0_WAKE_TIME down to
120ms and clean up the msleep from xhci_resume?

I can prepare a patch that addresses both if you'd like.

Regards,
Lovekesh

  parent reply	other threads:[~2026-08-26 18:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23  9:55 Mathieu Fluhr
2026-08-23 10:12 ` Mathieu Fluhr
2026-08-23 10:15   ` [REGRESSION] 6.12.36+: usb: hub: post-resume delayed work triggers > uncorrected MCE / data fabric sync flood on Threadripper 7970X > (bisected to aec11e5f9c45) Mathieu Fluhr
2026-08-23 10:36     ` Thorsten Leemhuis
2026-08-23 11:44       ` Mathieu Fluhr
2026-08-23 16:10         ` Michal Pecio
2026-08-23 15:17       ` Lovekesh Solanki
2026-08-23 15:40         ` Michal Pecio
2026-08-23 17:05           ` Lovekesh Solanki
2026-08-24 19:37             ` Mathieu Fluhr
2026-08-24 22:09               ` Mario Limonciello
2026-08-25  8:57                 ` Mathieu Fluhr
2026-08-26  3:14                   ` Mario Limonciello
2026-08-26  6:27                     ` Mathieu Fluhr
2026-08-26 15:32                       ` Mario Limonciello
2026-08-26  6:59                     ` Michal Pecio
2026-08-25 10:15                 ` Lovekesh Solanki
2026-08-25 10:06               ` Lovekesh Solanki
2026-08-25 21:43                 ` Mathieu Fluhr
2026-08-26 12:35                   ` Lovekesh Solanki
2026-08-26 13:40                     ` Mathias Nyman
2026-08-26 16:03                       ` Mathieu Fluhr
2026-08-26 18:11                       ` Lovekesh Solanki [this message]
2026-08-27 19:34                         ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao8bM2SrASNh2u84@eggarch \
    --to=lovekeshsolanki00@gmail.com \
    --cc=developer.slavik@gmail.com \
    --cc=forestix@gaga.casa \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mathias.nyman@linux.intel.com \
    --cc=mathieu.fluhr@gmail.com \
    --cc=michal.pecio@gmail.com \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox