From: Johan Hovold <johan@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] USB: cdc-acm: fix racy TIOCMIWAIT implementation
Date: Mon, 7 Sep 2026 10:47:49 +0200 [thread overview]
Message-ID: <ap56NTVMq8GlbjmR@hovoldconsulting.com> (raw)
In-Reply-To: <e231a7e9-7aa9-40ea-8ac6-57855b4ac811@suse.com>
On Mon, Sep 07, 2026 at 10:17:38AM +0200, Oliver Neukum wrote:
> On 07.09.26 08:55, Johan Hovold wrote:
> > The wakeup condition needs to be checked after adding the task to the
> > waitqueue and updating the task state to avoid missing a racing modem
> > status update or disconnect.
>
> I am sorry, but in this case I have to ask:
> Isn't TIOCMIWAIT inherently racy against the hardware?
What do you mean?
Looking at the implementation again now, it seems further changes are
needed to fix the implementation, though. The completion handler should
not be updating old_count. That's for each TIOCMIWAIT to do.
Johan
next prev parent reply other threads:[~2026-09-07 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 6:55 [PATCH] USB: cdc-acm: fix racy TIOCMIWAIT implementation Johan Hovold
2026-09-07 8:17 ` Oliver Neukum
2026-09-07 8:47 ` Johan Hovold [this message]
2026-09-07 9:13 ` Johan Hovold
2026-09-07 9:50 ` Oliver Neukum
2026-09-07 10:01 ` Johan Hovold
2026-09-07 10:28 ` Oliver Neukum
2026-09-07 11:38 ` Johan Hovold
2026-09-07 12:46 ` Oliver Neukum
2026-09-07 13:03 ` Johan Hovold
2026-09-08 6:54 ` Oliver Neukum
2026-09-08 7:12 ` Johan Hovold
2026-09-08 9:23 ` Oliver Neukum
2026-09-11 6:57 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap56NTVMq8GlbjmR@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox