From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94D0342BC3D for ; Tue, 1 Sep 2026 15:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788277812; cv=none; b=DDkKfPS/gyZJCmSE/CP4pIUkffA6S8+vtUvp4J5nNKJEdOi7Z0KsSMChZnGxyBYM7pUhv3jUvPzG5bahymo617RlEYMW5Ky98pg3vMKFZM5eLN8uXjLAr05EH/GHDO/TK82iGQmUgJMcTqJFTohBTyR9/Ww/R04H1gE19Gni6TQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788277812; c=relaxed/simple; bh=ajyzEffsSBkOYLQIR3aRKBK1NS8kHj7P6PrDglE8xvk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JENCwie9SYD4TB8SvUVLFLQxWYSs2+MX0SDxdYRPLoE/PsnAm/pAxNujzaeoIyxRTwLifXF23/r2dZYekeBvRzGku4WA+luHf16qEFPEXMp5q7wit6v0X1Uem1WoHTE8X1gDjFHddkwqruCeKv1vw8mSC+1l/x47EYatfVmd3Uw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O+Ver7Lv; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O+Ver7Lv" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84e04df8c46so1450346b3a.2 for ; Tue, 01 Sep 2026 08:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788277811; x=1788882611; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gzaoCwMvhgrc258eCGx9+hCu2m0m8ZaOD9+JsPMrJD4=; b=O+Ver7LvAAalfLRKwzmexoL+t2ENXM8l9dNhVN+cGPN60oVqcqwqhh9ahQfnru1VS0 CAL5EMN4UV/78D9e4ixNeekvmCMFDqU8yCJV619iQb2nMeS66wZf+MMc5SYw+zMdlkUq b/mU3BhmbSPAZqH1jLWJy93FbbnErVrQ6BltVRyVSxmzS+Zayzy1iL+hoxm9pI/sWMGg CWMSxkNjjMHBy5spybeUkl0FwpcTYWB3DaWzh29JNX8ck6rx84hIVET2jPCuvxehCVoE U78yjuMGP3NrNmlbowE3YKrXZaMI/6m9qmDgqoPFWvP6ItAZCB/7DbwPbAUnSfSV4iui x4TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788277811; x=1788882611; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gzaoCwMvhgrc258eCGx9+hCu2m0m8ZaOD9+JsPMrJD4=; b=QS/bkYhkYKlrjLPVYkgHf73O3gu7xhdUZBqEqronZ3oWMCsesOlfYywVfArgZNRoc0 AhNUcnCaG91O2HSmI5JRSN7u/fTuKNW6qbgovegLB4C3UG8vvPOXl5zcyMP1bsx3ZVA7 sS642CGoOtdVW7aQR0Db+2JSzFAOww0CXFEJT0vl+I5A5G1UWw/HeTGVfPJJRDVwxOrG av5zdkdB23DMCqjB6c+m/qvH1KABX1p3wRQ4HRBATVr/LbeaK3fi+x9RRh7ulcj4rkZt 71rA5jBvcH3zjfRI6vGnal/oA3quov3TwGM0Am+VbRvvnUZo7B5iEP/O8JAjtZ2RXaSk opRg== X-Gm-Message-State: AFuF++lYPVJjOd74mLiu6e7AGknMELeK/1Ir27lG63RZHIacAuhAO99x 1DMmN30tH/7fsB0xPEIzng1tCb4x7L7oOMjq8pmPbGgT/7ce/a3XnK5h X-Gm-Gg: AR+sD11mJn5bE408QvRq/4Wrs+KUZ329oldeRVTswsvJw81Qjpsl3Ch9OCSR4E47uaD FPeVYwFy8ZOj8uvEkh9PgO7XAD8y/t2k9x5BezFdLQ5xmy7yy+qO4dSch1WzcvfXyg+ScABwVIX M08O2OiVL9qhIQ/+n4EnM2ME0d5FCc0mRZTWJmyGfgM+657O5Fjxu5Y8EY5Dq7Rh3EPHqTlIPBV 2CmUeiuwj/heATD+oqAEYFKRWzLlgPdFXwRx2kGjNx4oOEc0w4oVu7LkNxF17oyLhQJrABLYtVt yvGnNXF/2Lm2kQwTJKXZImHUq4AKIxEMbFRKlx6kZZutXF/0JVG+GxPAjWvP8MGOeOdDAYeq0BW iBWghckN1gbe2tvRWA7CfpX+fbNLBw7bqIi8wPuUtPYegu6u3M6Qffgtg6VCBoRWkCYu+To1rIa 9d+teAnXMdNV5JbCiYLv9ym8zd/JOpxgroz4Q6NxRAWfY8ycBoE6qcKT+SczEqolm+sEVGnNGLZ ilgq6403puNqa1BHi2ZQs+/UlPznw== X-Received: by 2002:a05:6a00:f0c:b0:852:5f99:1866 with SMTP id d2e1a72fcca58-8562514cfb6mr56762417b3a.0.1788277810606; Tue, 01 Sep 2026 08:50:10 -0700 (PDT) Received: from localhost ([2409:40c4:10ef:9c41:92dd:ad43:5cf5:f6a]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-85dc0e01472sm105067b3a.55.2026.09.01.08.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 08:50:09 -0700 (PDT) Date: Tue, 1 Sep 2026 21:20:01 +0530 From: Lovekesh Solanki To: Mathias Nyman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Pecio , Mathieu Fluhr , Mario Limonciello , Thorsten Leemhuis , regressions@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH 2/2] xhci: drop 120ms U3 LFPS wake retry wait from runtime resume Message-ID: References: <20260831190349.29590-1-lovekeshsolanki00@gmail.com> <20260831190349.29590-2-lovekeshsolanki00@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 01, 2026 at 03:53:47PM +0300, Mathias Nyman wrote: > I looked into this again and remember now why we didn't remove the msleep(120) > earlier. > > If we want the hub driver to keep us awake to detect delayed port activity, > then we need to wake the (root) hub driver in xhci resume. > > That means always calling usb_hcd_resume_root_hub() in runtime resume cases where > resume is caused by usb device remote wake. (xHCI PME# in PCI case), even if there > isn't any port activity yet. Got it, thanks for the explanation. > We don't currently check if runtime resume is caused by xHC PME# wake in the xhci-pci > driver. Not sure if there's a driver api for it. > Instead we in resume sleep for 120ms if there exists connected and suspended USB3 > devices without port activity, and then check again. > > This msleep(120) is unnecessary if runtime resume was caused by userspace instead > of usb device initiated wake (seen as PME for PCI hosts) So the better implementation will cross into the PCI side, are there any plans to implement that? Or any interest in it at all that you know of? > Probably best to just take Patch 1/1 and look at this xhci resume part separately. Do I need to resend the 1/2 Patch independently now that this one is dropped? Or it'll be taken as is..? I'm still figuring the process out. Thanks, Lovekesh