From: Dan Carpenter <error27@gmail.com>
To: Frank.Li@oss.nxp.com
Cc: Frank Li <Frank.Li@nxp.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>,
Karol Wachowski <karol.wachowski@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Matthew Brost <matthew.brost@intel.com>,
Thomas Hellstrom <thomas.hellstrom@linux.intel.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Alex Elder <elder@kernel.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Guan-Yu Lin <guanyulin@google.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, netdev@vger.kernel.org,
imx@lists.linux.dev, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 1/1] PM: runtime: change stub pm_runtime_get_if_active() return 1 when !CONFIG_PM
Date: Thu, 29 Oct 2026 21:59:04 +0300 [thread overview]
Message-ID: <auOXeGVQG0UHeoQb@stanley.mountain> (raw)
In-Reply-To: <20261029163044.3062958-1-Frank.Li@oss.nxp.com>
On Thu, Oct 29, 2026 at 12:30:37PM -0400, Frank.Li@oss.nxp.com wrote:
> Pattern C: ret > 0 / ret <= 0 / ret != 1 checks -- FIXED
> drivers/usb/core/offload.c: checks (!= 1), old -EINVAL caused
> -EBUSY even with !CONFIG_PM. Fixed: now returns 1, proceeds.
> drivers/accel/ivpu/ivpu_job.c: drm_WARN_ON(<= 0), old -EINVAL
> spuriously triggered WARN. Fixed: 1 > 0, no warn.
> drivers/gpu/drm/i915/intel_runtime_pm.c: checks (<= 0), old
> -EINVAL triggered error path. Fixed: 1 > 0, correct path.
> drivers/accel/ivpu/ivpu_sysfs.c: (> 0), old skipped freq read.
> Fixed: proceeds correctly without CONFIG_PM.
> drivers/gpu/drm/xe/xe_pm.c: wraps (> 0), all xe callers
> (xe_bo.c, xe_shrinker.c, xe_vsec.c, xe_ggtt.c, xe_guc_ct.c,
> xe_pxp.c) now correctly treat !CONFIG_PM as active.
> drivers/net/ipa/ipa_smp2p.c: power_on = (> 0), now correctly true.
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c: (> 0), now correctly
> executes stall register update.
> drivers/staging/media/ipu7/ipu7-buttress.c: active (<= 0) early
> return now skipped, correctly proceeds.
Pattern C is mostly bugs so this patch should have a Fixes tag since
it fixes bugs.
regards,
dan carpenter
prev parent reply other threads:[~2026-10-29 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 16:30 [PATCH 1/1] PM: runtime: change stub pm_runtime_get_if_active() return 1 when !CONFIG_PM Frank.Li
2026-10-29 16:43 ` sashiko-bot
2026-10-29 18:11 ` Alex Elder
2026-10-29 18:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auOXeGVQG0UHeoQb@stanley.mountain \
--to=error27@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=airlied@gmail.com \
--cc=andrzej.kacprowski@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=guanyulin@google.com \
--cc=imx@lists.linux.dev \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=joro@8bytes.org \
--cc=karol.wachowski@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathias.nyman@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=rodrigo.vivi@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tursulin@ursulin.net \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox