Linux USB
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc2: wa for isoc packet tx fifo flush at periodic frame boundary
Date: Wed, 4 Nov 2026 01:28:59 +0000	[thread overview]
Message-ID: <auqF48Lk6EEyF2mV@vbox> (raw)
In-Reply-To: <20261014-dwc2-fix-wa-isoc-v1-1-f261ce0852bd@foss.st.com>

On Wed, Oct 14, 2026, Fabrice Gasnier wrote:
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 102169b40419..9f02075ba15b 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -3449,6 +3449,19 @@ void dwc2_hsotg_core_init_disconnected(struct dwc2_hsotg *hsotg,
>  	if (hsotg->params.ipg_isoc_en)
>  		dcfg |= DCFG_IPG_ISOC_SUPPORDED;
>  
> +	/*
> +	 * WA for Device Flushes Ongoing ISOC IN Packet at End-of-Periodic-Frame Boundary.
> +	 * Once passed the end of periodic frame, and the controller is transmitting an
> +	 * ISOC IN packet, the device fulshes the transmit FIFO. Tune periodic frame

s/fulshes/flushes/

> +	 * interval to 95% instead of 80% to avoid it.
> +	 */
> +	if (using_desc_dma(hsotg) &&
> +	    (hsotg->hw_params.snpsid >= DWC2_CORE_REV_2_70a &&
> +	     hsotg->hw_params.snpsid <= DWC2_CORE_REV_4_00a)) {

This also affects the HS and FS IOT cores 1.00a. Please add
DWC2_HS_IOT_REV_1_00a and DWC2_FS_IOT_REV_1_00a here.

> +		dcfg &= ~DCFG_PERFRINT_MASK;
> +		dcfg |= ((DCFG_PERFRINT_LIMIT << DCFG_PERFRINT_SHIFT) & DCFG_PERFRINT_MASK);

This can just be:
		dcfg |= DCFG_PERFRINT(DCFG_PERFRINT_LIMIT);

This conflicts with your "[PATH] dwc2: fix fifo reinit in
dwc2_hsotg_core_init_disconnected". Please send both as a series and add
Cc stable.

Thanks,
Thinh

      parent reply	other threads:[~2026-11-04  1:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  9:46 [PATCH] usb: dwc2: wa for isoc packet tx fifo flush at periodic frame boundary Fabrice Gasnier
2026-10-14  9:52 ` sashiko-bot
2026-11-04  1:28 ` Thinh Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auqF48Lk6EEyF2mV@vbox \
    --to=thinh.nguyen@synopsys.com \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox