From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.169 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793898336; b=YmfeE6cVFAVzwjZhV9EICMqJ+NShGo050OCExCAmW4u/iboH5M0Wz1gDDrqVQE4UAN4Q MlZPZ3xuQhgV42MsAxgiLiAEHXLQitMBqtyIYjIQTUsX8obz2scsRlm7d1p/C9Ja47tNw sedzBR2ajQMhOI3P3BgDaQ9lY0qjm7N2FPo0xMmf5JnaGQ+fxCqpy44G0ZxeF9MJ3TC0B AOvlhwQ1OqdSND1F3lJWfVhVJFp1TyLazimthEIdTZUqV40vdKIiT8+iMLkTVnNg4CxIJ LWgMkgqmvtcbbGxZYG2iU+BuaRYmWeRXrtzrDiJJETc5MnlGdfjU0TsDrcbL2wRMesA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793898336; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=t7Mrcemi56BF5iayGoRjCtdHcIwbWskinGPPufbe/aA=; b=eJE/yaSkNe4c5gIL8ztZQrQt3QrwqkfNexUjBfxyElSL7ETcpRKPTMHOWWXNI3Op3/EO TjeWQoP1lViXp+tGZp0UYCXVyHXb/P7rIvs2bcUljQBBj3nO+I66V81n5m/FTVukBA9Ji 1AHt4UK4J77vnULtq7erCqNJiowerXmRd9PM7tc27uR3D3f55uosan40+c/i40fUWxpZd E/DGHYUF2AAuDWEEVl2ictfekv0jkMKdRbzGIZ6LzSPFZADGS0e94c3ahT4mjOpk+ELmD YPUrnvRhD5ZIsn2RWrqT5eTkwWoNsei66muBAku63RaDoJYcmGAa9T1WahyEYYsqtvA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ezhGUhXo; arc=none smtp.remote-ip=74.125.82.169 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A33EA606A339 for ; Thu, 5 Nov 2026 17:05:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A33EA606A339 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ezhGUhXo Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-3645f0f3fcdso3516051eec.0 for ; Thu, 05 Nov 2026 09:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793898335; x=1794503135; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=t7Mrcemi56BF5iayGoRjCtdHcIwbWskinGPPufbe/aA=; b=ezhGUhXoIUl09y6+rx0VThMrADfNJzLtbjELvheIq2XUjEVn+F/n+Ri2C53TV9L6Aq JdGhkEmCnwmkPVTv0OB6x5RGwGBQJHUjt1KyKJv1eSBurgKo52RA3J8/QRIyxJZsDOQU n7s5HLJdofzUUsrlUP5HhN1OEHjO1pTWgNUtwsTp5+pkRYp1fI+C+uqlY+LxQRirvNrb Ex3MFhTRMHWMTtME2TIEuo7EsT/3ZplABIXud7NOWlPeo0lDAdVbld/IOwaCZ8vfz4uj z22wAGLVFJBUWinFMtheNWfoQbFjMbEjptQEjYgl4R/mPdYwQwSpcnETlWlj/Aj3CrCr m0dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793898335; x=1794503135; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t7Mrcemi56BF5iayGoRjCtdHcIwbWskinGPPufbe/aA=; b=eX7vn/MBC4nEaXS0yg1qPHKE4io3Y0smgfeIh8DGB0k+yADDUYYMcl3ePd/0bf45wY tiAtgcAYfbyGPqGTEI1gYoeAwyjWzSAm9bwlHIQfhxoe/q/uI9U3vwtYnUAG6ihCMLem KaiWE/XRrl1T1NdTq+mQDjB8zpl5QrUDu1kUgtpGasmTskMWT4uX3Hr+jjsnNYqB9UnY Fi9LiOMPWGD8LdNBARS0iUV12aH1kYHjbqbKoRfjXPhKy71FTQhhvjr8EEI5jLHQ8bhg 00DAcBXVqpj55M4w+8FqhCVZPKPKwrzDj8ggWgT+V4pVJJzdGDZnHDQZpjasACD7pGJw Zt/g== X-Forwarded-Encrypted: i=1; AKwUvBxXBYyLurZ3Y14c+k1oFc5uiHiTjVKViy/XSZ6RE78FggT0/KhBrBmUwu1z35ymarodz5cbEavm7KY=@vger.kernel.org X-Gm-Message-State: APuU4Z+FkjifjsHBMdMbODHASB8rbbGLJ87P971Zm3SCnACxCB0Cx3u5 T+Mmvc3B4efxgWOYPkM1ohueZYWdJ6b5X1v++iTnFamSqvXXCc38cRfj X-Gm-Gg: AYBFou0qf6DJxoLLPwg+0FD9m+ZC7Vhyoo8yY9S3V4CkqtLRAhwwUq73qoI3U8vNgoa m9CgC5Xa+gR3SihpLbhkksrhcjK7sDNhoCa+OSiAtopDloPTaOfkp4ozIrL303uzbAcFIxskPcb YXIT9j0IFFQxikuai9vfB4cuEgnXvtmx/pFkQojNe1WbQjY02kABYmoCTPAUKaHvkL5S7k7QM1z uP5ffHY1kkZAD+jXpR1q8IoXpl5bkpNHETA/eYeVQ5AoNC48rDvBQwh3h0c1X+x5kc3kqjtF+dn 48e2p1PrVMZS8+5QhjiDfmyt6xPsvLGYdE0bxROpItxoK7HDvKAFuyRwD2f+331/izt7ZpO0h/j 9LqZUsg9II2HBZOI+B0ovembaU59v/YmeHpmJzqf8zvTz74gLyIdFvd6IlLHSJQcfHPyDAMNV6k cio0316qm2755CLH9tZZnFzq3yQ477jphOSFnWKefbVLI4rsg1MeTI/jo+rG4COcxqRsZS4aAkO 5gYR802wnOf8d/y3LShZ2nbip/agJn4PgIUKOP9ur4OjOC7bYgI7PYALNX145jRWiUtgqi3ejsA TV2GzfjEFZxMngoI9ofB6qvY4V7V0aKaX4ofFcfOTYWT/xr/cVI8NLEBv+U/GejJtL/Yov3wbnF I9+04m7FDPjyxHZc= X-Received: by 2002:a05:7300:fa0d:b0:36d:7feb:8bd3 with SMTP id 5a478bee46e88-36d7feb8e1amr5835338eec.11.1793898334471; Thu, 05 Nov 2026 09:05:34 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:c8f4:b7d9:252f:4483]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36ca3989670sm23943795eec.25.2026.11.05.09.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 09:05:33 -0800 (PST) Date: Thu, 5 Nov 2026 09:05:29 -0800 From: Dmitry Torokhov To: Leon Romanovsky Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Berg , Jonathan Corbet , Shuah Khan , Randy Dunlap , Bjorn Helgaas , "Joerg Roedel (AMD)" , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , David Woodhouse , Lu Baolu , Johan Hovold , Eric Dumazet , Marcel Holtmann , Luiz Augusto von Dentz , Nipun Gupta , Nikhil Agarwal , Pieter Jansen van Vuuren , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, iommu@lists.linux.dev, Jason Gunthorpe Subject: Re: [PATCH 02/17] Input: serio - attach manual drivers through the driver core Message-ID: References: <20261105-device-trust-core-v1-0-1e536825b4eb@nvidia.com> <20261105-device-trust-core-v1-2-1e536825b4eb@nvidia.com> X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105-device-trust-core-v1-2-1e536825b4eb@nvidia.com> On Thu, Nov 05, 2026 at 01:42:15PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Manual serio binding connects a driver before driver core can admit the > device. A rejected binding therefore arrives after functional setup. > > Keep the port ID check and use device_driver_attach() for the existing bus > probe path. Driver core then serializes admission and handles probe failure > before publishing the binding. > > Signed-off-by: Leon Romanovsky > --- > drivers/input/serio/serio.c | 24 +++--------------------- > 1 file changed, 3 insertions(+), 21 deletions(-) > > diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c > index 54dd26249b027..604440244c1ca 100644 > --- a/drivers/input/serio/serio.c > +++ b/drivers/input/serio/serio.c > @@ -81,28 +81,10 @@ static int serio_match_port(const struct serio_device_id *ids, struct serio *ser > > static int serio_bind_driver(struct serio *serio, struct serio_driver *drv) > { > - int error; > - > - if (serio_match_port(drv->id_table, serio)) { > - > - serio->dev.driver = &drv->driver; > - if (serio_connect_driver(serio, drv)) { > - serio->dev.driver = NULL; > - return -ENODEV; > - } > + if (!serio_match_port(drv->id_table, serio)) > + return 0; > > - error = device_bind_driver(&serio->dev); > - if (error) { > - dev_warn(&serio->dev, > - "device_bind_driver() failed for %s (%s) and %s, error: %d\n", > - serio->phys, serio->name, > - drv->description, error); > - serio_disconnect_driver(serio); > - serio->dev.driver = NULL; > - return error; > - } > - } > - return 0; > + return device_driver_attach(&drv->driver, &serio->dev); I am not sure how safe it is, serio (and gameport) have pretty elaborate structure and locking rules because they can recurse into themselves (to support case of Synaptics touch-pads with pass-through PS/2 ports). But this call is for user-initiated probing anyways, I am not sure if it even needs "trust" handling. ... And I even thinking if we really need to keep these custom attributes or if I can rip them out in the future ... Thanks. -- Dmitry