From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Myeonghun Pak <mhun512@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Ijae Kim <ae878000@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] usb: typec: hd3ss3220: disable the interrupt before unregistering the port
Date: Tue, 17 Nov 2026 11:18:42 +0100 [thread overview]
Message-ID: <avwqAvnAKoDkTggQ@black.igk.intel.com> (raw)
In-Reply-To: <20261112065613.34182-1-mhun512@gmail.com>
On Thu, Nov 12, 2026 at 01:56:13AM -0500, Myeonghun Pak wrote:
> The devm-managed IRQ remains active while hd3ss3220_remove() unregisters
> the Type-C port and releases the role switch. A cable event during unbind
> can make hd3ss3220_set_role() access either resource after release.
>
> Disable and synchronize the IRQ before teardown, matching the existing
> polling-work cancellation. The ID pin IRQ needs no change: its GPIO and
> regulator are acquired before it, so devres releases that IRQ first.
>
> Found by a static analysis tool under development.
> Not tested on hardware.
So why still use the managed version of the function to request the
irq? Why not just concert the driver to "normal" request_irq and
free_irq?
Thanks,
> Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller")
> Cc: stable@vger.kernel.org
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> ---
>
> drivers/usb/typec/hd3ss3220.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
> index 60d6de9ba339..19c5dbdc97a1 100644
> --- a/drivers/usb/typec/hd3ss3220.c
> +++ b/drivers/usb/typec/hd3ss3220.c
> @@ -554,6 +554,8 @@ static void hd3ss3220_remove(struct i2c_client *client)
>
> if (hd3ss3220->poll)
> cancel_delayed_work_sync(&hd3ss3220->output_poll_work);
> + else
> + disable_irq(client->irq);
>
> typec_unregister_port(hd3ss3220->port);
> usb_role_switch_put(hd3ss3220->role_sw);
>
> base-commit: 630059a5a632377b9b7b487baccde92b7ae1dd47
> --
> 2.43.0
--
heikki
prev parent reply other threads:[~2026-11-17 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 6:56 [PATCH] usb: typec: hd3ss3220: disable the interrupt before unregistering the port Myeonghun Pak
2026-11-12 7:07 ` sashiko-bot
2026-11-17 10:18 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avwqAvnAKoDkTggQ@black.igk.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=ae878000@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mhun512@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox