From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: aiyengar1990@gmail.com
Cc: Badhri Jagan Sridharan <badhri@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Heiko Stuebner <heiko@sntech.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 2/2] usb: typec: fusb302: Toggle with the default Rp current
Date: Tue, 17 Nov 2026 11:43:12 +0100 [thread overview]
Message-ID: <avwvwBLFBHCc36dc@black.igk.intel.com> (raw)
In-Reply-To: <20261112-tcpm-attach-reboot-v2-2-b4bc6ca83490@gmail.com>
On Thu, Nov 12, 2026 at 08:23:34AM +0000, Arun Iyengar via B4 Relay wrote:
> From: Arun Iyengar <aiyengar1990@gmail.com>
>
> tcpm_start_toggling() programs the Rp current that tcpm asks for, which
> is the current of the source PDO (Rp 3.0A on boards that can source
> 3A) when the port starts toggling from Unattached.SRC, and the default
> current when it starts from Unattached.SNK after a detach.
>
> A Genesys Logic based USB-C to DisplayPort cable connected to the
> Orange Pi 5 is often not detected after a warm reboot: the FUSB302
> toggle state machine raises no interrupt with it while it drives the
> high Rp current, but finds it within seconds once toggling restarts
> with the default current after another device was detached.
>
> Toggle with the default current, and switch to the requested one when
> toggling stops on a sink, before tcpm is told about the attach, so the
> sink sees the configured level from the start of the connection as
> before. tcpm does not set it again after attach on every path (not on
> ports without PD, for instance). The Rd detection threshold used for
> unplug detection follows the restored current.
>
> The FUSB302B datasheet sets the toggle up the same way: under "Toggle
> Functionality" the processor writes HOST_CUR for the default current
> before it sets TOGGLE, and a HOST_CUR change after attach is applied to
> the CC line immediately ("HOST_CUR Changed After Attach").
>
> Fixes: c034a43e72dd ("staging: typec: Fairchild FUSB302 Type-c chip driver")
> Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>
Looks okay to me, but you need to CC stable:
https://docs.kernel.org/process/submitting-patches.html#select-the-recipients-for-your-patch
But let's wait for comments from Badhri to the tcpm patch.
Thanks,
> ---
> drivers/usb/typec/tcpm/fusb302.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 3319f6a2b0c9..44aa05fd4ba2 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -97,6 +97,7 @@ struct fusb302_chip {
> /* chip status */
> enum toggling_mode toggling_mode;
> enum src_current_status src_current_status;
> + enum src_current_status toggling_src_current;
> bool intr_togdone;
> bool intr_bc_lvl;
> bool intr_comp_chng;
> @@ -942,10 +943,19 @@ static int tcpm_start_toggling(struct tcpc_dev *dev,
> }
>
> mutex_lock(&chip->lock);
> - ret = fusb302_set_src_current(chip, cc_src_current[cc]);
> + /*
> + * Look for a partner with the default USB current advertisement.
> + * Some sinks (seen with a Genesys Logic based USB-C to DisplayPort
> + * cable) present an Rd that the FUSB302 toggle state machine does
> + * not detect while it drives the high (3.0 A) Rp current, so they
> + * are only found when toggling starts from the sink side. The
> + * requested current is restored when toggling finds a sink.
> + */
> + chip->toggling_src_current = cc_src_current[cc];
> + ret = fusb302_set_src_current(chip, SRC_CURRENT_DEFAULT);
> if (ret < 0) {
> fusb302_log(chip, "unable to set src current %s, ret=%d",
> - typec_cc_status_name[cc], ret);
> + typec_cc_status_name[TYPEC_CC_RP_DEF], ret);
> goto done;
> }
> ret = fusb302_set_toggling(chip, mode);
> @@ -1357,6 +1367,13 @@ static int fusb302_handle_togdone_src(struct fusb302_chip *chip,
> typec_cc_status_name[cc2]);
> return fusb302_set_toggling(chip, toggling_mode);
> }
> + /* advertise the requested Rp current now that a sink is attached */
> + ret = fusb302_set_src_current(chip, chip->toggling_src_current);
> + if (ret < 0) {
> + fusb302_log(chip, "cannot set src current, ret=%d", ret);
> + return ret;
> + }
> + rd_mda = rd_mda_value[chip->src_current_status];
> /* set polarity and pull_up, pull_down */
> ret = fusb302_set_cc_polarity_and_pull(chip, cc_polarity, true, false);
> if (ret < 0) {
>
> --
> 2.55.0
>
--
heikki
prev parent reply other threads:[~2026-11-17 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:23 [PATCH v2 0/2] usb: typec: Find a Type-C partner after a warm reboot on the Orange Pi 5 Arun Iyengar via B4 Relay
2026-11-12 8:23 ` [PATCH v2 1/2] usb: typec: tcpm: Don't cut a pending state delay short on a re-queue Arun Iyengar via B4 Relay
2026-11-12 8:36 ` sashiko-bot
2026-11-12 8:23 ` [PATCH v2 2/2] usb: typec: fusb302: Toggle with the default Rp current Arun Iyengar via B4 Relay
2026-11-12 8:45 ` sashiko-bot
2026-11-17 10:43 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avwvwBLFBHCc36dc@black.igk.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=aiyengar1990@gmail.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox