From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
oneukum@suse.com, broonie@kernel.org, stable@kernel.org
Subject: Re: [RFT PATCH v3 1/1] usb: hub: Fix flushing of delayed work used for post resume purposes
Date: Sat, 28 Jun 2025 00:40:36 +0200 [thread overview]
Message-ID: <b03ce446-3932-4588-8392-eb5eae69388a@oss.qualcomm.com> (raw)
In-Reply-To: <20250627164348.3982628-2-mathias.nyman@linux.intel.com>
On 6/27/25 6:43 PM, Mathias Nyman wrote:
> Delayed work that prevents USB3 hubs from runtime-suspending too early
> needed to be flushed in hub_quiesce() to resolve issues detected on
> QC SC8280XP CRD board during suspend resume testing.
>
> This flushing did however trigger new issues on Raspberry Pi 3B+, which
> doesn't have USB3 ports, and doesn't queue any post resume delayed work.
>
> The flushed 'hub->init_work' item is used for several purposes, and
> is originally initialized with a 'NULL' work function. The work function
> is also changed on the fly, which may contribute to the issue.
>
> Solve this by creating a dedicated delayed work item for post resume work,
> and flush that delayed work in hub_quiesce()
>
> Cc: stable@kernel.org
> Fixes: a49e1e2e785f ("usb: hub: Fix flushing and scheduling of delayed work that tunes runtime pm")
> Reported-by: Mark Brown <broonie@kernel.org>
> Closes: https://lore.kernel.org/linux-usb/aF5rNp1l0LWITnEB@finisterre.sirena.org.uk
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---
Still no issues, thanks for working on this!
Tested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> # SC8280XP CRD
Konrad
next prev parent reply other threads:[~2025-06-27 22:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 16:43 [RFT PATCH v3 0/1] Fix "detection of high tier USB3 devices" patch in usb-linus Mathias Nyman
2025-06-27 16:43 ` [RFT PATCH v3 1/1] usb: hub: Fix flushing of delayed work used for post resume purposes Mathias Nyman
2025-06-27 21:42 ` Mark Brown
2025-06-27 22:40 ` Konrad Dybcio [this message]
2025-06-28 14:46 ` Greg KH
2025-06-30 10:07 ` Mathias Nyman
2025-06-30 11:19 ` Greg KH
2025-06-30 13:15 ` Mathias Nyman
2025-06-30 13:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b03ce446-3932-4588-8392-eb5eae69388a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=oneukum@suse.com \
--cc=stable@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox