From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2243AC433F5 for ; Mon, 7 Mar 2022 10:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235853AbiCGKWN (ORCPT ); Mon, 7 Mar 2022 05:22:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242238AbiCGKVo (ORCPT ); Mon, 7 Mar 2022 05:21:44 -0500 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B661E91AD9; Mon, 7 Mar 2022 01:59:09 -0800 (PST) Received: by mail-ed1-f51.google.com with SMTP id g3so6852395edu.1; Mon, 07 Mar 2022 01:59:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=emPv8yHEbh1YE9SCKIsxMDOq9Zz4Ptvwa2GcQv1Z+hM=; b=OadxZxp3Xtab4zSTRwEelj2mSf/dusqrXVrNTqv4640Mi6G00TgTPwln74KdKpcyfA aRJpEG7QBc7BkeQ+G+MN6o+RaQMki3BGhhyWsKJQZRYqFjAJFZGgQxELOkDhK/Z8MUxp TrRkJNZ6GlF2dYKnKNcMH7gYffM/Y3dCB8L7oXeEZqOLLQwAXhUoZiiQaii5Qe0up7i+ U/r7zKNfnoCumb8IT5Mc6bSxesQOBpxcfGs/JnTtYOJFt9cWK6bOS4in+FLp7qb6zWKw LrR/BTvm0J75eoeBU6bTebtwU/U4Cq8MuJhgVZur0teLb/pOqHL/ApjHRqUeu2aS0oBy gkcA== X-Gm-Message-State: AOAM531RtyyinLdspxleDgRnHwSM68KQig273CLXzmGT+3IYINC35PQP jbkdgsLo3BFzZeWQp7AaCBc= X-Google-Smtp-Source: ABdhPJzoGyYfAYB6nfgcVwSAi8fMR9L+WN8Rrg/k8CRIYX2dSeQXs/V/a8sVhQrMlIsmK0vawbtRWw== X-Received: by 2002:a05:6402:5cb:b0:415:e04a:5230 with SMTP id n11-20020a05640205cb00b00415e04a5230mr10324425edx.352.1646647148186; Mon, 07 Mar 2022 01:59:08 -0800 (PST) Received: from [192.168.0.141] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.googlemail.com with ESMTPSA id w15-20020a056402268f00b00416474fbb42sm1343613edd.19.2022.03.07.01.59.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 01:59:07 -0800 (PST) Message-ID: Date: Mon, 7 Mar 2022 10:59:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1 1/4] usb: host: export symbols for xhci hooks usage Content-Language: en-US To: Daehwan Jung , Mathias Nyman , Greg Kroah-Hartman Cc: "open list:USB XHCI DRIVER" , open list , Howard Yen , Jack Pham , Puma Hsu , "J . Avila" , "chihhao . chen" , sc.suh@samsung.com, cpgs@samsung.com, cpgsproxy5@samsung.com References: <1646375038-72082-1-git-send-email-dh10.jung@samsung.com> <252651381.41646375583002.JavaMail.epsvc@epcpadp4> From: Krzysztof Kozlowski In-Reply-To: <252651381.41646375583002.JavaMail.epsvc@epcpadp4> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 04/03/2022 07:23, Daehwan Jung wrote: > Export symbols for xhci hooks usage: > xhci_ring_free > - Allow xhci hook to free xhci_ring. Instead of copying-pasting the name of function, please explain why do you need these symbols exported. The "Why" is actually one of most important questions, because "what is this patch doing" we can easily see... > > xhci_get_slot_ctx > - Allow xhci hook to get slot_ctx from the xhci_container_ctx > for getting the slot_ctx information to know which slot is > offloading and compare the context in remote subsystem memory > if needed. > Best regards, Krzysztof