From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C774CCA47A for ; Tue, 14 Jun 2022 08:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237658AbiFNISw (ORCPT ); Tue, 14 Jun 2022 04:18:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238376AbiFNISk (ORCPT ); Tue, 14 Jun 2022 04:18:40 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDD7431909; Tue, 14 Jun 2022 01:18:36 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4CE6466016A3; Tue, 14 Jun 2022 09:18:34 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1655194715; bh=Cw/na1mc/n4ulkCkHxjhk4ohR9mOorae6t4vSBiOhsc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SaW2qunPUtIE3pre/BJlEaiLfJBoXlsjXGbXeHG6DHQT6vlbHnmTgNUEfDPKR0uKg 7E8ynPbBNQn3bxNbMz4pcL/89NaPSJAgp0hbYYusyaXh8uBT8q2kIFI9IdK9By8QYw qPEG+lVxyXFfwoJke+KHCJ9zrCldJmkYdja84j6K4p1c/ZlzR/HfQAGgtiK3YmTMN3 2H1JaNF9FlJniI09O+nBLjXKqUezAs0taiOWxCT6Zp7Xsq//cEwuS+jBM9WHWFo1qz 3sUb9rv7WWOiQWFGhw3yKn8q+W/3EMKsEvBlYOLYatcJkMsEarD2Gt3oIHFJpLlWsy ROrzLf1FDPWAA== Message-ID: Date: Tue, 14 Jun 2022 10:18:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 6/7] drm/bridge: anx7625: Register Type-C mode switches Content-Language: en-US To: Prashant Malani , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: heikki.krogerus@linux.intel.com, Andrzej Hajda , Neil Armstrong , David Airlie , "open list:DRM DRIVERS" , Laurent Pinchart , Krzysztof Kozlowski , Sam Ravnborg , Jernej Skrabec , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Thomas Zimmermann , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Jonas Karlman , swboyd@chromium.org, Pin-Yen Lin , Rob Herring , Maxime Ripard , Hsin-Yi Wang , Xin Ji , Greg Kroah-Hartman , Robert Foss , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= References: <20220609181106.3695103-1-pmalani@chromium.org> <20220609181106.3695103-7-pmalani@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20220609181106.3695103-7-pmalani@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Il 09/06/22 20:09, Prashant Malani ha scritto: > When the DT node has "switches" available, register a Type-C mode-switch > for each listed "switch". This allows the driver to receive state > information about what operating mode a Type-C port and its connected > peripherals are in, as well as status information (like VDOs) related to > that state. > > The callback function is currently a stub, but subsequent patches will > implement the required functionality. > > Signed-off-by: Prashant Malani > --- > > Changes since v2: > - No changes. > > drivers/gpu/drm/bridge/analogix/anx7625.c | 73 +++++++++++++++++++++++ > drivers/gpu/drm/bridge/analogix/anx7625.h | 6 ++ > 2 files changed, 79 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 07ed44c6b839..d41a21103bd3 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > > #include > @@ -2581,9 +2582,59 @@ static void anx7625_runtime_disable(void *data) > pm_runtime_disable(data); > } > > +static int anx7625_typec_mux_set(struct typec_mux_dev *mux, > + struct typec_mux_state *state) > +{ > + return 0; > +} > + > +static int anx7625_register_mode_switch(struct device *dev, struct device_node *node, > + struct anx7625_data *ctx) > +{ > + struct anx7625_port_data *port_data; > + struct typec_mux_desc mux_desc = {}; > + char name[32]; > + u32 port_num; > + int ret; > + > + ret = of_property_read_u32(node, "reg", &port_num); > + if (ret) > + return ret; > + > + if (port_num >= ctx->num_typec_switches) { > + dev_err(dev, "Invalid port number specified: %d\n", port_num); > + return -EINVAL; > + } > + > + port_data = &ctx->typec_ports[port_num]; > + port_data->ctx = ctx; > + mux_desc.fwnode = &node->fwnode; > + mux_desc.drvdata = port_data; > + snprintf(name, sizeof(name), "%s-%u", node->name, port_num); > + mux_desc.name = name; > + mux_desc.set = anx7625_typec_mux_set; > + > + port_data->typec_mux = typec_mux_register(dev, &mux_desc); > + if (IS_ERR(port_data->typec_mux)) { > + ret = PTR_ERR(port_data->typec_mux); > + dev_err(dev, "Mode switch register for port %d failed: %d", port_num, ret); > + } Please return 0 at the end of this function. if (IS_ERR(....)) { ......code...... return ret; } return 0; } > + > + return ret; > +} > + > +static void anx7625_unregister_typec_switches(struct anx7625_data *ctx) > +{ > + int i; > + > + for (i = 0; i < ctx->num_typec_switches; i++) > + typec_mux_unregister(ctx->typec_ports[i].typec_mux); > +} > + > static int anx7625_register_typec_switches(struct device *device, struct anx7625_data *ctx) > { > struct device_node *of = NULL; > + struct device_node *sw; > int ret = 0; > > of = of_get_child_by_name(device->of_node, "switches"); > @@ -2594,6 +2645,26 @@ static int anx7625_register_typec_switches(struct device *device, struct anx7625 > if (ctx->num_typec_switches <= 0) > return -ENODEV; > > + ctx->typec_ports = devm_kzalloc(device, > + ctx->num_typec_switches * sizeof(struct anx7625_port_data), > + GFP_KERNEL); > + if (!ctx->typec_ports) > + return -ENOMEM; > + > + /* Register switches for each connector. */ > + for_each_available_child_of_node(of, sw) { > + if (!of_property_read_bool(sw, "mode-switch")) > + continue; > + ret = anx7625_register_mode_switch(device, sw, ctx); > + if (ret) { > + dev_err(device, "Failed to register mode switch: %d\n", ret); > + break; > + } > + } > + > + if (ret) > + anx7625_unregister_typec_switches(ctx); > + > return ret; > } > > @@ -2759,6 +2830,8 @@ static int anx7625_i2c_remove(struct i2c_client *client) > > drm_bridge_remove(&platform->bridge); > > + anx7625_unregister_typec_switches(platform); > + > if (platform->pdata.intp_irq) > destroy_workqueue(platform->workqueue); > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.h b/drivers/gpu/drm/bridge/analogix/anx7625.h > index d5cbca708842..76cfc64f7574 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.h > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.h > @@ -443,6 +443,11 @@ struct anx7625_i2c_client { > struct i2c_client *tcpc_client; > }; > > +struct anx7625_port_data { > + struct typec_mux_dev *typec_mux; > + struct anx7625_data *ctx; > +}; > + > struct anx7625_data { > struct anx7625_platform_data pdata; > struct platform_device *audio_pdev; > @@ -474,6 +479,7 @@ struct anx7625_data { > struct mipi_dsi_device *dsi; > struct drm_dp_aux aux; > int num_typec_switches; > + struct anx7625_port_data *typec_ports; > }; > > #endif /* __ANX7625_H__ */