From: Ferry Toth <fntoth@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Thinh Nguyen <thinhn@synopsys.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Subject: Re: [PATCH v4] usb: dwc3: Don't switch OTG -> peripheral if extcon is present
Date: Thu, 22 Sep 2022 16:30:09 +0200 [thread overview]
Message-ID: <b533e337-3d5f-c514-f0d1-e4684e3a5d64@gmail.com> (raw)
In-Reply-To: <Yyw0K/hcTZ02UP+A@smile.fi.intel.com>
Hi,
Resending this due to html reject, sorry.
On 22-09-2022 12:08, Andy Shevchenko wrote:
> On Sun, Apr 03, 2022 at 09:49:07AM -0700, Andrey Smirnov wrote:
>> If the extcon device exists, get the mode from the extcon device. If
>> the controller is DRD and the driver is unable to determine the mode,
>> only then default the dr_mode to USB_DR_MODE_PERIPHERAL.
> According to Ferry (Cc'ed) this broke Intel Merrifield platform. Ferry, can you
> share bisect log?
I can but not right now. But what I did was bisect between 5.18.0 (good)
and 5.19.0 (bad) then when I got near the culprit (~20 remaining) based
on the commit message I tried 0f01017191384e3962fa31520a9fd9846c3d352f
"usb: dwc3: Don't switch OTG -> peripheral if extcon is present" (bad)
and commit before that (good).
The effect of the patch is that on Merrifield (I tested with Intel
Edison Arduino board which has a HW switch to select between host and
device mode) device mode works but in host mode USB is completely not
working.
Currently on host mode - when working - superfluous error messages from
tusb1210 appear. When host mode is not working there are no tusb1210
messages in the logs / on the console at all. Seemingly tusb1210 is not
probed, which points in the direction of a relation to extcon.
> Taking into account the late cycle, I would like to revert the change. And
> Ferry and I would help to test any other (non-regressive) approach).
>
I have not yet tested if a simple revert fixes the problem but will tonight.
I would be happy to test other approaches too.
prev parent reply other threads:[~2022-09-22 14:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 16:49 [PATCH v4] usb: dwc3: Don't switch OTG -> peripheral if extcon is present Andrey Smirnov
2022-09-22 10:08 ` Andy Shevchenko
[not found] ` <691c3073-5105-9a2b-e6f2-ea0a4b8aaea8@gmail.com>
2022-09-22 13:29 ` Andy Shevchenko
2022-09-22 20:35 ` Ferry Toth
2022-09-22 23:32 ` Andrey Smirnov
2022-09-23 16:42 ` Andy Shevchenko
2022-09-23 18:23 ` Andrey Smirnov
2022-09-23 18:35 ` Sven Peter
2022-09-23 18:58 ` Andy Shevchenko
2022-09-24 1:07 ` Andrey Smirnov
2022-09-23 18:54 ` Andy Shevchenko
2022-09-24 1:27 ` Andrey Smirnov
2022-09-24 11:55 ` Ferry Toth
2022-09-23 20:10 ` Ferry Toth
2022-09-24 21:29 ` Ferry Toth
2022-09-25 19:21 ` Ferry Toth
2022-09-26 5:43 ` Andrey Smirnov
2022-09-26 10:19 ` Andy Shevchenko
2022-09-26 18:31 ` Andrey Smirnov
2022-09-27 12:21 ` Andy Shevchenko
2022-09-26 10:45 ` Sven Peter
2022-09-23 21:12 ` Ferry Toth
2022-09-24 1:34 ` Andrey Smirnov
2022-09-24 16:06 ` Ferry Toth
2022-09-26 10:21 ` Andy Shevchenko
2022-09-22 14:30 ` Ferry Toth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b533e337-3d5f-c514-f0d1-e4684e3a5d64@gmail.com \
--to=fntoth@gmail.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andrew.smirnov@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thinhn@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).