From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: b-liu@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: Remove unnecessary check of musb->hcd in musb_handle_intr_connect()
Date: Tue, 17 Dec 2019 20:27:09 +0800 [thread overview]
Message-ID: <b5c78da3-3d64-c3d5-0820-39747063b572@gmail.com> (raw)
In-Reply-To: <20191217095911.GA2807137@kroah.com>
On 2019/12/17 17:59, Greg KH wrote:
> On Tue, Dec 17, 2019 at 05:50:23PM +0800, Jia-Ju Bai wrote:
>> In musb_handle_intr_connect(), musb->hcd should be non-null,
>> so the check of musb->hcd on line 783 could be dropped.
> Have you verified that this is always the case? How did you do that?
Ah, so sorry, I misunderstood your last message...
I have not verified it, but I thought you made sure of it from your last
message, sorry...
In my opinion, adding an if check is safer, as shown in my last patch:
"usb: musb: Fix a possible null-pointer dereference in
musb_handle_intr_connect()"
I recall that Bin Liu has applied my last patch:
https://patchwork.kernel.org/patch/11283007/
Maybe we can listen to his opinion or other people's opinions?
Best wishes,
Jia-Ju Bai
next prev parent reply other threads:[~2019-12-17 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 9:50 [PATCH] usb: musb: Remove unnecessary check of musb->hcd in musb_handle_intr_connect() Jia-Ju Bai
2019-12-17 9:59 ` Greg KH
2019-12-17 12:27 ` Jia-Ju Bai [this message]
2019-12-17 19:15 ` Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5c78da3-3d64-c3d5-0820-39747063b572@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox