From: Andreas Larsson <andreas@gaisler.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH] usb: uhci-grlib: Explicitly include linux/platform_device.h
Date: Mon, 29 Jan 2024 08:41:50 +0100 [thread overview]
Message-ID: <b6b66bed-10f1-421a-a561-3e07dcbd6781@gaisler.com> (raw)
In-Reply-To: <2024012740-amaretto-unvarying-465a@gregkh>
On 2024-01-28 01:31, Greg Kroah-Hartman wrote:
> On Mon, Jan 22, 2024 at 09:22:25AM +0100, Andreas Larsson wrote:
>> This fixes relying upon linux/of_platform.h to include
>> linux/platform_device.h, which it no longer does, thereby fixing
>> compilation problems like:
>>
>> In file included from drivers/usb/host/uhci-hcd.c:850:
>> drivers/usb/host/uhci-grlib.c: In function 'uhci_hcd_grlib_probe':
>> drivers/usb/host/uhci-grlib.c:92:29: error: invalid use of undefined type 'struct platform_device'
>> 92 | struct device_node *dn = op->dev.of_node;
>> | ^~
>>
>> Fixes: 0d18bcdebb2f ("of: Stop circularly including of_device.h and of_platform.h")
>
> I don't see this commit id in Linus's tree, where is it?
Ah, sorry, it went into Linus's tree with a different commit ID. I
should have referred to ef175b29a242.
Cheers,
Andreas
next prev parent reply other threads:[~2024-01-29 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 8:22 [PATCH] usb: uhci-grlib: Explicitly include linux/platform_device.h Andreas Larsson
2024-01-28 0:31 ` Greg Kroah-Hartman
2024-01-29 7:41 ` Andreas Larsson [this message]
2024-01-29 7:50 ` [PATCH v2] " Andreas Larsson
2024-01-29 14:58 ` [PATCH] " Greg Kroah-Hartman
2024-01-29 14:59 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6b66bed-10f1-421a-a561-3e07dcbd6781@gaisler.com \
--to=andreas@gaisler.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=software@gaisler.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox