From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8532DC83F16 for ; Mon, 28 Aug 2023 09:09:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229836AbjH1JJK (ORCPT ); Mon, 28 Aug 2023 05:09:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbjH1JJC (ORCPT ); Mon, 28 Aug 2023 05:09:02 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36B1CEC; Mon, 28 Aug 2023 02:08:59 -0700 (PDT) Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 37S8ToSK019577; Mon, 28 Aug 2023 11:08:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=RIeyJQL+u2vdhhZw1cZ55V2faZmr6SzcYSUzeq8kbnY=; b=YG bB4tcvSz1iM/2DY4v+yACoJfYlkPGNoz6lJs22mvQuDWm8RtfvIDRAOOi+bOhFKJ sR05/Z8gmUuyX3PKg7w7l/di3UPdWbiRfJZxH7T0ax/e3mZRFD0Yel0ZQy0i1XX9 PYYnbNFx+mxlpc6hn+32TQEpjH6yAF7C1E9PlZ/s0u1mx8Xi90JX8NKnmPIrJgfJ Nsl6XrWzkJbrbdpcJeSdyBZhwx+QP/kUn+M6J+KU3M2dpPbfrOCk+C7eNJA/0KHS A3UitZQIGI4BkT9fuBLFxI37li78Cr+qgB8zhpeqxa9K9zOlMedUEBrACPqGdd2c kj8yj176vGiTyXeprbmw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3sq89bprxj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Aug 2023 11:08:50 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id DA42510005F; Mon, 28 Aug 2023 11:08:49 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id CD64821861F; Mon, 28 Aug 2023 11:08:49 +0200 (CEST) Received: from [10.201.20.38] (10.201.20.38) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 28 Aug 2023 11:08:49 +0200 Message-ID: Date: Mon, 28 Aug 2023 11:08:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 30/30] usb: ohci-st: Use devm_platform_get_and_ioremap_resource() Content-Language: en-US To: Yangtao Li , Alan Stern , Greg Kroah-Hartman CC: , , References: <20230726113816.888-1-frank.li@vivo.com> <20230726113816.888-30-frank.li@vivo.com> From: Patrice CHOTARD In-Reply-To: <20230726113816.888-30-frank.li@vivo.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.20.38] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-28_06,2023-08-25_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 7/26/23 13:38, Yangtao Li wrote: > Convert platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Signed-off-by: Yangtao Li > --- > drivers/usb/host/ohci-st.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c > index 884e447a8098..214342013f7e 100644 > --- a/drivers/usb/host/ohci-st.c > +++ b/drivers/usb/host/ohci-st.c > @@ -139,12 +139,6 @@ static int st_ohci_platform_probe(struct platform_device *dev) > if (irq < 0) > return irq; > > - res_mem = platform_get_resource(dev, IORESOURCE_MEM, 0); > - if (!res_mem) { > - dev_err(&dev->dev, "no memory resource provided"); > - return -ENXIO; > - } > - > hcd = usb_create_hcd(&ohci_platform_hc_driver, &dev->dev, > dev_name(&dev->dev)); > if (!hcd) > @@ -199,14 +193,14 @@ static int st_ohci_platform_probe(struct platform_device *dev) > goto err_power; > } > > - hcd->rsrc_start = res_mem->start; > - hcd->rsrc_len = resource_size(res_mem); > - > - hcd->regs = devm_ioremap_resource(&dev->dev, res_mem); > + hcd->regs = devm_platform_get_and_ioremap_resource(dev, 0, &res_mem); > if (IS_ERR(hcd->regs)) { > err = PTR_ERR(hcd->regs); > goto err_power; > } > + hcd->rsrc_start = res_mem->start; > + hcd->rsrc_len = resource_size(res_mem); > + > err = usb_add_hcd(hcd, irq, IRQF_SHARED); > if (err) > goto err_power; Reviewed-by: Patrice Chotard Thanks Patrice